Recording Enhancements Pack

[Mmmm]

Anyone heard anything from vinylIvo recently? I'd like to see and update to the histogram patch to go with the current AGC build.. I kinda miss the pretty pictures..

Bump.. anyone?!

Well, I've merged his histogram patch with batt/balance meters into the REP So pretty pictures are with us once more

Unfortunately the screen real estate is getting a bit thin on the ground and using larger fonts is getting to be impossible on the H1xx (you can just about fit in a font with height of 10 now)....you lucky H3xx owners you with your big screen......

Patch/build/new screenshots in post#1

[Mmmm]

Or perhaps a filesize and time-limit cap (with an option to split or stop recording when the cap is reached).

So Jaybee and Llorean, I have made a patch which I have attached and it is also on the tracker. Not in the REP yet but it will be.... So Jaybee no more filling your player with rubbish all night!

These are the filesize split points I have used...any obvious ones I have missed? (2GB is max file size anyway so it automatically splits there).
off,5MB,10MB,15MB,30MB,60MB,75MB,90MB,100MB,200MB,400MB,650MB,700MB,
1GB,1.5GB,1.75GB

http://www.rockbox.org/tracker/task/5605

[attachment deleted by admin, too old]

[paulheu]

There's a problem when  using black backgrounds as the font color is always black..

Replacing lcd_set_foreground(LCD_DEFAULT_FG) with lcd_set_foreground(global_settings.fg_color) works for me.. (in recording.c)

[jaybeee]

Or perhaps a filesize and time-limit cap (with an option to split or stop recording when the cap is reached).

So Jaybee and Llorean, I have made a patch which I have attached and it is also on the tracker. Not in the REP yet but it will be.... So Jaybee no more filling your player with rubbish all night!

These are the filesize split points I have used...any obvious ones I have missed? (2GB is max file size anyway so it automatically splits there).
off,5MB,10MB,15MB,30MB,60MB,75MB,90MB,100MB,200MB,400MB,650MB,700MB,
1GB,1.5GB,1.75GB

http://www.rockbox.org/tracker/task/5605

great stuff Mmmm 

Couple of things:
(1) do you think the alternative option to specify a time to stop recording could be achieved? Without vbr recording (i.e. just wav) this option would be relevant and useful.
(2) With your current code, how would I ask my player to stop after say 2.5gb? (that would be approx 2 1/2 hrs with 44.1khz using normal line in). I know that a file will split after 2gb, so 2.5gb couldn't be achieved, BUT then it looks as if it can only ask for the max 2gb to be recorded then stop the player - or am I missing something?

thanks

[Mmmm]

Couple of things:
(1) do you think the alternative option to specify a time to stop recording could be achieved? Without vbr recording (i.e. just wav) this option would be relevant and useful.

Do you mean the time as in 2.15pm type of thing? you can't do this on the H120 as is doesnt have a clock! My pach allows you to tell it to stop recording after a set amount of time.

(2) With your current code, how would I ask my player to stop after say 2.5gb? (that would be approx 2 1/2 hrs with 44.1khz using normal line in). I know that a file will split after 2gb, so 2.5gb couldn't be achieved, BUT then it looks as if it can only ask for the max 2gb to be recorded then stop the player - or am I missing something?

thanks

You want more? how far do you want to go?
I thought 2GB is about 3 hrs 25 mins of wav recording (if 10mb = 1 min) - isn't that right? Also the way I have done it it will only split at 2GB so the max for stopping at the mo is only 1.75 GB... I could change that relatively easily though...I would need to have a 'no split' option in 'split measure' though or people would be very annoyed if they had forgotten they had it set to stop and it stopped after 2GB (even with both time and size set to off) eh?

[Llorean]

I think he meant "Record 1 hour of audio" type of thing. Not a specific time to cut off, but rather a duration limit as an alternative choice to a filesize limit. While the two directly correlate in CBR formats (which is all we support right now) with VBR ones, duration and filesize aren't so closely linked.

[Mmmm]

I think he meant "Record 1 hour of audio" type of thing. Not a specific time to cut off, but rather a duration limit as an alternative choice to a filesize limit. While the two directly correlate in CBR formats (which is all we support right now) with VBR ones, duration and filesize aren't so closely linked.

Unless I'm really misunderstanding, my patch already does this...In fact the cvs version allows you to specify a time for a split too..my patch adds a stop option and a filesize option (adds not replaces) which you can use in any combination. 

[Llorean]

I was just putting forth my input as to what I think he was trying to ask.

But isn't the current time split option only capable of splitting after a certain period of time, not halting recording?

[Mmmm]

  Yep...and my patch adds the ability to stop the recording....
so you can have:

stop recording after 1 hour
Or
start a new file after 2 hours
Or
stop recording after 650MB
Or
start a new file after 700MB
etc etc...



Sorry...it's probably that I wasn't really being clear about what it does...I'm like that when I get excited about having written a bit of code!

[Llorean]

Alright, so with your patch it meets all the requests.
Yeah, it wasn't clear that yours added the option to stop for time, instead of just splitting for time. Sounds great.

[jaybeee]

 

It seems you two figured out what I was trying to say without me having to explain, te he

And yes, it's basically as Llorean said. Cos your first post about the patch didn't mention time splits.  All I was trying to get at was: if I want to record something that is 4 hours long, I know at the moment that will create one 2gb file being about 3hrs 22mins long, and then a second file being 38mins long; so I was just trying to see if asking the player to record me 4hrs then stop was possible.  Seems it is   

--

I like the option about startng a new file after a certain time too.

--

I guess with the feature freeze still on, this isn't gonna get commited anytime soon. Trouble is, I've never added a patch into the package before, so might not be able to test it.

[Mmmm]

Don't worry jaybee....eventually (probably tomorrow) I'll put it in the REP and you can download a patched build from my sig if you want...I'll post here once I've done it

I like the option about startng a new file after a certain time too.

You can do this already without the patch! it's called timesplit!!! 

[jaybeee]

I like the option about startng a new file after a certain time too.

You can do this already without the patch! it's called timesplit!!! 

lol
yes i did know that. What an idiot lol
thanks in advance for the patched build 

[Mmmm]

I like the option about startng a new file after a certain time too.

You can do this already without the patch! it's called timesplit!!! 

lol
yes i did know that. What an idiot lol
thanks in advance for the patched build 

  lol....

I've put it in now so you can use the build in my sig (if you have an H120/H140) or the patch is in post#1 as per usual...
Tell me if there is anything you would like improved...and I'll think about it

[Mmmm]

There's a problem when  using black backgrounds as the font color is always black..

Replacing lcd_set_foreground(LCD_DEFAULT_FG) with lcd_set_foreground(global_settings.fg_color) works for me.. (in recording.c)

hmmm I remember you saying this before, and I seem to remember that this breaks the h1xx build (as it doesn't have a colour screen) so maybe a bit of preprocessing magic is needed eh?

something like:

    lcd_set_foreground(
#ifdef HAVE_LCD_COLOR
    global_settings.fg_color);
#else
    LCD_DEFAULT_FG);
#endif

or something?