Recording Enhancements Pack

[Mmmm]

The bug with the change fonts patch doesn't go away when you reset settings! what happens is that it make the volume display in the status bar a graphic instead of numeric display (I always have it on numeric), which seems to fix it but doesn't.

if you change the volume when in graphic display, the display momentarily changes to numeric and the bug appears...and then it goes again when the graphic comes back! Weird eh?

It seems that a numeric volume makes the main screen peakmeter draw on the remote! :-S
 Very odd! ahh well...

[Mmmm]

Right, this time I have the culprit...

In the statusbar code it changes the font to the user font if you have the numerical volume displayed! So straight after the call to the statusbar I have reset the font on the remote to the system font...et voila... it works...phew....
So changeable fonts are now working quite well...!

can I have that rest I was talking about earlier now? :-D

For the ready built version look at the last link I provided.... (post #23)



[attachment deleted by admin, too old]

[whatboutbob]

- It's showing (A) or (D) if the gain is changed in the Analog or Digital domain. From 0 to +24 it says (A), but from +24.5 it says (D). Could it be worth the space to have it say (A+D) - as I'm sure is the case.

And! I would like to have the settings for the peak meter duplicated in the recording settings screen.

You are probably right about the peakmeter settings...I think it would be good here too.. but would we then have the same settings in two places?

Just thought I'd quickly mention here that the range on the remote, last time I checked (a few days ago), isn't actually accurate.  If you have a peakmeter range of say -30 to 0 set, while the main screen might be peaking at -30, it doesn't show on the remote until say -25.  I imagine its simply because the  remote screen is thinner.  So I guess what I'm saying is I won't be averse to having a 'remote peak meter settings' option.  But UI's never been my forte.

[Mmmm]

Just thought I'd quickly mention here that the range on the remote, last time I checked (a few days ago), isn't actually accurate.  If you have a peakmeter range of say -30 to 0 set, while the main screen might be peaking at -30, it doesn't show on the remote until say -25.

Do not fret.... I have a fix for this.... I'm just trying to get the scale marks correct on the remote...
With my new independent peakmeter for the changeable fonts build, fixes like this are just so much easier to do. I'll merge the new peakmeter and fixed remote range into the main build tomorrow (if i get those dots sorted!) :-)

[mlind]

- I can't use "browse .wps files" because the first wps in the list immediately gets chosen for use. So to use my own wps I must switch "Show files" to "All" go to .rockbox/wps/ with the normal browser instead.

Mine seems fine...no problems at all :-s

Reloaded my settings, but still the same behaviour

And! I would like to have the settings for the peak meter duplicated in the recording settings screen.

You are probably right about the peakmeter settings...I think it would be good here too.. but would we then have the same settings in two places?

That was my thought... Or perhaps different settings for playback/recording peak meter...

[Mmmm]

Right then...an update...

I got the remote peakmeter working accurately now it starts and ends at the same points as the main unit (even though it's a different size) and the scale markings are now correct too...

New build in my sig and the link to the patch is in post #1

==============================================================================

For all you customisable font fans, there is a new working build in the link in post #23 and the patch is attached below.

The two patches are now almost identical.
The way it is now coded means that it is incredibly easy to change the font in the code on either of the displays! :-)

Maybe I could try to hardcode a font in for h1xx/h3xx.  But I would need to know which font you think is best! (I haven't tried to do this yet though so don't get too excited, it may not be possible! :-D )

[attachment deleted by admin, too old]

[whatboutbob]

Mmmm: Thanks again for all your work.

I downloaded the build from post #23.  Am I correct in thinking that the recording screen font on the remote does not get updated, when the fonts/themes are changed?

Also, are the peakmeter changes checked in to that build?  It looks like the max range of the remote peak meter is less than the max range of the main unit.

[Mmmm]

Mmmm: Thanks again for all your work.

I downloaded the build from post #23.  Am I correct in thinking that the recording screen font on the remote does not get updated, when the fonts/themes are changed?

Remote font doesn't change as any larger font wouldn't fit...It is totally filled up with the default font as it is...Clever eh? :-)

Also, are the peakmeter changes checked in to that build?  It looks like the max range of the remote peak meter is less than the max range of the main unit.

Should be.... I'll check when I get home though....

[Mmmm]

Also, are the peakmeter changes checked in to that build?  It looks like the max range of the remote peak meter is less than the max range of the main unit.

Oops...a bug crept in there!
Ta for reporting it...I've just managed to fix it... try it now.

All builds/patches in the usual places :-D

[attachment deleted by admin, too old]

[Raptor]

Mmmm,

Would you be able to compile the recfontsrockbox build with all the patches in your rockbox build?

Also, just throwing the idea out there... if you had the time, you should start compiling the H100 Optimized Daily Builds, just like what needleboy does in the misticriver forums.

Thanks for all your work.. the patches and the recording enhancements are amazing!

[renho3k]

rogain = hair rejuvenating forumula *wink*

i tried to patch your recordingenhancementspack.patch with daily build 02/07/06 and i got a HUNK #2 failed error. this is my first time patching. i put the patch file in the root of the source. did i do something wrong or is the patch not compatible w/build 20060207?

$ patch --binary -p0 < recordingenhancementspack.patch

patching file apps/menu.c
patching file apps/menu.h
patching file apps/settings.c
Hunk #4 succeeded at 516 with fuzz 2 (offset -22 lines).
patching file apps/settings.h
Hunk #1 succeeded at 216 (offset -1 lines).
Hunk #2 succeeded at 233 (offset -1 lines).
patching file apps/sound_menu.c
Hunk #1 succeeded at 51 (offset -1 lines).
Hunk #2 succeeded at 241 (offset -1 lines).
Hunk #3 succeeded at 255 (offset -1 lines).
Hunk #4 succeeded at 338 (offset -1 lines).
Hunk #5 succeeded at 782 (offset -2 lines).
Hunk #6 succeeded at 794 (offset -2 lines).
Hunk #7 succeeded at 804 (offset -2 lines).
patching file apps/gui/gwps-common.c
patching file apps/lang/english.lang
Hunk #2 FAILED at 3701.
1 out of 2 hunks FAILED -- saving rejects to file apps/lang/english.lang.rej
patching file apps/recorder/peakmeter.c
patching file apps/recorder/peakmeter.h
patching file apps/recorder/radio.c
patching file apps/recorder/recording.c
patching file firmware/sound.c
patching file firmware/drivers/uda1380.c
patching file firmware/export/audio.h
patching file firmware/export/sound.h

[Mmmm]

Don't worry the build you are trying to patch is too old! it's nothing you have done! You should use the bleeding edge build.
or you could have a look in the patch and at english. lang, you should be able to input the changes manually, english.lang is fairly easy! :-)

[renho3k]

wow. i posted at 04:51:48pm and got a reply by 4:58:30pm. now that's service with a smile!

k, now i got the bleeding edge built and successfully patched it (just the enhancement pack, not the font changing one). everything more or less fits in the remote now as compared to thomas's patch that i was using before. the clip light also works fine. however, question about functionality of the clip light. once it clips, it turns on (duh) and stays on. what determines when the clip light turns off? is it just timed?

[mlind]

When clip indicator in peak meter goes off the light goes off.
You adjust this time in the settings for peak meter.

[whatboutbob]

When clip indicator in peak meter goes off the light goes off.
You adjust this time in the settings for peak meter.

When stealthing I set it to like 5 mins so that i just have a peek at the remote @ the end of particularly loud songs, and if the light ain't on, I'm laughing.

Something worth mentioning on the clipping indicator though...its not an exact tool...hence neither is the cliplight.  It is possible to clip without triggering the indicator.  The issues are at least twofold...but I'm running off memory here, which is unreliable at best.  I believe clipping needs to exist over two samples before its triggered (eg one loud clap won't trigger it).  Apparently it can also get false positives, and just not fire other times.  In other words, don't put complete faith in it.  Is that fair Mmmm?