Recording Enhancements Pack

[Mmmm]

OK Paul, here's a patch that will only allow changeable recording fonts to current cvs version.

This may not apply cleanly to vinylivo's version though, or it may and could still not work! If this is the case try the following:

Code: [Select]

You must make sure that in recording.c any w's and h's need to be changed to w[i] and h[i]
if they are within a FOR_NB_SCREENS(i) loop. If any of these are outside a loop do the same but change the i to a 0. 
and change anything like setfont(SYSFIXED) to setfont(font[i]) if it's in one of the loops.
If a setfont is outside a loop leave it alone!

Hopefully that should make sure all runs smoothly..... 
Good luck...

[attachment deleted by admin, too old]

[paulheu]

Indeed, the fontspatch does not work with the latest agc_histogram patch, the battery/diskspace/balance graphics disapear and do not return..

Oh well.. big(ger) fonts are nice but I can do without em (for now)..

[Mmmm]

Does the batt indicator go even when you are using the default font? It is supposed to disappear when a large font is used, as otherwise you just get a nasty mess (it overlaps).

On vinylivo's original the max font size was 12 which is pretty small and useless so I changed it slightly so that it overwrote the batt/disk/balance info. This way you can have larger fonts like chicago12 without any problems (just a small compromise).

Or is it that they never turn up at all?

[paulheu]

It never turns up, if I remove the screenclear around line 1550 it stays, but seems to not be updated with the fontpatch. I use a small enough font with plenty of space left..

[Mmmm]

Paul: Find this bit in recording.c

Code: [Select]

            /************** AGC Test Info only *************
            lcd_setfont(FONT_SYSFIXED);
            snprintf(buf, 32, "D:%d U:%d",
                     (agc_droptime+2)/5, (agc_risetime+2)/5);
            lcd_putsxy(1, LCD_HEIGHT - 8, buf);
            snprintf(buf, 32, "B:%d",
                     (agc_baltime+2)/5);
            lcd_putsxy(LCD_WIDTH/2 + 3, LCD_HEIGHT - 8, buf);
            ***********************************************/

            if (hist_bal_y > (8 + 8 * h[SCREEN_MAIN]))
            {
                lcd_setfont(FONT_SYSFIXED);
                if (charger_inserted())
                    lcd_mono_bitmap(bitmap_icons_7x8[Icon_Plug],
                                    2 + 19*(battery_level() > 48),

I reckon it must have something to do with this bit of code...
Especially that           

Code: [Select]

  if (hist_bal_y > (8 + 8 * h[SCREEN_MAIN]))

bit.
This is the condition for the drawing of the bat/disk/bal info.

hist_bal_y is the start point for drawing the graphs
the first 8 is the size of the status bar and the second is the number of lines of text that are displayed on the screen h[0] or h[SCREEN_MAIN] (same thing) is the height of the font on the main screen.

So the batt/disk/bal info is only displayed if the text doesn't run into it...

Is yours the same as mine?
If it is have a go at changing that second 8 to a 7

[paulheu]

I found that one and it appear to work... Had it set to h initially, but of course since this is always the main LCD h[0] is what it should be..

I'll do a bit of testing tonight and let you know what I come up with..

[Mmmm]

So it works now?

I was also thinking that seeing as you have a much bigger screen than I do, you might want to change this line

Code: [Select]

    FOR_NB_SCREENS(i)
    {
        screens[i].setfont(FONT_UI);
        screens[i].getstringsize("M", &w[i], &h[i]);
        if (i == SCREEN_MAIN) {
*****if (h[i] < ((LCD_HEIGHT - 16) / 8))]***********
                font[i] = FONT_UI;
            else
                font[i] = FONT_SYSFIXED;
        }
        else if (h[i] <= ((screens[i].height - 8) / 7))

(the ****** line)
Change that 16 to a 40, then the font will never be allowed to overwrite the batt/bal/disk info.
I only changed it because on the small H1xx screen this meant you couldn't get a decent sized font in before it reset to the system font...I don't think that this would be an issue for the H3xx. 

[paulheu]

in the fontsonly patch it is actually set to 40

[Mmmm]

in the fontsonly patch it is actually set to 40

Ha ha...really?? well...that saves a bit of time then eh 

I found that one and it appear to work... Had it set to h initially, but of course since this is always the main LCD h[0] is what it should be..

I'll do a bit of testing tonight and let you know what I come up with..

You still haven't said whether it works now or not! 
Didn't you set all h's to h[0] or h{i} like I said?

[paulheu]

I actually commented the 'int w,h;' lines out to find any missed ones, but get no errors. I did spot some leftover &h and &w var but they do not cause any warnings or errors..

I sortof expected them to, but it all works well sofar.. Should I turn all these &w and &h vars into &w[0] and &h[0] as well then ?

[Mmmm]

That's weird...the fonts patch should get rid of the 'int w,h' line, how come yours didn't?... 

The leftover &w's and &h's are probably within a #ifdef REC_F3 type precompiler thingy which means that when you compile for the iriver the compiler doesn't even look at this bit of code and so no errors... If you tried to compile for archos or something you would have to change to &w[0] etc or there would be errors galore. One of many reasons why the patch is really a load of crap! 

So there is no need to change anything if there are no compiler errors. Glad it's all working now....

[Davide-NYC]

Hey, are you guys are watching the optical recording progress going on right now?
It's still very alpha, but it seems to be working already.
Also, did you see my parts auction to benefit ROCKbox? (specifically the recording aspect on H1xx targets) I can't code, but I'm trying to do some good for this awesome project... :-P

[Mmmm]

New patch/build in post#1

Paul: your fonts patch will be broken now, are you ok to fix it yourself?

Davide: I'm watching and waiting! 

[paulheu]

It appears you're still using a previous version of the AGC patch as I get no color on the H3x0 with your complete patch and I do when I apply Ivo's latest current AGC patch..

[Mmmm]

Yeah you're right...I'm afraid that I've been struck by a bit of lazyitis!  Seeing as there is no colour on the h140 anyway I couldn't be bothered to update the patch to vinylivo's latest... 

Have you managed to make a patch with the fonts in? if so I'll use it and update that.