Recording Enhancements Pack

[paulheu]

what's the state of AGC?
- does it work ok
- on what devices does it run
- does the patch build for all targets

Works well

Runs on H1x0 and H3x0 that I know of.. I could wipe the dust of my archos recorder and see if it'll run ..

Have to try to see if it build for all targets too..

[petur]

There are really a number of changes in the patch. They are:

i) AGC
ii) Battery meter/warning
iii) Disk space meter/warning
iv) Histogram
v) Fonts

So you might want them separating before a commit. We need to PM vinylivo I think! 

Aargh.. I don't understand why people keep putting multiple changes in one patch... will have a look to extract the AGC

[groovetube66]

I started another thread not realizing their was the vu_meter plugin.  Can this plugin work with the recording enhancements patch to replace the led bar meters.  I really like vu meters as I find it easier to see where the overall level is setting.

[vinylivo]

Hi folks, here I'm back again.
Sorry that I was unavailable, but I just moved to a new place, and had some business trips too so there was no time left for programming.

The updated patch is on the Tracker:
http://www.rockbox.org/tracker/task/4748

This one only includes the AGC part. The histogram follows in a seperate patch.

[Mmmm]

Aggghhhhh just too late! 

Ah well....we'll just have to wait till the freeze is over eh? 

[larry_llama]

Mmmm, do you have a build for the h100 (h110/h115) or just the h120?

I will have to have a look at doing my own patching soon :-p

[paulheu]

Well.. we've lost the (bigger) fonts again.. and there's some other stuff changed. Guess we have some puzzling to do ..;^)

[paulheu]

OK.. so I tried filtering out the font bits to regain teh larger fonts, but it don't work as expected (or before).. guess too much changed. Oh well, let's hope we'll see a new patch from Mmmm soon..

In any case I now understand the need to keep each change in it's own patch.

[Mmmm]

Ok....I'm back from spain....It's FANTASTIC over there! 

Oh well, let's hope we'll see a new patch from Mmmm soon.

I've updated the patch and build in post no.1.............. So you can get your H3xx build up and going now Paulheu

[paulheu]

Welcome back man.. Glad you enjoyed yourself..

Could you post a patch with just 'your' stuff in it? so without the AGC and histogram patches which are now in the patchtracker?!

[paulheu]

Also, the patch in post #1 is against an older Histogram version, without the color bits..

[Mmmm]

Colour bits?? 

wow...how exciting...shame I live in a black and white h140 world eh? 
There isn't much of my stuff left! just the fonts I suppose..is that what you mean?

Are you using cvs update to do your updating? if not you may find this makes things much easier for you!

[paulheu]

Yes, yes and yes..

From what I know 'your part' of the patch constitutes the fonts and remote peakmeter?! I woul very much like to see these in a separate patch whcih would make it easier to do new builds as updates to AGC and/or histogram appear.. (like the 'color bits'.. )

[Mmmm]

Remote peakmeter has gone to cvs heaven along with all my other bits and bobs! just the fonts left which is an awful unrockboxish bit of coding so wont be seeing any cvs joy ever...so that's it! I'll look into a separate patch for you....

so are you 'cvs up -dP' ing or not? This will tell you where all the conflicts occur and makes it fairly easy to spot how to change them! Really useful!

[paulheu]

yes, I use cvs to update.. I tried patching a clean CSV with agc/histogram patches added and then using your patch to basically remove the 'double bits' and be left with the stuff that's yours.. but that does not work very well.. In part because it seems the agc/histogram patch you use is behind the current available patch (it seems)..

So yes, if the fonts is what's left of your original patch the I'd much appreciate a separate patchfile for that to make it easier to get into future builds.

thanks!
Paul