Support and General Use > Recording

Recording Enhancements Pack

<< < (37/189) > >>

Llorean:
Rockbox does not, and has never so far, supported WMA.

Mmmm:
An inspired bit of coding there Vinylivo.... I like it!  :)

Instead of setting the arrays to a size of '2' though, you could set them to the size of 'NB_SCREENS' so that any number of screens are supported and  instead of hardcoding the  height of the remote as 64, you could change


--- Code: ---else if (h[i] <= ((64 - 8) / 7))
--- End code ---
to

--- Code: ---else if (h[i] <= ((screens[i].height - 8) / 7))
--- End code ---
....I think that should work... :D

Anyway...good stuff, have you made a patch with my new display code in? I'll put it in my build in post#1 if you have..  :) I think with your screen size testing idea I will only need one build now! ;D


--- Quote from: bennis ---My player freezed dramatically ( reset button needed to be used) on some newly encoded music files, in wma format. Does Rockbox not support wma?? Can't recall having this problem before though...
--- End quote ---
No, Rockbox doesn't support WMA....are you sure you posted in the right thread?

vinylivo:

--- Quote from: Mmmm on March 16, 2006, 04:04:39 PM ---An inspired bit of coding there Vinylivo.... I like it!  :)

Instead of setting the arrays to a size of '2' though, you could set them to the size of 'NB_SCREENS' so that any number of screens are supported and  instead of hardcoding the  height of the remote as 64, you could change


--- Code: ---else if (h[i] <= ((64 - 8) / 7))
--- End code ---
to

--- Code: ---else if (h[i] <= ((screens[i].height - 8) / 7))
--- End code ---
....I think that should work... :D
--- End quote ---

Ah yes of course, don't know why I didn't think of that! I'll try that when I'm back home...

And by the way I used the remote support patch from the flyspray tracker.

Mmmm:

--- Quote from: vinylivo on March 17, 2006, 02:40:33 AM ---And by the way I used the remote support patch from the flyspray tracker.

--- End quote ---

I'm confused...that's  what paulheu said too.... but if so, how come the first change in your patch is

--- Code: ---                     peak_meter_draw(0, peak_meter_y, LCD_WIDTH,
-                                    MIN(h, LCD_HEIGHT - peak_meter_y));
+                                    MIN(h, LCD_HEIGHT - peak_meter_y), false);

--- End code ---
(from http://www.rockbox.org/bugs/task/4748)

Whereas the equivalent line in mine is

--- Code: ----                    peak_meter_draw(0, peak_meter_y, LCD_WIDTH,
-                                    MIN(h, LCD_HEIGHT - peak_meter_y));
+                    peak_meter_screen(gwps->display, 0, peak_meter_y,
+                                    MIN(h, display->height - peak_meter_y));

--- End code ---
(from http://www.rockbox.org/bugs/task/4818)

The line in your patch is from my original (it doesn't use the display gui)....or am i looking in the wrong place or something ???

Mmmm:
Well I've merged Vinylivo's and my patch myself and added the variable fonts and made a couple of tiny changes...

Unfortunately, because the histogram takes up so much room, you cant really get a really big font to fit the main screen...only 12 pixels high max! 13 just wont go!  :(

You gan get 13 in if you are in mic mode, but where 's the fun in that eh?   :D
I think the solution would be to move something...hmmmm I'll think about it...

Navigation

[0] Message Index

[#] Next page

[*] Previous page

Go to full version