Support and General Use > Recording
Recording Enhancements Pack
NPswimdude500:
I haven't read all of this thread, so this might have been suggested already, but since there's space, would it be possible to include the name of the recorded file in the recording screen?
^since there's room, how 'bout a line that says something like "Name: rec_0001.wav" ?
petur:
--- Quote from: vinylivo on March 07, 2006, 07:24:03 PM ---
--- Quote from: vinylivo on March 07, 2006, 06:27:42 AM ---Not shure if this is related to the enhancement pack or not.
There is a problem with automatic file splitting during recording if it should split at max. file size (max. 2GB FAT file size - 1MB).
--- End quote ---
I found the bug. It's not related to the enhancement pack at all. The bug is in 'pcm_recrd.c' in function 'pcmrec_start()':
Line 644 is wrong:
--- Code: --- num_rec_bytes = 0;
--- End code ---
it should be:
--- Code: --- num_rec_bytes = pre_chunks * CHUNK_SIZE;
--- End code ---
to take the prerecorded chunks into account.
--- End quote ---
Right. I wrote a long answer on this and reviewed the code while writing. As a result I got logged out before posting and my answer is lost. Damn.
To keep the long answer short: the bug is that num_rec_bytes is used in the recording screen (imho the wrong place) to determine file splitting.
I'll keep it like that for now as it involves too much rewriting... your bugfix should do.
I'll also increase the margin while I'm at it ;)
edit: I think I messed this one up as well when trying to increase peak detection sensitivity...
edit2: margin is fine I think, so I'll leave it like that
vinylivo:
Thanks for comitting fix, other users will be even more thankful than me because I can always use a patch otherwise.
I don't know what you mean by 'the bug is that num_rec_bytes is used in the recording screen (imho the wrong place)...' because in my thinking this variable should reflect the number of recorded bytes. And the prerecorded bytes are a part of it in the event of starting an actual recording.
I agree there could be other ways of determining file splitting, perhaps by a get_file_size function or something similar.
petur:
--- Quote from: vinylivo on March 09, 2006, 07:25:01 PM ---I don't know what you mean by 'the bug is that num_rec_bytes is used in the recording screen (imho the wrong place)...' because in my thinking this variable should reflect the number of recorded bytes.
--- End quote ---
Well, there is also a variable that holds the number of bytes written to file, and somehow I feel that variable (and location) is more suited for file splitting. Now the gui thread decides this...
Mmmm:
By jove...you know what? I think I've done it!!!..........
Although, I am very excited, and when I'm excited I say things that I regret later because I then find that I haven't done it at all!! :D
I also talk a lot of rubbish!
:D
I must now eat, then I'll look again to check whether I really have done it and do a spot of tidying up and re-naming of strange variables. Then I'll put a patch up that you can all test and tell me of any problems you find.
And Petur, I'll start the long process of compiling for all those targets ;)
Navigation
[0] Message Index
[#] Next page
[*] Previous page
Go to full version