Recording Enhancements Pack

[Mmmm]

petur, you are a H340 user ?

Shouldnt that enhacements pack work on a H300 too, after slight tweaking ? *scratches head*

Yes, I only have a H340.
The builds for H1xx and H3xx are not compatible, so that won't work...

But the patch will work for the h3xx!

[petur]

as you've probably read, I managed to break pre-recording... will try to fix it asap. Sorry!

[Mmmm]

as you've probably read, I managed to break pre-recording... will try to fix it asap. Sorry!

Heh heh.... Never mind...worse things happen at sea! 

[petur]

fixed, I think...

[whatboutbob]

Pre-recording seems to be back in working order now.

The clip meter is far more sensitive...great work Petur!

The only bugger is that the meter doesn't operate during hdd writes (as you 've mentioned previously...i figure this equates to about 10% of the time, but i imagine there's nothing that can be done about that.

Also, I'm not sure if this will make any sense, but I suspect that it only checks one 'side' of each channel for clipping....do you know if this is the case?

If you're looking at the left channel of a stereo wav for example, it seems only clipping on the top of the wav triggers the backlight, while clipping on the bottom of the wav slips through.  Not a major issue...I'm just curious.

I hope I don't sound ungrateful with all of this feedback...the hxxx is a lean, mean recording machine thanks largely to the efforts of the developers involved in this thread.  But seeing as I can't code for peanuts I see the only constructive efforts I can make towards rockbox is as a tester.  Lemme know if I'm just being annoying.

[petur]

Also, I'm not sure if this will make any sense, but I suspect that it only checks one 'side' of each channel for clipping....do you know if this is the case?

It shouldn't. The peak search loop compares the current peak value with the sample and its negative version and keeps whatever is biggest.

Got any suspicion this isn't working ok?

[vinylivo]

Hi Mmmm!

I added automatic gain control and histogram view to your enhancement pack. The patch is available at the patch tracker: http://www.rockbox.org/bugs/task/4748

[kuuan]

does this enhancement pack only work for the H100 or for the H300 series as well?

[Dick]

asked and answered 2 days ago

[kuuan]

...answered 2 days ago

sorry, had read the first 4 pages and skipped the end when I decided to ask.
I hope I understand right that Mmmm's last comment saying

But the patch will work for the h3xx!

means a 'yes' to my question.
( sorry, I am not even sure, - my limited understanding of English/technical terms. I am about to get an iH, recording is my main purpose, would prefer the H320, but would opt for the H120 instead if it's Rockboxed recording features are superior )

[petur]

The following was actually written by Mmmm:

I have changed post#1 so that it is a little more obvious which targets the patches/builds work for.

Hi Mmmm!

I added automatic gain control and histogram view to your enhancement pack. The patch is available at the patch tracker: http://www.rockbox.org/bugs/task/4748

Sounds good, although I haven't tried it yet.   

If you want it committed I think you'll have to make sure that the settings are saved, (by using settings.c) and it would make more sense if the option was in the recording menu I think, (soundmenu.c) ... Also you'll have to make sure any words for options etc are used from the language files so that a translation can be done, (english.lang).

After all that and when you know that it doesn't break any other target builds you have to be really nice to petur because he has cvs access! (I think you'll find a few beers may do the trick!  )

[Mmmm]

WOW....what happened there.... Petur it looks like I modified your post by mistake...sorry...weird...I didn't know I could do that! 


Damn....and I cant reamember what you said either!

Oh...I remember, Petur said: The h140 and h320/40 have the same audio chip, so they are capable of recording in exactly the same way. The only difference is that the h140 has an optical input (which isn't yet supported by rockbox).

Sorry about that again Petur!

[petur]

WOW....what happened there.... Petur it looks like I modified your post by mistake...sorry...weird...I didn't know I could do that! 

Maybe they made you mod without telling you Do you have the modify button next to all posts?

Nice tip about buying beer for me I should make a note that I'm from Belgium so my standards are pretty high

[toolmanwill]

heh, you definitely dont want the crap american domestic we got here.   :'(
Altho i'm 5 minutes from canada and they brew some good beer!

[Mmmm]

WOW....what happened there.... Petur it looks like I modified your post by mistake...sorry...weird...I didn't know I could do that! 

Maybe they made you mod without telling you Do you have the modify button next to all posts?

Yep I could get up to all kinds of mischief couldn't I?

Ahh..I see, Its only on threads that I have started!

Nice tip about buying beer for me I should make a note that I'm from Belgium so my standards are pretty high

Heh heh...I wish I had cvs access so I could get free beer too!