Rockbox.org home
Downloads
Release release
Dev builds dev builds
Extras extras
themes themes
Documentation
Manual manual
Wiki wiki
Device Status device status
Support
Forums forums
Mailing lists mailing lists
IRC IRC
Development
Bugs bugs
Patches patches
Dev Guide dev guide
Search



Donate

Rockbox Technical Forums


Login with username, password and session length
Home Help Search Staff List Login Register
News:

Welcome to the Rockbox Technical Forums!

+  Rockbox Technical Forums
|-+  Support and General Use
| |-+  Theming and Appearance Customization
| | |-+  WARNING: skin format changing on the weekend!
« previous next »
  • Print
Pages: 1 2 3 [4] 5

Author Topic: WARNING: skin format changing on the weekend!  (Read 24691 times)

Offline bobbydriver

  • Member
  • *
  • Posts: 32
Re: WARNING: skin format changing on the weekend!
« Reply #45 on: June 16, 2010, 10:01:07 AM »
Sorry I misread that the skinbreaking changes were from 3.6 - but I see that it's a post 3.6 change that brought them in.

I've installed back to 3.6 stable build and it works fine again.

I had a go at hand editing my custom theme files according to the new guidelines but it still doesn't work so I've clearly missed something

Still wondering what the point of changing the code to break all custom skins was, so unless someone can point me in the direction of an automated tool to port old skins then my Rockbox will remain at 3.6 forever and my love affair with Rockbox is over as I just don't understand why the developers would do something so vandalistic
Logged

Offline funman

  • Developer
  • Member
  • *
  • Posts: 645
Re: WARNING: skin format changing on the weekend!
« Reply #46 on: June 16, 2010, 12:32:04 PM »
Here is the automated tool.

You are egoist when thinking the intention was to break custom skins only.
The intention was to break all skins, including the default rockbox ones.
Logged
a wise man said: "a wise man said"

Offline mc2739

  • Developer
  • Member
  • *
  • Posts: 262
Re: WARNING: skin format changing on the weekend!
« Reply #47 on: June 16, 2010, 03:11:28 PM »
Quote from: bobbydriver on June 16, 2010, 10:01:07 AM
Still wondering what the point of changing the code to break all custom skins was...

Sometimes, to move forward with new ideas or features, there comes a point where it is best to ditch the old and embrace the new, for example, analog vs. digital/HD TV.  This is one of those cases.

The developers involved with the change made every effort to make this as painless as possible.  The change was announced well ahead of when it happened.  It was timed to happen after a new release so that those people that use the release versions would not be immediately impacted.  The changes in syntax were documented prior to the change so that the theme developers could get an idea of what was coming.  A conversion tool was created to convert existing themes on the theme site to the new syntax.  The existing theme site was duplicated so that users could still get working themes for releases or daily builds prior to the change.

Quote
...my Rockbox will remain at 3.6 forever and my love affair with Rockbox is over...

While it is your prerogative to do so, you will be missing out on any bug fixes, code improvements and new features that may come along in the future.

The tool funman linked does a very good job of converting the themes from the old syntax to the new syntax, but you need to have a build environment set up in order to compile the code into an executable program.  If that is not an option for you, then ask here in the forum or in the #rockbox irc channel for help.  There are usually plenty of people willing to help, if you are willing to ask for the help.
Logged

Offline epithetless

  • Member
  • *
  • Posts: 195
    • Dour Times
Re: WARNING: skin format changing on the weekend!
« Reply #48 on: June 16, 2010, 07:43:02 PM »
Quote from: mc2739 on June 16, 2010, 03:11:28 PM
The tool funman linked does a very good job of converting the themes from the old syntax to the new syntax, but you need to have a build environment set up in order to compile the code into an executable program.  If that is not an option for you, then ask here in the forum or in the #rockbox irc channel for help.

In that case, would someone with a build environment already set up mind compiling and sharing an executable for Windows? ;)
Logged
Rockboxed: Apple iPod 3G â€¢ Apple iPod nano 2G • iriver H120 • Sansa c250 v1 • Sansa Clip v1 • Sansa Clip v2 • Sansa Clip+ • Sansa e280 v1 • Sansa e280v2 • Sansa Fuze v1  |  non-Rockboxed: HTC Incredible [Android 2.2] • Sansa Fuze v2

Offline JdGordon

  • Member
  • *
  • Posts: 1817
  • Constantly breaking stuff
Re: WARNING: skin format changing on the weekend!
« Reply #49 on: June 16, 2010, 10:24:49 PM »
Quote from: bobbydriver on June 16, 2010, 10:01:07 AM
Still wondering what the point of changing the code to break all custom skins was, so unless someone can point me in the direction of an automated tool to port old skins then my Rockbox will remain at 3.6 forever and my love affair with Rockbox is over as I just don't understand why the developers would do something so vandalistic

DAMN! I almost had everyone convinced it was to make things better, but you saw right through that! BUGGER, oh well, I still got to have my fun.
Logged


Using PMs to annoy devs about bugs/patches is not a good way to have the issue looked at.

Offline bobbydriver

  • Member
  • *
  • Posts: 32
Re: WARNING: skin format changing on the weekend!
« Reply #50 on: June 17, 2010, 05:23:14 AM »
Thanks for the link to the c script - can you recommend a windows C compiler that will create an executable from it?

I downloaded lcc-win32 but it won't compile - throws lots of errors.

bear in mind it's been 20 years since I last compiled any C code...


EDIT

Don't worry - I'd not added the other two files into the project - I now have a compiled exe file. Will report back if it works


SECOND EDIT

It seemed like it ran OK but the new wps and sbs files are just full of this?!

Quote
ÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZ
ZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZ
ZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZ
ZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZ
ZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZ
ZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZ
ZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZ
ZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZ
ZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZ
ZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZ
ZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZ
ZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZ
ZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZ
ZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZ
ZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZ
ZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZ
ZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZZúÿZ

Did I do something obviously wrong?

« Last Edit: June 17, 2010, 05:35:43 AM by bobbydriver »
Logged

Offline bluebrother

  • Developer
  • Member
  • *
  • Posts: 3421
  • creature
Re: WARNING: skin format changing on the weekend!
« Reply #51 on: June 17, 2010, 06:45:06 AM »
Quote from: bobbydriver on June 17, 2010, 05:23:14 AM
Thanks for the link to the c script - can you recommend a windows C compiler that will create an executable from it?

C is not a scripting language.

Quote
I downloaded lcc-win32 but it won't compile - throws lots of errors.

Use gcc.
Logged
Rockbox Utility development binaries (updated infrequently) · How to ask questions the smart way · We do not estimate timeframes.

Offline bobbydriver

  • Member
  • *
  • Posts: 32
Re: WARNING: skin format changing on the weekend!
« Reply #52 on: June 17, 2010, 06:56:44 AM »
OK - I can't make any sense of the GCC stuff

I'm not a developer, so unless anyone knows why the skinupdater executable I compiled is filling the "new" wps files with ÿZZúÿZZú then my rather straight forward question is this:

How does a non-technical person (ie someone who is not in a position to start setting up C dev environments) who has a custom skin easily convert his custom skin to run with the new versions of Rockbox?

Logged

Offline mc2739

  • Developer
  • Member
  • *
  • Posts: 262
Re: WARNING: skin format changing on the weekend!
« Reply #53 on: June 17, 2010, 10:54:08 AM »
Quote from: epithetless on June 16, 2010, 07:43:02 PM
In that case, would someone with a build environment already set up mind compiling and sharing an executable for Windows? ;)

Here you go: skinupdater executable and source (r26887)

The syntax is: skinupdater wps_name.wps wps_new_name.wps

Each of your .wps, .sbs and .fms files need to be updated.
Logged

Offline bobbydriver

  • Member
  • *
  • Posts: 32
Re: WARNING: skin format changing on the weekend!
« Reply #54 on: June 17, 2010, 11:36:05 AM »
Many thanks for this MC2739

That works a treat in so far as it outputs the sbs and wps files in the new format

Doing a file diff on the skinupdated files and the ones that I manually updated according to the new spec showed up a couple of lines that I missed, so I was hopeful that this was the answer

However - when I load the new theme it still doesn't work (just displays the standard rockbox non-cover art mono theme instead)

Hmm- what can be wrong with my theme?

EDIT
Sorted it - I had renamed everything in the theme as v2 but not created a v2 sub-directory with the images in the WPS directory

d'oh! as they say

Many thanks to everyone who helped me out
« Last Edit: June 17, 2010, 11:51:40 AM by bobbydriver »
Logged

Offline MajiKool Dragonâ„¢

  • Member
  • *
  • Posts: 147
  • I'm me!
Re: WARNING: skin format changing on the weekend!
« Reply #55 on: June 17, 2010, 09:48:37 PM »
i noticed in converting my theme that %C has changed to %Cd.
Logged
"Isn't it funny how even the coldest weather isn't so cold when you've got people who care about you to walk through it with you." - MajiKool Dragonâ„¢
SanDisk Sansa c240v1 + 16GB µSDHC, Apple iPhone 4 iOS4.2.1 Jailbroken

Offline AsusFreak

  • Member
  • *
  • Posts: 64
Re: WARNING: skin format changing on the weekend!
« Reply #56 on: June 18, 2010, 03:58:12 AM »
Quote from: MajiKool Dragonâ„¢ on June 17, 2010, 09:48:37 PM
i noticed in converting my theme that %C has changed to %Cd.


Take a look at this:
http://www.rockbox.org/wiki/SkinBreakingChange
Logged

Offline lazybum

  • Member
  • *
  • Posts: 9
Re: WARNING: skin format changing on the weekend!
« Reply #57 on: June 24, 2010, 09:28:30 AM »
Quote from: mc2739 on June 17, 2010, 10:54:08 AM
Quote from: epithetless on June 16, 2010, 07:43:02 PM
In that case, would someone with a build environment already set up mind compiling and sharing an executable for Windows? ;)

Here you go: skinupdater executable and source (r26887)

The syntax is: skinupdater wps_name.wps wps_new_name.wps

Each of your .wps, .sbs and .fms files need to be updated.

Hi if i want to use an old wps i just have to convert it using that tool right?
But it doesn't seem to be working 0.0. Ive renamed the images folder. Heres what the new wps looks like. Anyone knows what is the problem with it?
Quote
%wd
# Progress bar etc.
%V(0,1,-,8,1)%Vf(
%%pb)%Vb(pb.bmp)0%|0%|128%|6%|
%x(a,pbbackground.bmp,0,0)
%V(0,8,-,-,1)%Vf(
%%al%%pc%%ac%%?mp%<Stopped)%Vb(Playing)Paused%|FF%|Rewind>%ar%pt

# Track info
%V(0,17,-,-,1)%Vf(
%%s%%ac%%?it%<%%it)%Vb(Unknown Track%>
%%V)0|27|-|-|1|
%s%ac%?id<%id%|Unknown Album> %?iy<%(%iy%)%|>
%V(0,37,-,-,1)%Vf(
%%s%%ac%%?ia%<%%ia)%Vb(Unknown Artist%>

%# Playlist and codec info
%%V)0|47|-|-|1|
%alPL:%pp/%pe%?ps< %(S%)%|>%?mm<%| %(R%)%| %(R1%)%| %(R%)%| %(R%)> %arC:%fc %fb

# Battery and Volume
%V(0,56,-,-,1)%Vf(
%%alB:%%bl%%%% %%acV:%%pvdB%%arRG:%%?rg%<Off)%Vb(Track)Album|TShuffle|AShuffle|No tag>
Its for the clip+ btw, if it matters
Logged

Offline JdGordon

  • Member
  • *
  • Posts: 1817
  • Constantly breaking stuff
Re: WARNING: skin format changing on the weekend!
« Reply #58 on: June 24, 2010, 09:53:52 AM »
run it again with the -m option... the clip is technically a mono display
Logged


Using PMs to annoy devs about bugs/patches is not a good way to have the issue looked at.

Offline lazybum

  • Member
  • *
  • Posts: 9
Re: WARNING: skin format changing on the weekend!
« Reply #59 on: June 24, 2010, 10:40:02 AM »
Sorry but may i know how do you do that?

EDIT: ok nvm got it. Thanks for the help! And for the tool! :)
« Last Edit: June 24, 2010, 10:46:59 AM by lazybum »
Logged

  • Print
Pages: 1 2 3 [4] 5
« previous next »
+  Rockbox Technical Forums
|-+  Support and General Use
| |-+  Theming and Appearance Customization
| | |-+  WARNING: skin format changing on the weekend!
 

  • SMF 2.0.17 | SMF © 2019, Simple Machines
  • Rockbox Privacy Policy
  • XHTML
  • RSS
  • WAP2

Page created in 0.122 seconds with 14 queries.