Support and General Use > Theming and Appearance Customization
WARNING: skin format changing on the weekend!
atsakir:
Should we post 2 different versions of our themes to the themes site to support both 3.5.1 and svn builds that used the old syntax and current builds with the new syntax until the 3.6 release is out?
csavery:
These skin files aren't very big. Why not just add a conditional tag into the format that allows loading either a new or old section according to loader version? Similar to an #ifdef directive. Then the converter could convert all skins in place and they would work for any version. This would make changes to the web site minimal and no need to manage duplicate skins.
Or maybe it's too late for this...
(To clarify - it could just be a comment line that the reader uses as a trigger for what to ignore in the file. eg. Older loaders ignore after #version X, new loaders ignore before #version X)
JdGordon:
because the rockbox build can only load one format, leaving the parser for the old format would add a massive amount of dead code which we don't want.
The current scheme is going to be a copy of the current theme site for some time until rbutil and the themesite work nicely together to ask for thmes which worked before some revision.
Plan is still to do the changeover today.. waiting for the themesite to happen
csavery:
There wouldn't be a need to leave the old parser in the code. The new parser would simply ignore code it doesn't read. Eventually the .wps files could all be trimmed to drop the old format codes.
Anyway, I guess there's no point in me commenting on this as it's already in progress. It just seems a little more planning into the new format could have aided a simpler transition with no sites changes or skin author interventions.
JdGordon:
maybe I misunderstood...
Oh you want both formats in the one file? na that would be crazy :p
Navigation
[0] Message Index
[#] Next page
[*] Previous page
Go to full version