WARNING: skin format changing on the weekend!

[JdGordon]

the change has now been commited so its a moot point.
The plan is to use the themesite to control theme versioning through rbutil

[atsakir]

Upwards which revision is the theme break commited in? The simulator for r26611 (6/6/2010) stiil uses the old syntax as I can see.

[perrikwp]

As far as I can see, r26641 is the skin breaking change.

[wintermute23]

OK, So I used the sims (r26651) to convert and test my themes, and they seemed to work fine. Uploaded them to the theme site, and downloaded the latest build for my player (r26660), and installed the updated version of the themes, and they completely fail.
For example:

Code: [Select]

#Theme:     Fold
#Author:    Ross Thompson
#           wintermute115@gmail.com
#Version:   2.0
#Licence:   CC-SA-BY 3.0
#Created:   2010-06-07
#Target:    iPod Photo
#           320x240x24

#Statusbar icons
%xl(a,batt_strip.bmp,296,0,18)
%xl(c,batt_charge_strip.bmp,296,0,18)
%xl(d,hd_light.bmp,254,-1,2)
%xl(h,Hold.bmp,276,2,2)

#Turn off standard statusbar
%wd

#Statusbar
%V(2,1,316,15,1) %Vf(FFFFFF) %Vb(000000)
#Text
%?cf<%cH:%cM:%cS|%cl:%cM%cP>%ac%?mh<Battery: %bl%% (%?bc<Charging|%?bp<On Mains|%bt>>)|%?cu<Monday|Tuesday|Wednesday|Thursday|Friday|Saturday|Sunday> %cd %?cm<January|February|March|April|May|June|July|August|September|October|November|December> %cY>
#Hard drive indicator
%?lh<%xd(db)|%xd(da)>
#Hold switch
%?mh<%xd(ha)|%xd(hb)>
#Battery
%?bp<%?bl<%xd(ca)|%xd(ca)|%xd(cb)|%xd(cc)|%xd(cd)|%xd(ce)|%xd(cf)|%xd(cg)|%xd(ch)|%xd(ci)|%xd(cj)|%xd(ck)|%xd(cl)|%xd(cm)|%xd(cn)|%xd(co)|%xd(cp)|%xd(cq)|%xd(cr)>|%?bl<%xd(aa)|%xd(aa)|%xd(ab)|%xd(ac)|%xd(ad)|%xd(ae)|%xd(af)|%xd(ag)|%xd(ah)|%xd(ai)|%xd(aj)|%xd(ak)|%xd(al)|%xd(am)|%xd(an)|%xd(ao)|%xd(ap)|%xd(aq)|%xd(ar)>>

#Main Viewport
%Vi(z,0,17,320,189,1) %Vf(FFFFFF) %Vb(00007E)
%VI(z)

#Song data on main screen; Next data on WPS
%V(2,216,316,15,1) %Vf(FFFFFF) %Vb(00007E)
%s%?it<%ia - %it|%?fn<%fn|No current track>>

#Playlist data
%V(2,232,316,-,0) %Vf(FFFFFF) %Vb(00007E)
%s%?fm<%al%pc/%pt %ar%?pn<%pn|%d(1)> %?pp<(%pp of %pe)|>|>

This looks like this on the sim:

But on my player, only the icons in the top bar, and the text in the main viewport are visible. No text in the topbar, or the footer is appearing. In each case, the text and background colors are the same as defined in the CFG.

It looked like r26657 (which changed how %Vf/%Vb) are handled might be the problem, but getting rid of the spacing just made it the SBS fail completely.

For the WPS,

Code: [Select]

#Theme:     Fold
#Author:    Ross Thompson
#           wintermute115@gmail.com
#Version:   2.0
#Licence:   CC-SA-BY 3.0
#Created:   2010-06-07
#Target:    iPod Photo
#           320x240x24
#Album Art: 120x120

#Load images
%Cl(20,45,120,120)
%X(background.bmp)
%xl(r,repeat_strip.bmp,0,7,4)
%xl(s,status_strip.bmp,0,0,4)
%xl(v,vol_strip.bmp,0,3,21)
%xl(S,shuffle.bmp,0,0)
%xl(R,rating_strip.bmp,0,0,10)

#Statusbar icons
%xl(a,batt_strip.bmp,296,0,18)
%xl(c,batt_charge_strip.bmp,296,0,18)
%xl(d,hd_light.bmp,254,-1,2)
%xl(h,Hold.bmp,276,2,2)

#Load font
%Fl(2,helvB14.fnt)

#Turn off standard statusbar
%wd

#Progressbar
%pb(progressbar.bmp,0,182,320,5)

#Load in viewports, based on album art
%?C<%C%Vd(a)|%Vd(b)>

#Statusbar
%V(2,1,316,15,1) %Vf(FFFFFF) %VB(000000)
#Text
%?cf<%cH:%cM:%cS|%cl:%cM%cP>%ac%?mh<Battery: %bl%% (%?bc<Charging|%?bp<On Mains|%bt>>)|%?cu<Monday|Tuesday|Wednesday|Thursday|Friday|Saturday|Sunday> %cd %?cm<January|February|March|April|May|June|July|August|September|October|November|December> %cY>
#Hard drive indicator
%?lh<%xd(db)|%xd(da)>
#Hold switch
%?mh<%xd(ha)|%xd(hb)>
#Battery
%?bp<%?bl<%xd(ca)|%xd(ca)|%xd(cb)|%xd(cc)|%xd(cd)|%xd(ce)|%xd(cf)|%xd(cg)|%xd(ch)|%xd(ci)|%xd(cj)|%xd(ck)|%xd(cl)|%xd(cm)|%xd(cn)|%xd(co)|%xd(cp)|%xd(cq)|%xd(cr)>|%?bl<%xd(aa)|%xd(aa)|%xd(ab)|%xd(ac)|%xd(ad)|%xd(ae)|%xd(af)|%xd(ag)|%xd(ah)|%xd(ai)|%xd(aj)|%xd(ak)|%xd(al)|%xd(am)|%xd(an)|%xd(ao)|%xd(ap)|%xd(aq)|%xd(ar)>>

#Track name - 14pt bold
%V(10,22,300,17,2) %Vf(FFFFFF) %Vb(00007E)
%s%ac%?it<%it|%fm>

####Artist and album
# With Album Art
%Vl(a,160,60,150,30,1) %Vf(FFFFFF) %Vb(00007E)
%s%ac%?ia<%ia|%?d(2)<%d(2)|Artist Unknown>>
%s%ac%?id<%id|%?d(1)<%d(1)|Album Unknown>>
# Without Album Art
%Vl(b,10,60,300,30,1) %Vf(FFFFFF) %Vb(00007E)
%s%ac%?ia<%ia|%?d(2)<%d(2)|Artist Unknown>>
%s%ac%?id<%id|%?d(1)<%d(1)|Album Unknown>>

####Technical
# With Album Art
%Vl(a,160,100,150,30,0) %Vf(C8BFB5) %Vb(00007E)
%s%ac%?ig<%ig|No genre>%?iy< (%iy)|>
%s%ac%fc - %fb kbps%?fv< VBR|>
%s%ac%fs Kb
# Without Album Art
%Vl(b,10,100,300,30,0) %Vf(C8BFB5) %Vb(00007E)
%s%ac%?ig<%ig|No genre>%?iy< (%iy)|>
%s%ac%fc - %fb kbps%?fv< VBR|>
%s%ac%fs Kb

####Rating
# With Album Art
%Vl(a,160,140,150,20,0) %Vf(FFFFFF) %Vb(00007E)
%?rr<|%xd(Ra)|%xd(Rb)|%xd(Rc)|%xd(Rd)|%xd(Re)|%xd(Rf)|%xd(Rg)|%xd(Rh)|%xd(Ri)|%xd(Rj)>
# Without Album Art
%Vl(b,85,140,150,20,0) %Vf(FFFFFF) %Vb(00007E)
%?rr<|%xd(Ra)|%xd(Rb)|%xd(Rc)|%xd(Rd)|%xd(Re)|%xd(Rf)|%xd(Rg)|%xd(Rh)|%xd(Ri)|%xd(Rj)>

#Track times
%V(10,172,300,8,0) %Vf(FFFFFF) %Vb(00007E)
%ac%px%%
%V(10,190,300,8,0) %Vf(FFFFFF) %Vb(00007E)
%al%pc%ac-%pr%ar%pt

#Volume - First line left intentionally blank
%V(247,199,63,16,0) %Vf(FFFFFF) %Vb(00007E)

%?pv<%xd(va)|%xd(vb)|%xd(vc)|%xd(vd)|%xd(ve)|%xd(vf)|%xd(vg)|%xd(vh)|%xd(vi)|%xd(vj)|%xd(vk)|%xd(vl)|%xd(vm)|%xd(vn)|%xd(vo)|%xd(vp)|%xd(vq)|%xd(vr)|%xd(vs)|%xd(vt)|%xd(vu)>%ar%pv dB

#Shuffle / repeat
%V(128,202,25,14,0) %Vf(FFFFFF) %Vb(00007E)
%?ps<%xd(S)|>
%?mm<|%xd(ra)|%xd(rb)|%xd(rc)|%xd(rd)>

#Status icon
%V(154,200,15,15,0) %Vf(FFFFFF) %Vb(00007E)
%?mp<|%xd(sa)|%xd(sb)|%xd(sc)|%xd(sd)>

#Song data on main screen; Next data on WPS
%V(2,216,316,15,1) %Vf(FFFFFF) %Vb(00007E)
%s%?It<%Ia - %It|%?Fn<%Fn|Finding next track...>>

#Playlist data
%V(2,232,316,-,0) %Vf(FFFFFF) %Vb(00007E)
%s%ar%?pn<%pn |%d(1) >%?pp<(%pp of %pe)|>

Looks like this in the sim:

but on my player, it fails without explanation.

Can anyone tell me what I'm doing wrong, and how to fix it? Thanks.

EDIT:

I figured out that was going wrong! The new line at the end of the %V line was forcing the text down a line, so it was disappearing off the bottom of the viewport. Putting the text on the same line as the %V directive fixed it.

I suspect this is a bug?

[bluebrother]

OK, So I used the sims (r26651) to convert and test my themes, and they seemed to work fine. Uploaded them to the theme site, and downloaded the latest build for my player (r26660), and installed the updated version of the themes, and they completely fail.

The theme site currently doesn't handle the new format. Please refrain from using it and especially from uploading themes until that's fixed.

[wintermute23]

Noted. But the theme site <i>seems</i> to handle the new format fine, reporting "Works with current build".

Perhaps a note should be placed on the theme site explaining this?

[TexasRockbox]

And also an indication that the theme works (or doesn't) with Version 3.6.

About 20 iPod Video/D2 themes are missing.

[Domonoky]

I just update the themesite so it knows the 3.6 release.
There is now also a copy of the themesite available which will hold the not-converted themes for older builds.

The main themesite will get its themes converted to the new format somewhere in the near future.. 

[Domonoky]

I have now run the conversion on the themesite.
If there are themes missing/ not-converted/ broken, please report here.

[AsusFreak]

Hi Domonoky,

I just sent you a PM, too:

I just converted my theme AF_Black yesterday, just to be compatible with the SkinBreak and today I changed it again to correct the changed album art tag %Cd. SoI miss my Version V8.1 of AF_Black.
Could you please check this?
Thanks.
AsusFreak

[Domonoky]

AF_Black is misssing because it was already converted to the newer format. And the skinupdater didnt work correctly on that.
You can either upload it again, or i could restore version 7 because that converted finely :-)

[AsusFreak]

Thanks for this proposal - then I try to reup it tomorrow.
Thanks for this quick reply.

[epithetless]

Is there a ready-made tool (for Windows, in my case) available -- or planned to be available -- which facilitates the conversion of previously-working themes to the new syntax, or is maintaining compatibility with current builds a matter of making manual adjustments to all of our text files?

(I was hoping the converted themesite would properly update my previously-uploaded themes and give me a good place to start from with other themes I've been working on, but CheckWPS for the updated themesite evidently encountered an "invalid parameter list for token x" in all of those themes (XL Fuzed, Clipline, and ReMediaFlo), so it kept them all in a 3.6-compatible state without making any changes to them. )

[JdGordon]

in the svn sources under utils/skinupdater there is a program to convert old skins. it needs a c compiler so if you have one setup you shold easily be able to make that.

[JdGordon]

Domonoky, I'm looking at random themes that are still faililng and it looks like they wern't update at all? (or run through the update .pl file).. did the search miss some maybe?