"Fade on stop/pause" duration control (was: Plug-in for audio fade?)

[chrisjj]

> "Might do" is different from "will do" though.

Agreed

> If you added a duration option to fade on stop/pause, what else would be missing?

Normal (immediate) "Play" - I just discovered that "Fade on stop/pause" actually does Fade on stop/pause & play, whereas I need Play to remain immediate.

> You've been told that no plugin exists currently to do what you want

So I have - apologies.

> you've been told how you could accomplish similar effect

Crossfade? The snag with that is it is not on-command - once enabled, it applies to all track switches.

> and that you'd otherwise have to edit the source code.

I'll come back to that possibility when I've learned more. Thanks!

[soap]

> you've been told how you could accomplish similar effect

Crossfade? The snag with that is it is not on-command - once enabled, it applies to all track switches.

Noticing the emphasis on "on-command" I need to clarify one question:
Are you saying you want fade-to-pause/stop assigned to a button independent of the normal pause/stop button so that you can fade with one button and not fade with another?

[chrisjj]

> Noticing the emphasis on "on-command" I need to clarify one question:
> Are you saying you want fade-to-pause/stop assigned to a button
> independent of the normal pause/stop button so that you can
> fade with one button and not fade with another?

No I'm not saying that. But for the fact fade-to-pause/stop mode affects Play, then I'd need only the fade period lengthened for my requirements to be fully met by just the normal pause/stop button.

[soap]

So, just to be sure I'm clear, a setting that when enabled turns the normal "abrupt" stop/pause into a gentle fade out stop/pause?  But no fade in.

Correct?

[chrisjj]

> So, just to be sure I'm clear, a setting that when enabled turns the
> normal "abrupt" stop/pause into a gentle fade out stop/pause?  But no fade in.

Yes, except there's no requirement for this to be on a setting -  I'd be happy with this being a build option.

[soap]

Rockbox does not tend to do build-time options.  (Though one could obviously tweak the code in such a manner.)

What it sounds like an agreeable option for you would be is to expand on the previously discussed "Fade on stop / pause" option.  An expansion which expanded the length of fade and added an option to Fade on stop / pause, play, or both .

Does this sound like the idea in a nutshell?  (Not saying it will get done, but at least we can clearly define the goal)?

[chrisjj]

> What it sounds like an agreeable option for you would be is to expand on the previously discussed "Fade on stop /
> pause" option.  An expansion which expanded the length of fade and added an option to Fade on stop / pause, play, or both .
>
> Does this sound like the idea in a nutshell?

That would certainly meet my requirements.

But perhaps the following would simpler and meet more of the requirements of others:

Setting for duration of "Fade on stop/pause" up
Setting for duration of "Fade on stop/pause" down.

And perhaps the same time would be a good time to improve both the UI label "Fade on stop/pause" and the CGF label "volume fade", changing to "Fade on stop/pause/play."

> (Not saying it will get done, but at least we can clearly define the goal)?

Sure!

[soap]

Ok, I don't feel the meta discussion on quoting is needed, nor appropriate, in this thread and I'm going to shit-can it.

Quote abuse (or lack of quoting) is such a rare event that I also don't feel it needs stickied, and suggest that staff PM "offenders" in the future and not clutter an otherwise functional thread.

Two posts on the quoting topic is sufficient.  Eight is outright silly.

Edit:  PM me if you have good reason to see this thread unlocked.  I personally feel the original topic has reached a conclusion / agreement.

[chrisjj]

I want a command (e.g. single keypress) that when issued triggers RB to do a fade to silence. I.e. to take the volume of the audio steadily down to zero.

It seems Crossfade on manual would do this for me https://archive.is/KEfsp#selection-515.0-520.0 . However crossfade seems brokens at the moment http://forums.rockbox.org/index.php/topic,51605.0.html .

[Bilgus]

And A lua x-mas present for you as well 

Code: [Select]

--Bilgus 12-2016
TIMEOUT = rb.HZ/4
SOUND_VOLUME = 0 --This is a CONSTANT
local vol_min = -60 --rb.sound_min(SOUND_VOLUME)

function cfg_num_setting(str_name)
local file = io.open(rb.ROCKBOX_DIR .. "/config.cfg", "r")
    if not file then
        return nil
    end
local value = nil
local contents = file:read("*all")

    i, j = string.find(contents, str_name .. ":")
    if j ~= nil then
        file:seek ("set", rb.atoi(j))
        value = file:read ("*num")
    end
    file:close() -- GC takes care of this if you would've forgotten it
    return value
end

local volume = cfg_num_setting("volume")
    if volume == nil then
        volume = rb.sound_default(SOUND_VOLUME)
    end

local vol_orig = volume


    if rb.pcm_is_playing() then
        while (volume > vol_min) do
            rb.sleep(TIMEOUT)
            rb.yield()
            volume = volume - 1
            rb.sound_set(SOUND_VOLUME, volume);
        end
        rb.audio_pause()
        rb.sleep(rb.HZ)
        rb.sound_set(SOUND_VOLUME, vol_orig); -- Set back to original so it doesn't get overwritten in config.cfg
        os.exit()

    else
        volume = vol_min
        rb.sound_set(SOUND_VOLUME, volume);
        rb.sleep(rb.HZ)
        rb.audio_resume()
        while (volume < vol_orig) do
            rb.sleep(TIMEOUT)
            rb.yield()
            volume = volume + 1
            rb.sound_set(SOUND_VOLUME, volume);
        end
        rb.sound_set(SOUND_VOLUME, vol_orig);

        os.exit()
    end


[chrisjj]

Thanks. On the ZEN simulator, that Lua script gives me this error in the GUI http://i.imgur.com/EGgZmmJ.png and the console:

Code: [Select]

/Bilgus_Keyfade.lua:31: attempt to call field 'pcm_is_playing' (a nil value)
stack traceback:
        /Bilgus_Keyfade.lua:31: in main chunk

[Bilgus]

just tried downloading the file and installed on the zen sim it worked fine, make sure it has 'if rb.pcm_is_playing() then'
if you are in doubt take a screen shot of the file open on your pc

[chrisjj]

just tried downloading the file and installed on the zen sim it worked fine,

Coo. I get the fail even on the default config.

make sure it has 'if rb.pcm_is_playing() then' if you are in doubt take a screen shot of the file open on your pc

No doubt, but here it is anyway: http://i.imgur.com/VHEEbcB.png

[Bilgus]

weird  maybe you don't have that function available???, What version is the rom on the sim you are using?
 try replacing   'if rb.pcm_is_playing() then'
with

Code: [Select]

AUDIO_STATUS_PLAY = 1
    if rb.audio_status() == AUDIO_STATUS_PLAY then


[Bilgus]

I'm working on a configurable fade to stop fade to play plugin now..