Cannot Upload Theme

[jtrodriguez]

I am getting this message when I try to upload...

-backlight on button hold is not a allowed theme setting

This is the setting I have.. It is set so that people can read the information that is shown when hold is toggled.
backlight on button hold: normal


It also blocked me from setting the time format but I removed that... why does it prevent themes being uploaded that use some settings 

[Llorean]

Because those settings are not considered part of a "theme."

If a user wants it enabled or not, it is up to them - the theme should only change a certain pre-known selection of settings rather than being able to randomly change any setting a user might have.

[jtrodriguez]

Because those settings are not considered part of a "theme."

If a user wants it enabled or not, it is up to them - the theme should only change a certain pre-known selection of settings rather than being able to randomly change any setting a user might have.

 
It should check for and allow "backlight on button hold: normal" and prevent on/off because having the backlight setting is useful for themes that have info on hold

[Yotto]

I have my backlight set the way I want it. I would hate to have to go through and reset a bunch of settings whenever I load a theme.

If users can't see your theme with hold on, AND they want to, they'll change the setting themselves.

[Llorean]

"Backlight on hold" is not considered a theme setting. That's just the way it is. It is extremely unlikely that this will change.

[jtrodriguez]

I have my backlight set the way I want it. I would hate to have to go through and reset a bunch of settings whenever I load a theme.

If users can't see your theme with hold on, AND they want to, they'll change the setting themselves.

With the new installer that is extremely easy to use I am sure that there are some users who wouldn't know how to set it, don't want to bother trying to set it and/or don't even know that it exists.

I just made it a comment in the files and mentioned it in the description so hopefully that is enough :\