Rockbox.org home
Downloads
Release release
Dev builds dev builds
Extras extras
themes themes
Documentation
Manual manual
Wiki wiki
Device Status device status
Support
Forums forums
Mailing lists mailing lists
IRC IRC
Development
Bugs bugs
Patches patches
Dev Guide dev guide
Search



Donate

Rockbox Technical Forums


Login with username, password and session length
Home Help Search Staff List Login Register
News:

Rockbox Ports are now being developed for various digital audio players!

+  Rockbox Technical Forums
|-+  Support and General Use
| |-+  Plugins/Viewers
| | |-+  RTL with the text editor? possible?
« previous next »
  • Print
Pages: [1]

Author Topic: RTL with the text editor? possible?  (Read 4234 times)

Offline Agent12

  • Member
  • *
  • Posts: 4
RTL with the text editor? possible?
« on: March 28, 2010, 03:05:15 PM »
wondering if its possible to use the text editor from right to left [HEBREW]
?

 8) 8)
tnx
Logged

Offline tomers

  • Developer
  • Member
  • *
  • Posts: 76
Re: RTL with the text editor? possible?
« Reply #1 on: March 30, 2010, 04:17:05 PM »
I've implemented this feature in r25400. You can download it from the current build link available from the homepage.

Currently diacritics are not supported well on the viewer. I hope that either me and/or Amr Medhat will implement it soon. Similar work is done in the 'View Arabic text (cont.) - About the diacritics patch' forum thread.

Please test and report your findings here. If there are any issues on the matter, please also report it in a new Flyspray bug item.

Regards,
Tomer
Logged

Offline Agent12

  • Member
  • *
  • Posts: 4
Re: RTL with the text editor? possible?
« Reply #2 on: March 30, 2010, 06:09:16 PM »
Quote from: tomers on March 30, 2010, 04:17:05 PM
I've implemented this feature in r25400. You can download it from the current build link available from the homepage.

Currently diacritics are not supported well on the viewer. I hope that either me and/or Amr Medhat will implement it soon. Similar work is done in the 'View Arabic text (cont.) - About the diacritics patch' forum thread.

Please test and report your findings here. If there are any issues on the matter, please also report it in a new Flyspray bug item.

Regards,
Tomer

updated to the new build few minutes ago.
Here's the result: It did change the aligment from LTR to RTL yet the text direction is from the left. I mean that the dot or comma which supposed to be at the end of the line, at the left, are still at the left.

LINK TO AN EXAMPLE IN HEBREW FOR HOW IT LOOKS:
http://img340.imageshack.us/img340/5576/jpeggb.jpg

Logged

Offline amr

  • Member
  • *
  • Posts: 15
Re: RTL with the text editor? possible?
« Reply #3 on: March 30, 2010, 11:28:13 PM »
Is there a character map for non-Latin languages in the text editor?
Logged

Offline yapper

  • Rockbox Expert
  • Member
  • *
  • Posts: 794
Re: RTL with the text editor? possible?
« Reply #4 on: March 30, 2010, 11:40:31 PM »
Is this what you are looking for:
http://www.rockbox.org/wiki/LoadableKeyboardLayouts
Logged
G2 iPod 20GB / Sansa c240 v1 + 2GB microSD / Sansa c250 v1 / Sansa e250 v1 + 8GB microSDHC / Sansa Fuze v2 + 32GB microSDHC

Offline tomers

  • Developer
  • Member
  • *
  • Posts: 76
Re: RTL with the text editor? possible?
« Reply #5 on: April 01, 2010, 07:46:22 AM »
Quote from: Agent12 on March 30, 2010, 06:09:16 PM
Here's the result: It did change the aligment from LTR to RTL yet the text direction is from the left. I mean that the dot or comma which supposed to be at the end of the line, at the left, are still at the left.

This seems like a more complicated problems, as Rockbox doesn't support that functionality yet.
Unfortunately, I am not plan to work on this issue in the near future.
Logged

Offline Agent12

  • Member
  • *
  • Posts: 4
Re: RTL with the text editor? possible?
« Reply #6 on: April 06, 2010, 03:12:48 AM »
Quote from: tomers on April 01, 2010, 07:46:22 AM
This seems like a more complicated problems, as Rockbox doesn't support that functionality yet.
Unfortunately, I am not plan to work on this issue in the near future.

Your comment implies that its not possible at all whilst all  the menus are aligned to the right & and the text direction is RTL too.



Logged

Offline tomers

  • Developer
  • Member
  • *
  • Posts: 76
Re: RTL with the text editor? possible?
« Reply #7 on: April 06, 2010, 04:36:57 AM »
Quote from: Agent12 on April 06, 2010, 03:12:48 AM
Quote from: tomers on April 01, 2010, 07:46:22 AM
This seems like a more complicated problems, as Rockbox doesn't support that functionality yet.
Unfortunately, I am not plan to work on this issue in the near future.
Your comment implies that its not possible at all whilst all  the menus are aligned to the right & and the text direction is RTL too.

Actually, I implemented that feature  ;)

Currently it merely aligns the string to the right. It doesn't parse the string at all. All menu items text are hard coded (in language file), therefore, wherever there was an issue with placement of special characters at the end of string, as is the case with exclamation-marks, it was manually moved to the beginning of the string as a workaround (If I recall correctly). See hebrew.lang.
Logged

Offline tomers

  • Developer
  • Member
  • *
  • Posts: 76
Re: RTL with the text editor? possible?
« Reply #8 on: April 07, 2010, 02:20:49 PM »
Quote from: Agent12 on March 28, 2010, 03:05:15 PM
wondering if its possible to use the text editor from right to left [HEBREW]?
The text viewer (not editor) should now (r25519) properly support RTL languages. By support I mean properly aligning the text to the right edge of the screen.

Quote
that the dot or comma which supposed to be at the end of the line, at the left, are still at the left.
This is not fixed yet. I am not going to work on this in the near future  :-\. I hope someone else will.
Logged

Offline Agent12

  • Member
  • *
  • Posts: 4
Re: RTL with the text editor? possible?
« Reply #9 on: April 07, 2010, 05:19:08 PM »
Quote from: tomers on April 07, 2010, 02:20:49 PM

... By support I mean properly aligning the text to the right edge of the screen.



Its actually better then before, and if i put aside the dot/comma issue, when there's a space char at the end of the line (originally on the display) it still puts the space before the line.

for example:

אחת שתיים שלוש___
(___ STANDS FOR THE SPACING CHAR)

thus making the paragraph not whole

אחת שתיים שלוש
אחת שתיים שמונה   
שלוש ארבע חמש
Logged

Offline tomers

  • Developer
  • Member
  • *
  • Posts: 76
Re: RTL with the text editor? possible?
« Reply #10 on: April 08, 2010, 12:47:03 AM »
Quote from: Agent12 on April 07, 2010, 05:19:08 PM
for example:

אחת שתיים שלוש___
(___ STANDS FOR THE SPACING CHAR)

thus making the paragraph not whole

אחת שתיים שלוש
אחת שתיים שמונה   
שלוש ארבע חמש
I'll further debug this issue, but still, I'm not sure I understand this example.
Can you please attach a simple file and screenshot showing the actual result (I will figure how it should look by opening the example file in a text editor on my computer)?

Thanks
Logged

  • Print
Pages: [1]
« previous next »
+  Rockbox Technical Forums
|-+  Support and General Use
| |-+  Plugins/Viewers
| | |-+  RTL with the text editor? possible?
 

  • SMF 2.0.17 | SMF © 2019, Simple Machines
  • Rockbox Privacy Policy
  • XHTML
  • RSS
  • WAP2

Page created in 0.084 seconds with 15 queries.