Support and General Use > User Interface and Voice

view Arabic text (cont.) - About the diacritics patch

(1/2) > >>

amr:
Hello,

This is a continuation on the locked post about diacritics http://forums.rockbox.org/index.php?topic=22388.0.
Here I provide my test before and after the fix of the diacritics patch http://www.rockbox.org/tracker/task/10720 and my attempt to contribute in fixing the issue.

First here are screen dumps of the case before adding diacritics support

as you see, the characters are unjoined and each diacritic take the width of a full non-diacritic character

After diacritics support, the case changed where diacritics disappear in both the text viewer and file list view, and appears only (well positioned without taking new character width) for file name when highlighted on selection in the file list view..; but for all, characters remain unjoined


I tried to fix the problem by a small change in bidi.c http://www.rockbox.org/tracker/task/11095 and here is the result

This fixed the joining problem, now all characters are well connected, but still diacritics appear only on marking file selection in the list view.., I tried to investigate the cause of that and I guess it has something to do with the change of draw mode for diacritics in lcd-bitmap-common.c, but I still don't have a full understanding of the issue and why diacritics appear only on highlighting.

Chronon:
Nice work!  I can't offer any direct advice, but you might find some guidance on the IRC channel.

tomers:

--- Quote from: amr on March 12, 2010, 01:14:42 PM ---...but still diacritics appear only on marking file selection in the list view.., I tried to investigate the cause of that and I guess it has something to do with the change of draw mode for diacritics in lcd-bitmap-common.c, but I still don't have a full understanding of the issue and why diacritics appear only on highlighting.

--- End quote ---

Please review the comment in line 168 in firmware/drivers/lcd-bitmap-common.c. It should explain your observation:
http://svn.rockbox.org/viewvc.cgi/trunk/firmware/drivers/lcd-bitmap-common.c?view=annotate

Thanks,
Tomer

amr:
thanks Tomer,
I've already noticed the comment and tried to comment out the part for changing draw mode but I didn't see any difference.

for now, I tried to do the suggested ORing.., I didn't get the intended result, but also the change (even if it isn't the required) shows up only for the highlighted filename selection, while unselected items and text viewer contents remain intact as if i didn't make any change

a side question, is there some page discussing fonts and rendering other than this: http://www.rockbox.org/wiki/FontFormat which is short and seems not updated?

thanks

amr:
I've updated the patch http://www.rockbox.org/tracker/task/11095 with amiconn's suggestion in the referred comment and am waiting for review...
Now the result appears like this:


just something sounds not a good practice in my fix, that's the temp buffer size I reserved statically; is it enough to reserve just 16 bytes instead of 400 ?

I couldn't find a #define stating the max generic glyph bitmap size, while it's not recommended to dynamically allocate memory with a variable runtime value of pf->maxwidth * pf->height / 8

Navigation

[0] Message Index

[#] Next page