Themes download page - Does't work with current build.

[Avalon]

Hi, I've been using the theme FuzeRock for quite some time and would like to keep using it.  I haven't had any problems and I use the current build and release as of March 7, 2010.

The theme page lists the theme as "Doesn't work with current build".

Could anyone indicate what doesn't work? 

If there is something I should know about, I would avoid the theme or repair it.

[Domonoky]

When the themepage displays that a theme doesnt work with with current build. It means it failed on  the current checkwps. Unfortunatly it doesnt store the output of this tool.

To find out whats wrong, you can run checkwps or a current simulator with "./rockboxui --debugwps" on this theme and check the output.

[Avalon]

Thks for getting back to me.

I installed the latest simulator and checked the FuzeRock theme.

It runs fine on the simulator and on my Fuze (8GB + 16GB).

I don't know where to get Checkwps, so I haven't checked it with that.  However, if it runs on the simulator and on the Fuze, I assume that Checkwps has picked up on some function which I don't use.

Where do I get Checkwps?

[karashata]

If you're downloading the pre-compiled Windows simulators from the extras page you'll need to pay attention to the date they were last compiled on, since the simulator's aren't recompiled very often these days. Currently the last time they were compiled was on Feb. 20th, which means that they're out-dated and don't take into account recent code changes.

As for checkwps, I believe it's a tool that's shipped with the rockbox source code (may or may not need to be compiled, not entirely sure how it works since I've never needed it...)

[Avalon]

FuzeRock runs fine on my Fuze V1 with 3.5.1 and r25066 which are both listed as current.

I can't find any problems, so I am curious about this CheckWPS.  There seem to be several themes failing the check.  Like you, I haven't used CheckWPS, so I don't know how good it is or if it is current.

Just to make sure, if anyone can pinpoint a problem with FuzeRock, I would appreciate a description of the problem.

Thks

[Yotto]

I happen to have the source code sitting here so I tried this.

You do have to compile it, but it's pretty easy (On Linux. Don't know about Windows).

In the source, there's a directory tools/checkwps/
Within that directory is a file buildall.sh that you run (per README)
- It looks like it's in an endless loop, but it's actually compiling for each possible target. Let it go.
In tools/checkwps/output/ there will be a program for each target, named checkwps.<targetname>

The output is about as helpful as Rockbox itself:
If the file passes, it outputs: WPS parsed OK
If the file fails, it outputs: WPS parsing failure

[Domonoky]

The output is about as helpful as Rockbox itself:
If the file passes, it outputs: WPS parsed OK
If the file fails, it outputs: WPS parsing failure

Checkwps should output the line and the token where it failed, unless something broke that.

[Yotto]

Here is the test.wps file I created:

Code: [Select]

%pb|-|20|5

Here is the complete output of checkwps.ipodvideo

Code: [Select]

$ ./checkwps.ipodvideo test.wps 
Checking test.wps...
WPS parsing failure
$ 

*EDIT* I should say, this is for 3.5.1 and I compiled it myself from the source from svn

[gevaerts]

Code: [Select]

$ ./checkwps.ipodvideo test.wps 
Checking test.wps...
WPS parsing failure
$ 

try ./checkwps.ipodvideo -v test.wps

[Yotto]

I did not know about -v

However, it still outputs the same "WPS parsing failure" message. I also tried -vv and -vvv

*EDIT* Is it possibly that my wps is TOO simple? Or the error I've chosen to test happens to be what causes the problem?

[Domonoky]

I just added a new feature to the themepage, so that you now can hover your mouse on the "Doesnt work with current build" line, and get the output of checkwps :-)

It maybe true, that checkwps may not give good output for some errors, but for the FuzeRock theme it clearly says which images are missing.

[Avalon]

Thankyou very much for adding that feature to the themes page.  This should help a lot if there are problems.

I had a closer look and the .bmp files listed as missing are all present.

If you click on the FuzeRock screen shot, a complete listing of zip contents are displayed....all images listed as missing are present.

When I download the zip file, all images are contained in it.

When I install on my Fuze, all images work.  When I install on the simulator all images work.

Is it possible that the CheckWPS was run incorrectly or the FuzeRock zip was mishandled in some way?

The wps files should run in 3.5.1 since it should be backword compatible.  Is there any changes in 3.5.1 wps script handling that would account for this?

I am at a loss as to why these errors are listed when the wps works fine for me..

[Domonoky]

The images which are noted as missing, dont have the correct case. ie its "Repeat.bmp" in the wps, but "repeat.bmp" in the zip.  It looks like checkwps cares about the filecasing now.

[Avalon]

Sounds like a problem with Checkwps.

The Rockbox and simulator executables don't check filecasing since the wps works for them.

If I change the filecase references, how can the theme be upgraded?

If this is the problem, then the other wps files listed as not working may be fine.  I have noticed that there are several which were listed as working a rew weeks ago and are now listed as not working.

I rechecked the theme guidelines and it does request that the images use lower case for naming and reference due to a UNIX requirement.  Sorry for the confusion....I will make the changes required.

Thks again!!!

[karashata]

Themes can be upgraded by resubmitting them with the same theme name, person's name, and e-mail as they were previously submitted with. Assuming the theme is yours, this shouldn't be difficult to do as long as you remember what your name is and what e-mail address you submitted it with the first time.