Album Art finder should also look for a file named after Song Title in metadata

[Falco98]

There should be another option on the list of prioritized options for where to place Album Art images and the filenames. There are currently 7:
http://www.rockbox.org/wiki/AlbumArt

My suggested addition would become the new option 2, pushing all others down.
The first option is currently the only option to allow for song-specific artwork to be displayed, but this requires naming the image files *exactly* like the corresponding sound file, which screws up directory sorting.

Therefore the option should be added that if no image file has an identical name to the sound file playing, it then looks for an image file which matches the current song's Title metadata, similarly to how the following option looks for a match to the Album metadata.

This could cause conflicts when two songs have the same name, or when a song shares the album's name, or the song name contains unusable characters, but such conflicts are rare and minimal, and if anyone cares all that much about such things there is already the built-in flexibility to get around such issues. The additional code required should be minimal (and already blueprinted within the other options), and have essentially zero impact on any other functionality.

I may try to write this patch myself (as i did with "shuffle + track skip"), but if anyone beats me to it, it would be appreciated


Edited to Add:  I have created a working patch for this.  It works as intended in the ipod 5.5 simulator.  The code required is very small.
Could someone reopen FS#10905 so I can attach the patch there?
http://www.rockbox.org/tracker/task/10905

Thanks!



Edited to add (x2): Someone reopened the patch on FS for me, and the patch is posted.  If anyone can check it out and comment, please let me know!

[Llorean]

What do you mean by "screws up directory sorting" exactly?

If the song files don't have a problem being that name, why would the image files?

[Falco98]

What do you mean by "screws up directory sorting" exactly?

If the song files don't have a problem being that name, why would the image files?

'screws up' in an aesthetic sense moreso than in any computer-sorting sense.

that is to say, when i browse into a directory, my music files (which i personally name like "02 - title of the song.ogg" etc) should all 'sort' together; having images with filenames exactly matching the corresponding audio files, suddenly a sorted listing of the directory has images and songs interspersed.  This is a very simple alternative option to that issue - the images can just take the name of the track title, nothing else.

[Llorean]

Wouldn't a simpler solution be to set the file view mode to "music" rather than "supported" so you don't see the image files at all?

[karashata]

Alternatively, you could just set Rockbox to sort the files by type... (Go to Settings > General Settings > File View > Sort Files and select "By Type".)

[GodEater]

Which I think is an even better solution

[JdGordon]

I mentioned my objections in IRC (and the tracker I think), but I think my big issue can be cleanly fixed now.

My problem with this was that you still force your naming scheme on someone else, but thanks to the playlist viewer it shuold be really easy to now make the AA search look up any name based on the id3 info of a track.
The way it should be done is with a "custom" scheme being the highest priority check, this scheme comes from a setting in the .cfg "AA custom search" (or something) which would look like "%it.jpg" which would get translated to "currently playing track title.jpg" by the AA loader.

In fact! once I enable support for the directory structure you could setup a custom scheme like "/AA/%ia/%id/%it.jpg" which gives the user MUCH more flexibility than the current system.

now, if you implement that, it would go in without question.

edit: this might require a new tag added to get the size string from the wps, which is no big deal