Support and General Use > Audio Playback, Database and Playlists
"Add To Playlist" patch
hardeep:
Hi all,
I had some time to look into this patch and have done a massive rewrite. Please try out the new patch and see if there any problems. Updated patch can be found at http://www.rockbox.org/tracker/task/5179. Tracker comments duplicated here:
I've done a massive rewrite of this patch to fix most of the lingering issues. Changes include:
1. All playlists must now be in one directory. The default directory is /Playlists but this can be changed by creating the file /.rockbox/playlist_catalog_config and adding the line "dir:/my/playlist/path name". All related add to/remove from playlist catalog options have been removed from the gui.
2. Only the most recently modified playlist is remembered and placed at the top of the list. All other playlists are ordered based on the file tree configuration.
3. Removed most of the duplicated code when inserting directories (required modifications to playlist code as well)
4. All onplay functionality is available when "View playlists" is selected.
One change I didn't make was to move to the gui_synclist_* functions when browsing the playlist. This is mainly because the menu code is working reasonably well. However, this may still be changed. Aside from this, there's still a little cleanup and documentation that needs to be done. Once that's complete, this patch should be ready for inclusion into the builds (post 3.0 of course).
NOTE: When applying the patch you no longer need to manually copy the playlist_catalag.* files, they are now a part of the patch itself.
-Hardeep
Assimalyst:
Wow, sounds great Hardeep. Thanks. ;D
I'll test it as soon as I a get chance.
lenny:
Wow hardeep! Greatly appreciated.
Everything works splendidly. I know Linus said he didn't think that the directory should be configurable, and to some extent I agree, but if it is going to be configurable I configured it via /.rockbox/playlist_catalog_config and I think that's a simple and unobtrusive way to do it. The only place I saw room for improvement was that in the "Playlist Catalog" menu the "View" option is not available when in the directories, only when you are in the WPS.
Thanks for your time and skills. You're awesome.
Assimalyst:
Been giving the new patch a test, seems to work excellently.
--- Quote from: lenny on May 15, 2006, 04:43:16 AM ---The only place I saw room for improvement was that in the "Playlist Catalog" menu the "View" option is not available when in the directories, only when you are in the WPS.
--- End quote ---
As regards the 'view' option I quite like the functionality as is. I don't think it needs to be accessible from directory view because you can always pretty quickly navigate directly to the /playlists folder. Also it doesn't require an extra down navigation to 'Add to Playlist' when you're potentially adding numerous files to the catalog form directory view.
just my 0.0000000000000002c ;)
Great work, roll on 3.0 release so we can get this in CVS!! ;D
dunno:
Hardeep, thanks for implementing this feature, much aprreciated. I eagerly await it's inclusion after the feature freeze.
Navigation
[0] Message Index
[#] Next page
[*] Previous page
Go to full version