"Add To Playlist" patch

[Assimalyst]

Anyway, a nicely working patch should be done by this evening.

Looking forward to it! Thanks for all your time and effort!

As regards the playlist directory, i personally use this method, but still think it's a good idea to keep the current catalog method because it gives the user more freedom.

Thanks again.

[Shebb]

Anyway...  think I have nailed it now.  Took me a little longer than I thought because I decided to redo most things so the quality of coding is at least a little above my normal hacks.

Rough documentation:

- File context menu:
- - playlists
- - - Add playlist -> adds playlist to catalog if it is not there
- - - Remove playlist -> removes playlist from catalog if it is there
- - music, directories, playlists
- - - Add to playlist -> adds to the end of a playlist
- - - Add to new playlist -> can create a new playlist this way, or just access an existing one.  will add the playlist to the catalog afterwards if it is not present.

Main menu -> playlist options
- Catalog sort -> either priority or alphabetical
- Playlist catalog -> is also accessed when adding files to a playlist but then the context menu cannot be used and the selected list is just chosen rather than played
- - Buttons:
- - Select on main and remote -> plays the selected playlist
- - A-B/mode on main and remote -> changes the sorting
- - Hold select on main or play on remote -> enters context menu
- - - Play playlist
- - - View playlist
- - - Remove playlist -> removes it from catalog
- - - Delete playlist -> removes it then deletes the actual file
- - - Rename playlist -> renames actual playlist file

[attachment deleted by admin, too old]

[Shebb]

These files also are needed. They are to be placed in the /apps folder.

[attachment deleted by admin, too old]

[lenny]

great shebb. I hope it gets in cvs soon.

This is what I have to say. Take it or leave it.

1) the "add to new playlist" feature is great. perfect, infact.
2) I wish you hadn't taken out the ability to browse the playlists from the context menu. having to go into the main menu is a pain.
3) the alphabetical sort doesn't work as I'd expect. It seems to sort all uppercase letters before all lowercase letters. This is what it's doing:

X.m3u
Y.m3u
Z.m3u
a.m3u
b.m3u
c.m3u

dig?

EDIT: ignore that (# 3)...

that's all I have to say. this is fantastic, thanks again Shebb.

[amiconn]

Set 'Sort Case sensitive' to No.

[lenny]

thanks buddy

[Shebb]

Sorry about the case thing.  Silly of me.  Since all my playlists start with a capital I forgot the need for a case insensitive compare.  New file should correct all that.

I had to take the browse playlists function out of the context menu because it has nothing to do with the file selected.  As Linus said, create directory should also be moved from here.  If the playlist thing has enough appeal then a button could be assigned to it.

[attachment deleted by admin, too old]

[lenny]

thanks shebb. I'll try it later. I wouldn't have noticed if I didn't have one playlist with a lowercase letter.

I don't quite understand why it had to come out of the context menu, but I'll take your word for it. the record button isn't doing anything... :p

but that gets me thinking that there could be a variety of functions for the record button and the user could select which one to asign it from the settings. makes sense to me anyway.

[Assimalyst]

Great work Shebb, thanks a lot!

I agree with point 2 that lenny made, think it would be useful.

2) I wish you hadn't taken out the ability to browse the playlists from the context menu. having to go into the main menu is a pain.

Also, an additional feature i think would be useful (though i've no idea how difficult it would be to implement), would be a quick scan of the playlist you're adding to, and only adding the file if it's path does not already exist in the playlist, so preventing duplicates. My memory is shocking and i can never remember what i've already added!

What do you think?

Thanks again for an excellent patch.

[Sweet Spot]

Linus, what do you think the likelyhood is,  of having this patch committed ? I think it's a real step up from the standard implamentation, and would make a fantastic edition to the code.

Doug

[Road Runner]

Like many other users, I think playlists are neglected way too much in rockbox :p
and would love to see it changed (currently patching btw)

I just had one question:

Shebb: what's your text editor program? Vim? Emacs? Pine?      .... WORD?!

[LinusN]

I am reviewing your patch, and I must say that it is definitely a step in the right direction.

Comments:

- Several strings aren't localized (the error messages)
- When you add your first playlist to the catalog, you get an unnecessary error message "No catalog found"
- I want to move the "Playlist catalog" entry to the top main menu (the catalog browser)
- Perhaps it would be cleaner to use the gui_synclist API directly instead of the menu API
- When you play a playlist from the catalog browser, it doesn't take you to the WPS

[kenshin]

I just loaded lenny's build this morning and found one problem with using this patch. Once you enter the context menu there is no way to "browse back". It seems like "browse back" triggers "exit menu" instead of "return to previous menu". For instance, go into "Playlist catalog" then try to go back one menu. Doesn't work. It goes back to the file browser instead.

[kenshin]

Perhaps I'm alone in this but it seems that after loading lenny's build I have major problems playing tracks from a playlist (.m3u file). The tracks are all there, it tries to play them, but after about 3 or 4 tracks it just simply stops ("hangs") when it tries to load the next song. I see it buffering data from the disk but playback never starts. I can hit track foward followed by a track backward and it starts up playing just fine. Loading up a full directory works just fine. Is it possible I still have a jacked playlist file that's causing this breakage?

[Assimalyst]

It could be a problem with the codec loader, which has been fixed, but perhaps still exists in lennys build which is a few days old.

The probelm occurs whenever the codec changes, so if your first 4 tracks are MP3, they'll be fine, then the 5th is OGG, the WPS will display OK, but the playback remains at 0.00

Edit: If you want to PM me your email i'll send you my build, latest bleeding edge (060128-1456), has the codec loader fix in it plus A-B repeat etc. (file's too big to attach).