Support and General Use > Audio Playback, Database and Playlists

"Add To Playlist" patch

<< < (6/29) > >>

Shebb:
Hmm, I think I have it sorted here.  The problem is that I have some other modifications to the same source files and I am just pruning them out of the patch file manually.  I think this should work without problems.

[attachment deleted by admin, too old]

lenny:
Well it made it through settings.c this time, but not settings.h

--- Code: ---patching file apps/onplay.c
patching file apps/settings.c
D:\RockBox\bin\patch.exe: **** malformed patch at line 635: Index: apps/settings.h
--- End code ---
appreciate you trying to fix it! don't over work yourself for our benefit... but still...

roolku:

--- Quote from: Shebb on January 19, 2006, 04:17:52 PM ---The problem is that I have some other modifications to the same source files and I am just pruning them out of the patch file manually.

--- End quote ---

I think this is the cause of the problem, as this will throw off the line count in the patch. Maybe you could backup your files (to keep your other changes) and remove the modifications before you generate the diff file? Thanks for your efforts.

LinusN:
Or you could have separate repositories for your different patches.

I have now tried to actually use your patch and have a few comments:

The context menu should only show the playlist catalog option if the selected item is a directory, a playlist or an audio file. The general idea with the context menu is that it contains a list of actions for the selected item, not anything else. (which reminds me that the "Create directory" option shouldn't be in the context menu)

I'd like the entire catalog interface to be more based on the context. For example, if you select a playlist in the browser, the catalog options should be:

Add to playlist
Add to catalog
Remove from catalog

You could even check the presence of the m3u file in the catalog and not display the "remove" option if it isn't there.

The same goes for audio files and directories. The only option for those should be

Add to playlist

Furthermore, I think the "View playlist" and "Play playlist" options should be removed from the catalog menu and placed in a "Playlist catalog" entry in the main menu. When viewing the catalog list, you should be able to play (by pressing Navi, like in the file browser) or edit a playlist (via a context menu).

This approach could be implemented by recognizing a /Playlists directory, much like the iriver firmware, and letting the file browser handle the rest. Still, I kind of like the current approach with the catalog file, which allows me to have my playlists all over the file system...

Shebb:
Okay, thanks a lot for the feedback.  I will start using multiple projects so I can build patches that I know will work.  I will move the actions not specific to a selected file to the main menu.  I guess putting them directly below 'Playlist Options'.  The other stuff sounds good as well.

I was originally going to implement the system by using a playlist folder for the files but I decided against it because I really prefer to keep my playlist files in assorted places.  If people generally would prefer the directory solution I could do that instead.

Anyway, a nicely working patch should be done by this evening.

Navigation

[0] Message Index

[#] Next page

[*] Previous page