"Add To Playlist" patch

[Shebb]

Yeah, it is feature bloat.  I have found I do not need them.  The shuffle playlist feature can be dumped as well but I would like to see it in the view playlist along with a couple of other features...  I think I might patch that.

It will be far more efficient to just append new songs to the end but the whole recursive directory thing will have to be duplicated in the function if one wants to add directories to a playlist. 

I am not sure if the actual listing of the playlists in the catalog is quite the right way to go about things.  I hard coded a limit of 100 playlists into the source.  I personally like having the playlist selected from the catalog move to the top, but would anyone prefer the playlists to be sorted alphabetically at all?

And I am not sure if I am building my patches quite right.  To add multiple files I am just using >> instead of > so as to append the new stuff.  Is this correct?

[dunno]

I think that Alphabetical sorting is the most logical, and intuitive.

[Assimalyst]

I think that Alphabetical sorting is the most logical, and intuitive.

I'd agree, although i understand it can be handy to have the most recent at the top, overtime in a long list it could be difficult to find the m3u you're looking for as the list becomes essentially shuffled.

Maybe a combination would be possible; the three most recent at top, the rest alphabetically? I have no idea if this is feasable, just throwing in some ideas.

[yngwi]

I also would prefer sorting alphabetically, as all my premade playlists in my special playlist folder are...

[Shebb]

I found a nice easy solution.  There is a setting which chooses which sort is used.  But to make things more intuitive you can press a button while viewing the playlists to switch the sort.  I will release the new patch tomorrow.  Currently I have hard-coded the h140's BUTTON_MODE for this purpose.  Which button should I assign this function to for the other devices?

I have also changed the insertion behavior to append the files to the playlist without going through the playlist API as suggested by Linus.

[lenny]

I'm glad you didn't drop the "last used, top of list" sort method. I like it that way too, even if I'm the only one. Depends on how you use it I suppose.

I don't know what it would take but I keep thinking that having an "insert into new playlist" option would be great.

In my mind it would bring up a text entry screen and you could type /playlists/newplaylist.m3u or whatever you want. it would be written with the one track in it and then be included in the catalog.

Just an idea, really. It would save me about ten steps (or so it seems).

I really like the patch. thanks again for writing it!

[Assimalyst]

having an "insert into new playlist" option would be great.

Agreed, found myself having to do this the long way round the earlier on, would certainly be a handy addition.

[Shebb]

Okay...

New to this patch:
> No insert first or shuffled
> No shuffle playlist
> Faster way of adding files to a playlist
> Add to a new playlist.  This will also save the new playlist to the catalog.
> Priority or alphabetical sort.  The option can be switched in the playlist settings.  it can also be changed by just pressing the AB/mode button on either the main unit or remote of an Hxxx.  This feature has no assigned button for other models

I hope the patch works okay.  I am no expert with CVS.

[attachment deleted by admin, too old]

[lenny]

This is what I get:

Code: [Select]

patching file apps/onplay.c
D:\RockBox\bin\patch.exe: **** malformed patch at line 623: Index: apps/settings.c

All of your other ones worked up until now, as did Linus's

[Assimalyst]

This is what I get:

Code: [Select]

patching file apps/onplay.c
D:\RockBox\bin\patch.exe: **** malformed patch at line 623: Index: apps/settings.c

Same    Wish i could code so i could offer a suggestion on a fix but alas, i am a simpleton!

Hope you can sort it soon, sounds like there's some good additions. Can't wait to try it.

[Shebb]

Hmm, I think I have it sorted here.  The problem is that I have some other modifications to the same source files and I am just pruning them out of the patch file manually.  I think this should work without problems.

[attachment deleted by admin, too old]

[lenny]

Well it made it through settings.c this time, but not settings.h

Code: [Select]

patching file apps/onplay.c
patching file apps/settings.c
D:\RockBox\bin\patch.exe: **** malformed patch at line 635: Index: apps/settings.h

appreciate you trying to fix it! don't over work yourself for our benefit... but still...

[roolku]

The problem is that I have some other modifications to the same source files and I am just pruning them out of the patch file manually.

I think this is the cause of the problem, as this will throw off the line count in the patch. Maybe you could backup your files (to keep your other changes) and remove the modifications before you generate the diff file? Thanks for your efforts.

[LinusN]

Or you could have separate repositories for your different patches.

I have now tried to actually use your patch and have a few comments:

The context menu should only show the playlist catalog option if the selected item is a directory, a playlist or an audio file. The general idea with the context menu is that it contains a list of actions for the selected item, not anything else. (which reminds me that the "Create directory" option shouldn't be in the context menu)

I'd like the entire catalog interface to be more based on the context. For example, if you select a playlist in the browser, the catalog options should be:

Add to playlist
Add to catalog
Remove from catalog

You could even check the presence of the m3u file in the catalog and not display the "remove" option if it isn't there.

The same goes for audio files and directories. The only option for those should be

Add to playlist

Furthermore, I think the "View playlist" and "Play playlist" options should be removed from the catalog menu and placed in a "Playlist catalog" entry in the main menu. When viewing the catalog list, you should be able to play (by pressing Navi, like in the file browser) or edit a playlist (via a context menu).

This approach could be implemented by recognizing a /Playlists directory, much like the iriver firmware, and letting the file browser handle the rest. Still, I kind of like the current approach with the catalog file, which allows me to have my playlists all over the file system...

[Shebb]

Okay, thanks a lot for the feedback.  I will start using multiple projects so I can build patches that I know will work.  I will move the actions not specific to a selected file to the main menu.  I guess putting them directly below 'Playlist Options'.  The other stuff sounds good as well.

I was originally going to implement the system by using a playlist folder for the files but I decided against it because I really prefer to keep my playlist files in assorted places.  If people generally would prefer the directory solution I could do that instead.

Anyway, a nicely working patch should be done by this evening.