Rockbox.org home
Downloads
Release release
Dev builds dev builds
Extras extras
themes themes
Documentation
Manual manual
Wiki wiki
Device Status device status
Support
Forums forums
Mailing lists mailing lists
IRC IRC
Development
Bugs bugs
Patches patches
Dev Guide dev guide
Search



Donate

Rockbox Technical Forums


Login with username, password and session length
Home Help Search Staff List Login Register
News:

Welcome to the Rockbox Technical Forums!

+  Rockbox Technical Forums
|-+  Support and General Use
| |-+  Audio Playback, Database and Playlists
| | |-+  Grouping tag not working for tagnavi_custom.config
« previous next »
  • Print
Pages: [1]

Author Topic: Grouping tag not working for tagnavi_custom.config  (Read 1817 times)

Offline philip123

  • Member
  • *
  • Posts: 7
Grouping tag not working for tagnavi_custom.config
« on: January 05, 2010, 10:35:16 AM »
Hi,

I am trying to use the grouping tag in a custom tagnavi_custom.config file but the values that I see is the title tag.

So if I have

#! rockbox/tagbrowser/2.0
%format "fmt_title_grouping"       "%s - %s - %s" grouping artist title

%menu_start "custom" "Database"
"Grouping"   -> grouping   -> title = "fmt_title_grouping"

I see the following: title - artist - title
So it would seem something is wrong, the grouping tag returns the same values as the title tag.

I am running rockbox 3.4 on Ipod 5.5 80G.

Can anyone else confirm that the grouping tag is not working as expected.
Logged

Offline roolku

  • Developer
  • Member
  • *
  • Posts: 350
Re: Grouping tag not working for tagnavi_custom.config
« Reply #1 on: January 05, 2010, 04:44:41 PM »
Hm. Works for me as expected. Please make sure the files actually have a grouping tag as otherwise the title tag is used instead. Also if you have added the grouping tags recently the database may not be up-to-date? Maybe you can provide an affected file for testing?

* dump 100105-214323.jpg (9.57 kB, 240x320 - viewed 181 times.)
« Last Edit: January 05, 2010, 04:46:58 PM by roolku »
Logged

Offline philip123

  • Member
  • *
  • Posts: 7
Re: Grouping tag not working for tagnavi_custom.config
« Reply #2 on: January 06, 2010, 01:54:26 AM »
Hi,

I have checked that the mp3 files have the grouping tag, and I have also completely re-initialised the database by deleting it first.

I have found that this works correctly:

#! rockbox/tagbrowser/2.0


%format "fmt_title2"       "%s - %s - %s" grouping artist title

# Define the title of the main menu
%menu_start "custom" "Database"
"Artist(Grouping Sok-Old-Art)"   -> grouping ? grouping @ "Something1|Something2"  -> title = "fmt_title2"

But this:
"Artist(Grouping)"   -> grouping -> title = "fmt_title2"
doesn't work.

It displays a long list of tracks and if I click on one I see the format: title - artist - title?

Am I missing something?

Logged

Offline roolku

  • Developer
  • Member
  • *
  • Posts: 350
Re: Grouping tag not working for tagnavi_custom.config
« Reply #3 on: January 06, 2010, 03:55:31 AM »
Quote from: philip123 on January 06, 2010, 01:54:26 AM
It displays a long list of tracks and if I click on one I see the format: title - artist - title?

Could you confirm that you really mean what you say here? When you select Artist(Grouping) you get "<All tracks>", "<Random>"  and a list of track names ? So it is not only affecting the formatting but the filter as well?

This really points to missing or not correctly read grouping tags. When you select a track from the list to play it and look at its "Track Info", does it list the grouping under [work]?
Logged

Offline philip123

  • Member
  • *
  • Posts: 7
Re: Grouping tag not working for tagnavi_custom.config
« Reply #4 on: January 06, 2010, 07:00:59 AM »
Hi,

Sorry I now realise what you meant for missing grouping tags, as not all my mp3's have grouping tags, only about a third.
So for all mp3's that don't have a grouping tag, the title is used instead.
Is there a way to prevent this from happening, so that for all mp3's where the grouping tag is not set they should just be ignored, or a grouping of "" should be used and not the title?

This is how I saw it now:
I have also found that if I use this:
"Grouping (new)"   -> grouping ? grouping ~ "new" -> title = "fmt_title2"

I get back the mp3's that either has the letters "new" in the grouping field OR in the title if they don't have a grouping field.

So if I click on Grouping (new) I see:
<All tracks>
<Random>
a-new -> If I click on this I get a number of mp3's with the grouping tag that is a-new, this is fine. (Looks like this: a-new - Coldplay - Life in Technicolor, which is correct!)

I knew I loved you -> If I click on this I get two songs with the title "I knew I loved you"
(looks like this: I knew I loved you - Savage Garden - I knew I loved you, which is not what I expected, the first field which is the grouping tag is displaying the title of the mp3, but the tag is empty in the mp3.)

« Last Edit: January 06, 2010, 07:05:11 AM by philip123 »
Logged

Offline roolku

  • Developer
  • Member
  • *
  • Posts: 350
Re: Grouping tag not working for tagnavi_custom.config
« Reply #5 on: January 06, 2010, 07:18:24 AM »
Quote from: philip123 on January 06, 2010, 07:00:59 AM
So for all mp3's that don't have a grouping tag, the title is used instead.
Is there a way to prevent this from happening, so that for all mp3's where the grouping tag is not set they should just be ignored, or a grouping of "" should be used and not the title?

This was a design decision when the feature was introduced: http://www.rockbox.org/tracker/task/7362 

I can see the an advantage in both ways but since I don't use the tag I don't have a strong opinion. Maybe its worth an opinion poll?

As a workaround you could tag all the non-tagged ones with a special tag and exclude this in a condition. Or if (for example) only your classical tracks use grouping you can use Genre in the condition.
Logged

Offline philip123

  • Member
  • *
  • Posts: 7
Re: Grouping tag not working for tagnavi_custom.config
« Reply #6 on: January 06, 2010, 07:34:38 AM »
Hi,
Thanks but it won't be a very nice work-around for me to tag all the tracks that don't have tags. I use a couple of special custom fields in Mediamonkey, custom 1, custom 2, custom 3, custom 4, custom 5.

I am trying to get some of that information into rockbox because I use it to build my playlists.

I need to get the info from custom 1 into rockbox, so my option is to copy it to the grouping or the comment field. But I don't want to use the comment field because it already contains some information.

Logged

Offline Llorean

  • Member
  • *
  • Posts: 12931
Re: Grouping tag not working for tagnavi_custom.config
« Reply #7 on: January 06, 2010, 07:39:07 AM »
The grouping tags can't really work properly if they don't fall back to the standard tag when not present - otherwise they'd require all files contain both tags even when they are identical (and tagnavis designed for grouping could not work well with files not tagged for it).
Logged

Offline philip123

  • Member
  • *
  • Posts: 7
Re: Grouping tag not working for tagnavi_custom.config
« Reply #8 on: January 06, 2010, 07:43:44 AM »
Thanks for explaining it. I understand. I will make use of another field for my purposes.

I am just wondering, would it be possible at all to add support for the custom mp3 tags that mediamonkey uses.
For instance: custom 1, custom 2 and custom 3?

Update:
I have now tried to use the comment field.
It is working more-or-less but I am seeing some problems.

The comment field sometimes has values in from other fields when the comment field is empty.
« Last Edit: January 06, 2010, 09:12:05 AM by philip123 »
Logged

  • Print
Pages: [1]
« previous next »
+  Rockbox Technical Forums
|-+  Support and General Use
| |-+  Audio Playback, Database and Playlists
| | |-+  Grouping tag not working for tagnavi_custom.config
 

  • SMF 2.0.17 | SMF © 2019, Simple Machines
  • Rockbox Privacy Policy
  • XHTML
  • RSS
  • WAP2

Page created in 0.076 seconds with 15 queries.