Rockbox.org home
Downloads
Release release
Dev builds dev builds
Extras extras
themes themes
Documentation
Manual manual
Wiki wiki
Device Status device status
Support
Forums forums
Mailing lists mailing lists
IRC IRC
Development
Bugs bugs
Patches patches
Dev Guide dev guide
Search



Donate

Rockbox Technical Forums


Login with username, password and session length
Home Help Search Staff List Login Register
News:

Rockbox Ports are now being developed for various digital audio players!

+  Rockbox Technical Forums
|-+  Rockbox Development
| |-+  Feature Ideas
| | |-+  cue sheet split limit?
« previous next »
  • Print
Pages: [1]

Author Topic: cue sheet split limit?  (Read 3412 times)

Offline maxhondur

  • Member
  • *
  • Posts: 2
cue sheet split limit?
« on: January 04, 2010, 11:30:26 PM »
Hello,

Just a random thought, as I was using automatic pause detections for my audiobooks: The cue sheet standard supports up to 99 splits per file. Would bumping this number upwards cause instability issues with the current rockbox builds? (I'm using rockbox on the Fuzev1, which to the best of my knowledge ignores index numbers after 99.)

Either way though, sincere thanks to the rockbox team, especially for adding .cue support to begin with :)
Logged

Offline saratoga

  • Developer
  • Member
  • *
  • Posts: 8974
Re: cue sheet split limit?
« Reply #1 on: January 04, 2010, 11:41:44 PM »
Quote from: maxhondur on January 04, 2010, 11:30:26 PM
Hello,

Just a random thought, as I was using automatic pause detections for my audiobooks: The cue sheet standard supports up to 99 splits per file. Would bumping this number upwards cause instability issues with the current rockbox builds? (I'm using rockbox on the Fuzev1, which to the best of my knowledge ignores index numbers after 99.)

Either way though, sincere thanks to the rockbox team, especially for adding .cue support to begin with :)


From cuesheet.h:

#define MAX_TRACKS 99  /* Max number of tracks in a cuesheet */

Try 100 and see if it works.
Logged

Offline JdGordon

  • Member
  • *
  • Posts: 1817
  • Constantly breaking stuff
Re: cue sheet split limit?
« Reply #2 on: January 05, 2010, 11:40:23 AM »
yeah, changing that #define and recompiling is the only way to do it (and that should be safe), there are surely better ways of doing it than splitting on every pause?
Logged


Using PMs to annoy devs about bugs/patches is not a good way to have the issue looked at.

Offline maxhondur

  • Member
  • *
  • Posts: 2
Re: cue sheet split limit?
« Reply #3 on: January 08, 2010, 05:35:46 AM »
saratoga and JdGordon, thank you for the replies.

I split my books into separate files according to chapters, but I figured that internal splits would be kind of cool to have too.. anyways, it was just one of those things that got me wondering. It struck me as an oddity that there was a track limit on a cuesheet in rockbox, considering the intuition that rockbox should be able to handle much more than that, and that the 99 split limit for the cuesheet specification standard seems somewhat arbitrary to begin with.

Again, thanks for the replies. To those who are curious, I've compiled the source code using up to MAX_TRACKS 2000 on the fuze, no apparent problems :D
« Last Edit: January 08, 2010, 05:38:18 AM by maxhondur »
Logged

Offline GodEater

  • Member
  • *
  • Posts: 2829
Re: cue sheet split limit?
« Reply #4 on: January 08, 2010, 09:30:06 AM »
Quote from: maxhondur on January 08, 2010, 05:35:46 AM
It struck me as an oddity that there was a track limit on a cuesheet in rockbox, considering the intuition that rockbox should be able to handle much more than that, and that the 99 split limit for the cuesheet specification standard seems somewhat arbitrary to begin with.

Resources on an MP3 player are not even remotely close to infinite. Making the change as you have done has robbed your player of memory elsewhere. While you may find that acceptable - others would not. This is why we arbitrarily set the limit at 99, which seems generous in most cases. 2000 seems very excessive to me - but I'm glad you're finding it useful :)
Logged

Read The Manual Please

Offline froggyman

  • Member
  • *
  • Posts: 214
Re: cue sheet split limit?
« Reply #5 on: January 09, 2010, 12:31:27 AM »
Quote from: GodEater on January 08, 2010, 09:30:06 AM
Quote from: maxhondur on January 08, 2010, 05:35:46 AM
It struck me as an oddity that there was a track limit on a cuesheet in rockbox, considering the intuition that rockbox should be able to handle much more than that, and that the 99 split limit for the cuesheet specification standard seems somewhat arbitrary to begin with.

Resources on an MP3 player are not even remotely close to infinite. Making the change as you have done has robbed your player of memory elsewhere. While you may find that acceptable - others would not. This is why we arbitrarily set the limit at 99, which seems generous in most cases. 2000 seems very excessive to me - but I'm glad you're finding it useful :)

I have never even used the cuesheets, so 99 would be a bit too generous in my case.
Logged
iPod Video 5.5G 30GB - Now Dead :(
Sansa Fuzev2 4GB

"To prevent this day from getting worse, I'll just read ERROR as GOOD THING"

Offline Llorean

  • Member
  • *
  • Posts: 12931
Re: cue sheet split limit?
« Reply #6 on: January 09, 2010, 02:23:36 AM »
I think the assumption is that cuesheets will be used to describe the track breakup of a ripped CD and it's extremely uncommon for CDs to have more than 99 tracks.

Even most books don't have over 100 chapters (and it's quite possible to split them into smaller files anyway, there's not generally the same reason for wanting a single-file solution) so larger cuesheets seems like an extremely special case.
Logged

Offline linuxstb

  • Developer
  • Member
  • *
  • Posts: 1163
Re: cue sheet split limit?
« Reply #7 on: January 29, 2010, 03:05:18 PM »
Yes, cuesheets were invented for describing the indexing on CDs, and CDs can only have a maximum of 99 tracks.  That's why the cuesheet limit in Rockbox is 99 - it's not arbitrary.

I expect Rockbox would be happy if you increased that limit (although the parser may assume a two-digit track number), but don't expect other cuesheet software to support them.
Logged

  • Print
Pages: [1]
« previous next »
+  Rockbox Technical Forums
|-+  Rockbox Development
| |-+  Feature Ideas
| | |-+  cue sheet split limit?
 

  • SMF 2.0.17 | SMF © 2019, Simple Machines
  • Rockbox Privacy Policy
  • XHTML
  • RSS
  • WAP2

Page created in 0.836 seconds with 15 queries.