Rockbox Development > Feature Ideas

More colors in LAMP-Plugin

(1/1)

DB1BMN:
Hello and Merry Christmas,

to get a little bit familiar to Rockbox development I started on a real trivial thing:

I've extended the lamp-plugin by a some more colors (green, blue, yellow, orange), which was real simple done by extending the 2-dimensional array colorset by additional entries of the RGB-values, see the attached file. I've compiled it under Ubuntu and it works fine on my Sansa e250 V1.

What do you think, should I publish it as a patch under flyspray or just update my SVN? I'm not sure, since I did not do it before and it is my first attemption to put something back to the communitiy.

Another expirience I did: It is not sufficient just to exchange *.rock-file but I had to update the whole rockbox firmware, it seems that the jump-in/return addresses shift if you modify a plug-in.

Regards from Germany, Mark

tomers:

--- Quote from: DB1BMN on December 24, 2009, 03:35:49 PM ---I've extended the lamp-plugin by a some more colors (green, blue, yellow, orange), which was real simple done by extending the 2-dimensional array colorset by additional entries of the RGB-values, see the attached file. I've compiled it under Ubuntu and it works fine on my Sansa e250 V1.

--- End quote ---
Thanks! That's sound great! Take a look at the mandelbrot plugin too - it also needs to be added some colors  ;)


--- Quote from: DB1BMN on December 24, 2009, 03:35:49 PM ---What do you think, should I publish it as a patch under flyspray or just update my SVN?

--- End quote ---
You definitely need to post a Flyspray item! But please post a patch, not a file.
See http://www.rockbox.org/wiki/WorkingWithPatches.

Also, you do not have SVN privileges to commit any changes. For that you'll have to get such privileges from the developers community. You will get it when people will get to learn you and your work  ;)


--- Quote from: DB1BMN on December 24, 2009, 03:35:49 PM ---Another expirience I did: It is not sufficient just to exchange *.rock-file but I had to update the whole rockbox firmware, it seems that the jump-in/return addresses shift if you modify a plug-in.

--- End quote ---
Whenever the plugins API version changes, you must recompile Rockbox again. It is rarely changed, but was just changed today: http://svn.rockbox.org/viewvc.cgi?view=rev;revision=24110.
Otherwise, you can run
--- Code: ---make rocks
--- End code ---
and then copy only the *.rock file to the DAP.

DB1BMN:
Hello and thank you!

I've prepared the patchfile and created a FlySpray entry: http://www.rockbox.org/tracker/task/10877
Hope this will work.
What I'm not quite sure about is the header, as I added my name and date. Could you, or some else take a short look at it and tell my, how to "patch" correctly the header?

Regards, Mark

Navigation

[0] Message Index