Rockbox.org home
Downloads
Release release
Dev builds dev builds
Extras extras
themes themes
Documentation
Manual manual
Wiki wiki
Device Status device status
Support
Forums forums
Mailing lists mailing lists
IRC IRC
Development
Bugs bugs
Patches patches
Dev Guide dev guide
Search



Donate

Rockbox Technical Forums


Login with username, password and session length
Home Help Search Staff List Login Register
News:

Welcome to the Rockbox Technical Forums!

+  Rockbox Technical Forums
|-+  Support and General Use
| |-+  Theming and Appearance Customization
| | |-+  thoughts on the colour and backdrop settings
« previous next »
  • Print
Pages: [1]

Author Topic: thoughts on the colour and backdrop settings  (Read 2406 times)

Offline JdGordon

  • Member
  • *
  • Posts: 1817
  • Constantly breaking stuff
thoughts on the colour and backdrop settings
« on: December 20, 2009, 09:29:09 PM »
since custom statusbar and ui viewport settings went in, the settings controlling the list colours and main backdrop image don't really make sense anymore....
This can be made very obvious when you load a ui viewport which sets the colours.. try changing the colours in the setting and its totally useless. Ditto with the backdrop image (in theory you could load a backdrop in the sbs and a different one with the wps and it should just work.. but it doesnt because %X will load both into the same buffer...)

So, what would be nice is to remove those settings which are meaningless and start forcing use of the ui viewport setting and sbs to do the backdrops....

comment?
Logged


Using PMs to annoy devs about bugs/patches is not a good way to have the issue looked at.

Offline Llorean

  • Member
  • *
  • Posts: 12931
Re: thoughts on the colour and backdrop settings
« Reply #1 on: December 20, 2009, 09:37:25 PM »
Agreed.
Logged

Offline audio-i

  • Artist
  • Member
  • *
  • Posts: 266
Re: thoughts on the colour and backdrop settings
« Reply #2 on: December 20, 2009, 10:11:39 PM »
The change makes all the sense.

Quote from: JdGordon on December 20, 2009, 09:29:09 PM
So, what would be nice is to remove those settings which are meaningless and start forcing use of the ui viewport setting and sbs to do the backdrops....
But would this mean there would be a backwards incompatibility?
Logged

Offline JdGordon

  • Member
  • *
  • Posts: 1817
  • Constantly breaking stuff
Re: thoughts on the colour and backdrop settings
« Reply #3 on: December 20, 2009, 10:34:07 PM »
backwards incompatability is something we dont care about....
Logged


Using PMs to annoy devs about bugs/patches is not a good way to have the issue looked at.

Offline JdGordon

  • Member
  • *
  • Posts: 1817
  • Constantly breaking stuff
Re: thoughts on the colour and backdrop settings
« Reply #4 on: December 20, 2009, 11:05:19 PM »
also... does this sound correct?

If a WPS doesnt disable the sbs, then its very unlikely it will load its own backdrop and should use the backdrop from the menus?
Logged


Using PMs to annoy devs about bugs/patches is not a good way to have the issue looked at.

Offline [Saint]

  • Rockbox Expert
  • Member
  • *
  • Posts: 1662
  • Hayden Pearce
    • Google+
Re: thoughts on the colour and backdrop settings
« Reply #5 on: December 21, 2009, 04:04:03 AM »
.
Quote from: JdGordon on December 20, 2009, 11:05:19 PM
If a WPS doesnt disable the sbs, then its very unlikely it will load its own backdrop and should use the backdrop from the menus?

I think regardless as to whether or not an .sbs is loaded, if a background image is loaded for the menu, but not by the WPS, it makes sense for the WPS to use the menu's backdrop by default instead of leaving it blank.

Makes sense to me at least.

Also,

Will this have any effect on using a .cfg to specify colours/backdrop via the:

forground colour:
background colour:
backdrop:

Settings?

What about the current %X WPS Tag? Will that no longer work?

Won't this break any themes/WPS made prior to this change?
I don't use an .sbs nor do I have a UI Viewport setting specified so....just curious.

Perhaps I've missunderstood.



[St.]
Logged
Using PMs to annoy devs about bugs/patches is not a good way to have the issue looked at.

Offline Llorean

  • Member
  • *
  • Posts: 12931
Re: thoughts on the colour and backdrop settings
« Reply #6 on: December 21, 2009, 08:32:44 AM »
I think the opposite - the WPS should never "inherit" the backdrop from the menus. Instead just require the author to always explicitly define both so that there's never any accidental weirdness when changing themes or whatnot.

Otherwise there's really no way for a WPS author to actually say "no backdrop for the WPS, but I want one for the menus" right?
Logged

Offline [Saint]

  • Rockbox Expert
  • Member
  • *
  • Posts: 1662
  • Hayden Pearce
    • Google+
Re: thoughts on the colour and backdrop settings
« Reply #7 on: December 21, 2009, 08:59:23 AM »
Good call, I hadn't thought of that.
Logged
Using PMs to annoy devs about bugs/patches is not a good way to have the issue looked at.

Offline fml2

  • Member
  • *
  • Posts: 157
Re: thoughts on the colour and backdrop settings
« Reply #8 on: December 21, 2009, 11:05:13 AM »
Quote from: JdGordon on December 20, 2009, 09:29:09 PM
since custom statusbar and ui viewport settings went in, the settings controlling the list colours and main backdrop image don't really make sense anymore....
This can be made very obvious when you load a ui viewport which sets the colours.. [...]

I must admit I haven't looked into the custom status bar (csb) and ui viewport features since I don't use them. But from here arises my question: do the old (i.e. now existing) settings still make sense in this situation? Or is some default csb and ui viewport used in that case so that the settings are meaningless even then?

I use a very minimalistic text only WPS without backdrop.
Logged

Offline JdGordon

  • Member
  • *
  • Posts: 1817
  • Constantly breaking stuff
Re: thoughts on the colour and backdrop settings
« Reply #9 on: December 21, 2009, 01:57:16 PM »
[St.] has it exactly backwards... I'm saying that if the WPS doesnt disable the sbs, then there is a tiny chance that will will load a backdrop, i.e it would expect to be using the themes backdrop and not its own. if no backdrop is loaded in the WPS then there is no change, it will display a flat colour.

fml: (the custom statusbar acronym is sbs :D ) yes thats what I'm asking, and what I was arguing probably 2 months ago. using a sbs should be sufficient to set the menus backdrop, colours and ui viewport. The 3 settings in [St.]'s post as well as "ui viewport" all are redundant
Logged


Using PMs to annoy devs about bugs/patches is not a good way to have the issue looked at.

Offline fml2

  • Member
  • *
  • Posts: 157
Re: thoughts on the colour and backdrop settings
« Reply #10 on: December 21, 2009, 04:59:09 PM »
Quote from: JdGordon on December 21, 2009, 01:57:16 PM
fml: (the custom statusbar acronym is sbs :D ) yes thats what I'm asking, and what I was arguing probably 2 months ago. using a sbs [...]

My qestion was rather what happens if I don't use any sbs and/or a custom viewport explicitly. I just want to use the inbuilt status bar (however it looks like -- I assume it has all important information in it) and the default viewport (which, I think and hope, is the whole screen).
Logged

Offline JdGordon

  • Member
  • *
  • Posts: 1817
  • Constantly breaking stuff
Re: thoughts on the colour and backdrop settings
« Reply #11 on: December 21, 2009, 05:07:31 PM »
yes, thats the only downside to this.
Logged


Using PMs to annoy devs about bugs/patches is not a good way to have the issue looked at.

  • Print
Pages: [1]
« previous next »
+  Rockbox Technical Forums
|-+  Support and General Use
| |-+  Theming and Appearance Customization
| | |-+  thoughts on the colour and backdrop settings
 

  • SMF 2.0.17 | SMF © 2019, Simple Machines
  • Rockbox Privacy Policy
  • XHTML
  • RSS
  • WAP2

Page created in 0.093 seconds with 15 queries.