Support and General Use > Theming and Appearance Customization
Language aware positioning of WPS elements
tomers:
St.,
Thank you for your feedback.
--- Quote from: [St.] on December 27, 2009, 09:21:32 PM ---Just an opinion, but why not make your own WPS (even if it is just another cabbie variant) as well as the patch?
--- End quote ---
The main idea of this patch is to make already existent WPS screens look more naturally when Rockbox interface is set to any RTL language (Hebrew, Arabic).
With my patch applied, the Cabbie theme looks the same (didn't create any regression). But when RTL language is in use, it looks more natural, oriented from right to left. There is no point in creating any new RTL variant of any theme if this patch is used.
Not all themes can be sensitive to language direction, because their orientation is 'hard-coded' in the graphics, so that horizontally mirroring their viewports or album-art location doesn't look well. One example is the iPodWidgets theme.
I will try to review all themes in SVN and make them language direction sensitive, if appropriate. I'll add it to the patch, and when we feel it is ready, I'll commit. I'll appreciate if you can test it and report.
--- Quote from: [St.] on December 27, 2009, 09:21:32 PM ---A great many number of people can access this patch, apply it to their liking, compile a build etc.....but a great many more (potentially) could benefit from the same piece of code when presented as a WPS and uploaded to the Theme Site.
--- End quote ---
The patch will hopefully be committed soon, so that everyone will get its functionality, without the need to patch and recompile...
--- Quote from: [St.] on December 27, 2009, 09:21:32 PM ---And then, you get to express yourself artistically as well ;D
--- End quote ---
Unfortunately, I am not that of an artist yet ;)
[Saint]:
Wow cool, I didn't realise it was headed for a commit.
Usually I see an idea and think "hey that's cool..." but it never makes it to the official build.
How did you achieve the effect?
%?C<%?Sr<RTL viewport|LTR viewport>|no AA so center it and who cares>
is probably what I'd of tried...
But I'm interested to know how you've done it.
[St.]
PS:
--- Quote from: tomers on December 28, 2009, 12:40:06 AM ---Unfortunately, I am not that of an artist yet ;)
--- End quote ---
If you can use Notepad and MSPaint, you can make a WPS ;D
tomers:
--- Quote from: [St.] on December 28, 2009, 03:34:07 AM ---Wow cool, I didn't realize it was headed for a commit.
Usually I see an idea and think "hey that's cool..." but it never makes it to the official build.
--- End quote ---
All patches are meant to be committed sometime. If they are not appropriate to the official build, they will eventually be closed.
--- Quote from: [St.] on December 28, 2009, 03:34:07 AM ---How did you achieve the effect?
--- End quote ---
May I suggest you read the code? ::)
--- Quote from: [St.] on December 28, 2009, 03:34:07 AM ---%?C<%?Sr<RTL viewport|LTR viewport>|no AA so center it and who cares>
is probably what I'd of tried...
--- End quote ---
I tried using this method, but to code turned out to be awy too complicated. I don't remember exactly what was the exact code (BTW I created the %?Sr directive).
I think the current suggestion is far better, although the letters used quite suck - but that's the ones left >:(
--- Quote from: [St.] on December 28, 2009, 03:34:07 AM ---If you can use Notepad and MSPaint, you can make a WPS ;D
--- End quote ---
I think this is not a good idea - we will get a bunch of ugly themes created by programmers. This task should be given to artists...
[Saint]:
--- Quote from: tomers on December 28, 2009, 04:12:32 AM ---I think this is not a good idea - we will get a bunch of ugly themes created by programmers. This task should be given to artists...
--- End quote ---
I don't think I've ever really, truly had a moment before now where I could actually type LOL knowing that I actually did "laugh out loud"....my girlfriend came in from the next room to see what was so funny (and was quite dissappointed I might add)
So..(if I read it correctly) upon this patch being committed the prefix to the x co-ord "s" would then horrizontally mirror the viewport?
Well, that's a SHITLOAD easier than getting the WPS to do the legwork via conditionals...well done!
Navigation
[0] Message Index
[*] Previous page
Go to full version