Need help with my WPS :/

[Domonoky]

I hope there will be a theme site for the D2 soon Smiley

I just added D2 to the theme site. :-)

[perfectdrug]

@perfectdrug: Sure! Just mention me somewhere

i did it

http://forums.rockbox.org/index.php?topic=6751.msg158326#msg158326

I hope there will be a theme site for the D2 soon Smiley

I just added D2 to the theme site. :-)

Biont: make sure to read the guidelines first (http://www.rockbox.org/wiki/ThemeGuidelines) you renamed e.g. the font with a fidelity prefix (but I haven't fixed this in my ported version neither) i guess there could be some more issues (I think you also have no filename fallback if the filetags aren't present)

anyway thanks for the cool theme 

[Biont]

@perfectdrug: Sure! Just mention me somewhere

i did it

Wow, good work!

Biont: make sure to read the guidelines first (http://www.rockbox.org/wiki/ThemeGuidelines) you renamed e.g. the font with a fidelity prefix (but I haven't fixed this in my ported version neither) i guess there could be some more issues (I think you also have no filename fallback if the filetags aren't present)

I read them yesterday evening. Yeah, there's still stuff to do. But I wanted to wait a bit anyway because I'm still working on parts of the theme and don't want to bother the admins with updated versions every 2 days.
For example, I'm thinking of making my very own iconset, not just copied&pasted icons from somewhere else

But what's wrong with the font filename?

anyway thanks for the cool theme 

You're welcome Again, I'm glad you (and many others) like it



@gevaerts: Looks like I got my hopes up too soon. Putting the %?mp<|%Vdc|%Vdd||||||> at the top of the theme causes the AA to disappear when changing the volume. I think the 15px clip was the lesser evil.

I'll play around with it some more. Maybe I'll find a solution myself


EDIT: I think it works now. I needed to put in yet another conditional viewport and another mp conditional:

Code: [Select]

%?mp<|%Vdh|%Vdd||||||>

######      Volume change pop up
#
%Vl|h|158|70|60|51|-|-|-|
%?mv1.5<%Vde%Vdf|%Vdg>
%Vl|e|100|60|120|67|-|-|-|
%xdI
%Vl|f|158|70|60|51|-|-|-|
Volume
%ac%pv

%Vl|g|46|0|228|200|-|-|-|

%?mp<|%Vdc|%Vdd||||||>


[Biont]

I uploaded the theme to the D2 site today, thanks again for your help.

Now I noticed it also shows up for the iPod Video since both have a 320x240 screen.
I don't want to stop iPod users from using my theme (it should work, right?), but I'd say it wouldn't make much sense to use a touchscreen theme on a non-touchscreen device. Maybe someone can do something about it (at least edit the description text) as this is sure to cause some confusion among iPod users

[Biont]

(@JdGordon)There were some changes in r23904.

Now the theme behaves strange when switching to the main menu and back. The prev/next and volume buttons don't disappear any more when going to the main menu and the song info doesn't appear when going back, as it seems. I guess this is due to those redraw thingies fixed.

Now before I start fixing the WPS code: Is this commit final? Or do you still work on that? I just want to ask because maybe that's unwanted behaviour and I'd be wasting my time trying to fix it.

[kugel.]

.

Now before I start fixing the WPS code: Is this commit final? Or do you still work on that? I just want to ask because maybe that's unwanted behaviour and I'd be wasting my time trying to fix it.

I wouldn't count on that. You better wait a week or 2 to let things settle a bit.

[Biont]

Okay...


I was just unsure since I don't know what exactly changed. Maybe this new behaviour is perfectly normal after the changes and I need to adapt to it.

[JdGordon]

(@JdGordon)There were some changes in r23904.

Now the theme behaves strange when switching to the main menu and back. The prev/next and volume buttons don't disappear any more when going to the main menu and the song info doesn't appear when going back, as it seems. I guess this is due to those redraw thingies fixed.

Now before I start fixing the WPS code: Is this commit final? Or do you still work on that? I just want to ask because maybe that's unwanted behaviour and I'd be wasting my time trying to fix it.

does your theme use the %we or %wd token? (which if yes)

[Biont]

I use the %we token

[JdGordon]

yeah, OK, I know whats happening... need do force clear the WPS on exit...

[Biont]

Okay cool.

So there's nothing to change on my side?

[JdGordon]

nope