Theme phkTAPE: Should the 'WORKS ON CURRENT BUILDS' modification work with 3.4

[ZonderP]

Hallo to all.
There is a quite old theme called 'phkTAPE' that I do call my favorite, since I'm rather old too!
It can be found here:
http://www.rockbox.org/wiki/WpsIpod5gGraveyard#phkTAPE
I used Rockbox 3.2 till some days ago with the modifications to the theme done by HumbertoSantana the 29th of September 2008 which can be downloaded at the bottom of the phkTAPE section under 'Download WORKS ON CURRENT BUILDS (This download: HumbertoSantana-- 29 Sep 2008)'
Now this theme doesn't work anymore (for me) -> 3 Questions:
a) Should it work?
b) What simple modifications could I make so that it works again?
c) Where could I download Rockbox 3.3 or 3.2, if there would not be any other chance to bring it to live again?

Thanks in advance,
Patrik

Edit: I forgot to mention on what device I use Rockbox on:
it's an IPod Video (5th gen) with 30 GB.

[GodEater]

Hi there - you shouldn't be downloaded themes from the themes Graveyard - it's called a graveyard for a reason - in that the themes there have all been abandoned.

[ZonderP]

Hi there - you shouldn't be downloaded themes from the themes Graveyard - it's called a graveyard for a reason - in that the themes there have all been abandoned.

Yes GodEater, I know that.
But so far (till at least version 3.2 - I didn't check it with version 3.3) everything was OK.

I just asked, if someone of the experts here could give me a hint on how i could make it work with 3.4, because I really do love this theme despite the fact that it's in the graveyard.
Or alternatively, where could I download 3.2 or 3.3. (Restoring from backup did not - for reasons I do not know - work for me.)

[evilnick]

a) It did work at the time it was submitted, but there have been LOTS of changes to the wps code since September 2008. So it's not surprising that it doesn't work in the current build a year later.
b) Check the customWPS page in the Wiki, and make any required changes to the wps file. This might not be all that simple though.
c) http://download.rockbox.org/old_releases/

[soap]

The reason it is in the graveyard is that there is not a clean license on the theme.

IF you could convince the original author to allow redistribution under a CC license...

[ZonderP]

...
c) http://download.rockbox.org/old_releases/

Yes thanks, though I found that already.
The newest of the old version I can find there is 2.5 dated 22th of September 2005!
That seems a bit too outdated for me...

No way to get 3.3 or 3.2?

The reason it is in the graveyard is that there is not a clean license on the theme.
IF you could convince the original author to allow redistribution under a CC license...

Yes, if only I found a way to contact him...

[perrikwp]

c) http://download.rockbox.org/old_releases/

Actually the link is http://download.rockbox.org/release/ for all current old releases (since 3.0).

[ZonderP]

Thanks a lot perrikwp!

You made my day!
I think I'll go the way to do without some of the newest feature in 3.4 in favor of being able to use this theme!

Edit:
Could not resist:

b) Check the customWPS page in the Wiki, and make any required changes to the wps file. This might not be all that simple though.

I tried that and with the help of the rockbox UI simulator started with enhanced debugging information I was able to find and fix the problem!

For anyone interested:
Change the line 54 in phkTAPEa.wps (phkTAPEb.wps, phkTAPEc.wps)
from
%?pv<%xdv|%xdw|%xdx|%xdy|%xdz|%xdA|%xdB|%xdC|%xdD|%xdD%xdE>
to
%?pv<%xdv|%xdw|%xdx|%xdy|%xdz|%xdA|%xdB|%xdC|%xdD|%xdD>

The parser seems to be more picky in the newest version (3.4).... since this looks like erroneous code from the beginning...

Thanks for helping me with this to all of you!

[audio-i]

Just for the record, I tried contacting the original author months ago (PHK Brasil) with no luck, in order to officially upload a working version of this theme, that also includes updates like a "left wheel winding - right wheel unwinding" effect, a nice album art thumbnail...

For now, I updated the .wps replacement files that allow the original theme to work (thanks ZonderP)

Hi there - you shouldn't be downloaded themes from the themes Graveyard - it's called a graveyard for a reason - in that the themes there have all been abandoned.

Right, they are abandoned and they don't have permissive licenses, which is a pity, but in my personal opinion, it's good and I thank that they can still be downloaded and modified, for personal use, theme making inspiration...

[ZonderP]

@audio-i:

Great - This way also other user  do benefit!

Thank you!