PHI Theme issue

[Greenish Apple]

I've downloaded the PHI theme for iPod and when I switch themes to it the screen gets darker (Brightness=1 instead of 3-4) and the Language for the menus changes to German! I had to go online to find the word for 'Language' in German, "Sprache".

To change it I choose Einstellunge (Settings), Grundeinstellungen (General), then Sprache (Language)

I checked the code in the .cfg file and it is set up this way:

#Theme Name: PHI-infoScreen
#By: PHI
#Platform: iPod Video (320x240x16) - standard build
wps: /.rockbox/wps/PHI-infoScreen.wps
font: /.rockbox/fonts/20-Terminus-Bold.fnt
foreground color: FFFFFF
background color: 5292DE
selector type: bar (gradient)
line selector start color: 6BB6FF
line selector end color: 080063
line selector text color: FFFFFF
statusbar off
backlight timeout: on
brightness: 1
backdrop: /.rockbox/backdrops/PHI-infoScreen.bmp
filetype colours: /.rockbox/themes/PHI-infoScreen.colours
lang: /.rockbox/langs/deutsch.lng

So I plugged in the iPod to my MacBook, fired up Invisibility Toggler, found the cfg file for PHI and used TextWrangler to change the brightness and lang settings on my iPod. (3 and English)

David

[karashata]

You could just remove those settings from the theme's config file and it would leave them set at what you have them set to, as well. It may be a good idea to give the theme's author a poke and get him or her to remove those lines as they really shouldn't be in there anyway.

[Greenish Apple]

I'd like to but I'm not sure how to contact "H. Philippi"

David

[saratoga]

You could probably ask on IRC during the day in Europe or the US and get one of the theme site admins to upload the fixed theme to the site.  Its clearly a mistake so I don't think they'll mind changing it.

[soap]

Should the validation script allow language to be set in a theme?

[Llorean]

One could argue that "language" is a theme option (especially if the theme includes hard-coded text in a certain language, or graphics with text in a certain language).

Once could also argue that it's not a theme option, or at the very least, should not be able to change the language from the user preference.

Personally, I don't think themes should be allowed to change the language.