Rockbox.org home
Downloads
Release release
Dev builds dev builds
Extras extras
themes themes
Documentation
Manual manual
Wiki wiki
Device Status device status
Support
Forums forums
Mailing lists mailing lists
IRC IRC
Development
Bugs bugs
Patches patches
Dev Guide dev guide
Search



Donate

Rockbox Technical Forums


Login with username, password and session length
Home Help Search Staff List Login Register
News:

Thank You for your continued support and contributions!

+  Rockbox Technical Forums
|-+  Support and General Use
| |-+  Theming and Appearance Customization
| | |-+  AlbumArt Rendering Changed Recently?
« previous next »
  • Print
Pages: 1 [2] 3

Author Topic: AlbumArt Rendering Changed Recently?  (Read 8429 times)

Offline moonscapex

  • Artist
  • Member
  • *
  • Posts: 75
  • Linux User - 5 Rockbox Installs
    • MoonscapeX's Build
Re: AlbumArt Rendering Changed Recently?
« Reply #15 on: October 06, 2009, 09:55:37 PM »
So, is the code put back now?[color=][/color]
Logged
MoonscapeX's Build Sansa E200 (v2)   //\\  //\\oonscapeX
Rockbox Album Art Downloader          //  \\//  \\@gmail.com

Offline JdGordon

  • Member
  • *
  • Posts: 1817
  • Constantly breaking stuff
Re: AlbumArt Rendering Changed Recently?
« Reply #16 on: October 07, 2009, 01:40:12 AM »
do your themes work again? and stop trying to put colour into your messages... you're not doing it right... and if you figure it out you will very likely annoy people
Logged


Using PMs to annoy devs about bugs/patches is not a good way to have the issue looked at.

Offline JdGordon

  • Member
  • *
  • Posts: 1817
  • Constantly breaking stuff
Re: AlbumArt Rendering Changed Recently?
« Reply #17 on: October 07, 2009, 02:39:17 AM »
NorTheBear: hmm... ok well I have 2 fixes, I'm not sure which is better...
1) change the %xl|.... lines for the corner images to just %x|... and it works...
2) draw the AA before the regular images (I'm not sure why the order matters but apparently it does :< )
edit: 3) make the %x tag dynamic works also...

I'm going to keep trying to find a more proper solution, but until then the first option works.
Although, because those images are always shown anyway you should be using %x instead of %xl
« Last Edit: October 07, 2009, 02:43:24 AM by JdGordon »
Logged


Using PMs to annoy devs about bugs/patches is not a good way to have the issue looked at.

Offline JdGordon

  • Member
  • *
  • Posts: 1817
  • Constantly breaking stuff
Re: AlbumArt Rendering Changed Recently?
« Reply #18 on: October 07, 2009, 03:04:46 AM »
OK... I've decided that its your .wps which is broken and not the code at all....
you are drawing the corners using the xd tag which is not needed because you want them to always be displayed...

Code: [Select]
%X|bg.2009.round.simple.wd.v7.bmp|
%x|c|bcorner.10x10.lo.bmp|34|12|
%x|d|bcorner.10x10.ro.bmp|176|12|
%x|e|bcorner.10x10.ru.bmp|176|154|
%x|f|bcorner.10x10.lu.bmp|34|154|
%x|a|ppcorner.8x14.lo.bmp|50|103|
%x|b|ppcorner.8x14.ro.bmp|162|103|
%x|g|ppcorner.8x14.lu.bmp|50|138|
%x|h|ppcorner.8x14.ru.bmp|162|138|
%xl|i|arrows.25x25x3.redgold.bmp|0|0|3|
%xl|j|volume.25x25x14.ol.var4.bmp|0|0|18|
%xl|k|volume.25x25x14.or.var4.bmp|0|0|18|
%xl|P|playmode.flcr.27x27x6.bmp|0|0|6|
%Cl|35|13|150|150|
%wd
%C
#%?pn<%xda|%xdl>
is how the first part should look...
Logged


Using PMs to annoy devs about bugs/patches is not a good way to have the issue looked at.

Offline NorTheBear

  • Member
  • *
  • Posts: 33
Re: AlbumArt Rendering Changed Recently?
« Reply #19 on: October 07, 2009, 05:25:05 AM »
Thank you for your time and your looking into it.
I have tried your suggestion (by copying and replacing the code above) and indeed, it's better now but the rendering is not as smooth as it was in RB 3.3 (and before). For a fractal of a second but clearly noticeable you can see the corners of the AA before the small images cover them. The flicker is visible with every new track change thus giving the WPS an uneasy and unsteady touch. I also did a crosscheck with the same WPS in RB 3.3: No flicker there.
Too bad for me because the theme had been working so nice in the past.
Logged

Offline JdGordon

  • Member
  • *
  • Posts: 1817
  • Constantly breaking stuff
Re: AlbumArt Rendering Changed Recently?
« Reply #20 on: October 07, 2009, 05:34:02 AM »
yeah, I'm not going to worry about that very small flicker... the bigger issue is what happens after 100s (which I'm not going to spend much/any time on now either)
Logged


Using PMs to annoy devs about bugs/patches is not a good way to have the issue looked at.

Offline NorTheBear

  • Member
  • *
  • Posts: 33
Re: AlbumArt Rendering Changed Recently?
« Reply #21 on: October 08, 2009, 07:12:34 AM »
Thank you very much for your help so far.
I can certainly live with the flicker at the beginning of each track, no problem at all.

But now I see what you mean with
Quote
... the bigger issue is what happens after 100s ...
There is a rendering problem at another position (circled in screenshot) that started after 1:40 min of playing. It seems as if 2 viewports (overlaying the AA) imploded out of a sudden.
This never happened before in version 3.3.

The WPS code snippet is here.
Some explanation: The viewports overlay the AA. The viewports without any content are only there for freeing parts of the background image. This worked perfect in the past.
Code: [Select]
#Title
%V|1|117|218|2|0|-|-|
%V|1|119|218|19|1|CCCCCC|000000|
%s%ac%?it<%it|%fn>
#UPPERLINE
%V|58|103|104|4|0|CCCCCC|FF00FF|
%V|58|107|104|13|0|CCCCCC|FF00FF|
%s%ac%?ia<%ia|[unknown artist]>
#BOTTOMLINE
%V|58|138|104|3|0|CCCCCC|FF00FF|
%V|58|141|104|11|0|CCCCCC|FF00FF|
%s%ac%?pn<%pn|%?id<%id|%?d1<%d1|unknown album>>>

* dump 091008-130159.PNG (20.09 kB, 460x200 - viewed 279 times.)
Logged

Offline NorTheBear

  • Member
  • *
  • Posts: 33
Re: AlbumArt Rendering Changed Recently?
« Reply #22 on: October 12, 2009, 12:11:33 PM »
In the meantime I have adjusted (downgraded) my custom wps so that it copes with the new conditions in the current builds (see screenshot).
Don't know if it is worth to put it on the themes page as it has only poor design elements (circles and lines) and overlay design is not really supported yet.

* banderole.v1.PNG (35.04 kB, 273x231 - viewed 273 times.)
Logged

Offline JdGordon

  • Member
  • *
  • Posts: 1817
  • Constantly breaking stuff
Re: AlbumArt Rendering Changed Recently?
« Reply #23 on: October 12, 2009, 03:33:14 PM »
I found the bug and will checking the fox in the next few hours
Logged


Using PMs to annoy devs about bugs/patches is not a good way to have the issue looked at.

Offline NorTheBear

  • Member
  • *
  • Posts: 33
Re: AlbumArt Rendering Changed Recently?
« Reply #24 on: October 16, 2009, 07:09:55 AM »
Thanks a lot for your bug fixing in r23140. It solved the problem with the "imploding" viewports after 100 seconds (though the flicker issue remains).

I will give my theme some final polishing and would like to upload it on the themes page. Could you (or someone else reading this) give me write permission (still necessary, right)? Of course,  I will read and follow the guidelines.
Logged

Offline mc2739

  • Developer
  • Member
  • *
  • Posts: 262
Re: AlbumArt Rendering Changed Recently?
« Reply #25 on: October 16, 2009, 07:22:51 AM »
The themes are no longer uploaded to the wiki, so you don't need write permission.

To upload your theme, click the "themes" links in the left column and follow the directions at the top of that page.
Logged

Offline NorTheBear

  • Member
  • *
  • Posts: 33
Re: AlbumArt Rendering Changed Recently?
« Reply #26 on: October 16, 2009, 10:13:04 AM »
I see ...  another question: it seems as if I have to upload the same theme twice, i.e. for H300 and then for ipod color photo which have the same display size and orientation, correct?
Logged

Offline audio-i

  • Artist
  • Member
  • *
  • Posts: 266
Re: AlbumArt Rendering Changed Recently?
« Reply #27 on: October 16, 2009, 10:49:40 AM »
If the targets have the same screen size and display (color/b&w), only one upload should be necessary. But of course you will figure it out once you upload the "first" one.
Logged

Offline pixelma

  • Rockbox Expert
  • Member
  • *
  • Posts: 645
Re: AlbumArt Rendering Changed Recently?
« Reply #28 on: October 18, 2009, 01:34:41 PM »
I'm not completely sure but I think that there is an exception to the rule above if your theme includes an RWPS (for the H300 remote). You would need to upload it twice - one with and the other without the RWPS part, a theme with RWPS won't show up on the Ipod Color/Photo (and Fuze) page, if I remember correctly.
Logged

Offline NorTheBear

  • Member
  • *
  • Posts: 33
Re: AlbumArt Rendering Changed Recently? => new theme "Lower Thirds"
« Reply #29 on: October 28, 2009, 06:20:26 AM »
Yesterday, I tried to upload my theme (Lower Thirds) but I haven't got a confirmation email yet and it does not show up on the themes page. What did I wrong?

EDIT: Sorry, found the email in the spam suspicion  folder. Now the theme "Lower Thirds" is available for all 220x176 color targets. Any comments and suggestions?
« Last Edit: October 28, 2009, 09:40:49 AM by NorTheBear »
Logged

  • Print
Pages: 1 [2] 3
« previous next »
+  Rockbox Technical Forums
|-+  Support and General Use
| |-+  Theming and Appearance Customization
| | |-+  AlbumArt Rendering Changed Recently?
 

  • SMF 2.0.17 | SMF © 2019, Simple Machines
  • Rockbox Privacy Policy
  • XHTML
  • RSS
  • WAP2

Page created in 0.104 seconds with 15 queries.