Rockbox.org home
Downloads
Release release
Dev builds dev builds
Extras extras
themes themes
Documentation
Manual manual
Wiki wiki
Device Status device status
Support
Forums forums
Mailing lists mailing lists
IRC IRC
Development
Bugs bugs
Patches patches
Dev Guide dev guide
Search



Donate

Rockbox Technical Forums


Login with username, password and session length
Home Help Search Staff List Login Register
News:

Welcome to the Rockbox Technical Forums!

+  Rockbox Technical Forums
|-+  Support and General Use
| |-+  Theming and Appearance Customization
| | |-+  Make your skins non-english friendly!
« previous next »
  • Print
Pages: [1]

Author Topic: Make your skins non-english friendly!  (Read 5547 times)

Offline JdGordon

  • Member
  • *
  • Posts: 1817
  • Constantly breaking stuff
Make your skins non-english friendly!
« on: September 25, 2009, 09:03:52 PM »
I've just commited a new skin token which lets you display translated strings on the skins.
Alot of themes currently do something like "Artist: %iA" which is fine if you speak english, but crap if you dont... so please start using this new token...

use "%Sx|[Artist]|: %iA" instead :)

I might be persuaded to add another token so the []'s can be stripped.

every string in english.lang can be used, so if one fits where you would have used a plain string, use this.
« Last Edit: January 31, 2010, 11:51:48 PM by JdGordon »
Logged


Using PMs to annoy devs about bugs/patches is not a good way to have the issue looked at.

Offline yapper

  • Rockbox Expert
  • Member
  • *
  • Posts: 794
Re: Make your WPS non-english friendly!
« Reply #1 on: September 26, 2009, 11:40:43 AM »
Cool - good work!
Logged
G2 iPod 20GB / Sansa c240 v1 + 2GB microSD / Sansa c250 v1 / Sansa e250 v1 + 8GB microSDHC / Sansa Fuze v2 + 32GB microSDHC

Offline kugel.

  • Developer
  • Member
  • *
  • Posts: 271
Re: Make your WPS non-english friendly!
« Reply #2 on: October 29, 2009, 10:41:59 AM »
Quote from: JdGordon on September 25, 2009, 09:03:52 PM
I might be persuaded to add another token so the []'s can be stripped.

No need for that. Those are only used in the id3 screen as of now. The [ ] can be generated at runtime, so fixing the langs to not have them is possible (I talked to rasher, everything should be fine).


EDIT: Done in SVN now. Note that you need %Sx|Artist| instead of %Sx|[Artist]| now (you can get the old effect with [%Sx|Artist|] if you wanted to).
« Last Edit: October 31, 2009, 10:28:16 AM by kugel. »
Logged
 

Offline seani

  • Member
  • *
  • Posts: 122
    • they call me MR sean
Re: Make your WPS non-english friendly!
« Reply #3 on: November 11, 2009, 02:55:16 PM »
If I'm including plain text - "Artist Unknown" - in a conditional - %?ia<%ia|Artist Unknown> how do I "nest" this with the new language neutral format?
Logged
Sansa C240, Sansa E280, Clip

Offline JdGordon

  • Member
  • *
  • Posts: 1817
  • Constantly breaking stuff
Re: Make your WPS non-english friendly!
« Reply #4 on: November 11, 2009, 03:01:19 PM »
you cant translate arbitrary text, it has to be text which is already in the language files.
%?ia<%ia|%Sx|Artist Unknown|>  would work *if* "Artist Unknown" is a translated string already.
Logged


Using PMs to annoy devs about bugs/patches is not a good way to have the issue looked at.

Offline seani

  • Member
  • *
  • Posts: 122
    • they call me MR sean
Re: Make your WPS non-english friendly!
« Reply #5 on: November 11, 2009, 03:04:08 PM »
Quote from: JdGordon on November 11, 2009, 03:01:19 PM
you cant translate arbitrary text, it has to be text which is already in the language files.
%?ia<%ia|%Sx|Artist Unknown|>  would work *if* "Artist Unknown" is a translated string already.

Understood, so I could tradeoff a longer description for something that would translate:

%?ia<%ia|%Sx|Artist|??>

or live with a partial translation:

%?ia<%ia|%Sx|Artist| Unknown>

?


ETA

Just to be clear, in the above examples, for German, I'd expect to see:

"Künstler??" and "Künstler Unknown"


as an approximation. Of course leaving a bit untranslated might be more confusion - the word order might be different natively etc.
« Last Edit: November 11, 2009, 03:11:51 PM by seani »
Logged
Sansa C240, Sansa E280, Clip

Offline JdGordon

  • Member
  • *
  • Posts: 1817
  • Constantly breaking stuff
Re: Make your WPS non-english friendly!
« Reply #6 on: November 11, 2009, 03:10:00 PM »
The first seems better... add a ": " before the ??'s though :)
Logged


Using PMs to annoy devs about bugs/patches is not a good way to have the issue looked at.

Offline seani

  • Member
  • *
  • Posts: 122
    • they call me MR sean
Re: Make your WPS non-english friendly!
« Reply #7 on: November 11, 2009, 03:14:48 PM »
I get you, thanks.

Does this also apply to multi-value conditionals, like %mp  ?


ETA:

pixelma also says there's an "UNKNOWN" translation.

So combining both, if I style it as "Artist: UNKNOWN" as opposed to the phrase "Unknown Artist" it should look natural.

In this particular case it's only where an ID3 tag is missing that I display the "Artist:" or "Title:" prompt. Where the tag is present, I just display the tag value.
« Last Edit: November 11, 2009, 03:20:58 PM by seani »
Logged
Sansa C240, Sansa E280, Clip

Offline JdGordon

  • Member
  • *
  • Posts: 1817
  • Constantly breaking stuff
Re: Make your WPS non-english friendly!
« Reply #8 on: November 11, 2009, 03:20:00 PM »
please dont edit posts after someone has already replied (I think you've been asked before?)

yes, you can put that tag anywhere any other tag can go
Logged


Using PMs to annoy devs about bugs/patches is not a good way to have the issue looked at.

Offline seani

  • Member
  • *
  • Posts: 122
    • they call me MR sean
Re: Make your WPS non-english friendly!
« Reply #9 on: November 11, 2009, 03:22:59 PM »
Thanks.

Possibly, but I have no way of knowing when they cross. My edit was started before your reply was posted, or at least visible to me.
Logged
Sansa C240, Sansa E280, Clip

Offline AlexP

  • Global Moderator
  • Member
  • *
  • Posts: 3688
  • ex-BigBambi
Re: Make your WPS non-english friendly!
« Reply #10 on: November 13, 2009, 07:29:46 AM »
Quote from: seani on November 11, 2009, 03:22:59 PM
Thanks.

Possibly, but I have no way of knowing when they cross. My edit was started before your reply was posted, or at least visible to me.

The forum software should warn you about this I think, unless you have turned off the "Don't warn on new replies made while posting." option.
Logged
H140, F60, S120, e260, c240, Clip, Fuze v2, Connect, MP170, Meizu M3, Nano 1G, Android

Offline seani

  • Member
  • *
  • Posts: 122
    • they call me MR sean
Re: Make your WPS non-english friendly!
« Reply #11 on: November 13, 2009, 08:06:19 AM »
Hmmm.

The setting:

" Don't warn on new replies made while posting."

is unticked in my profile, which as I read it should mean I *do* get warnings, but I'm not aware of having seen any. Not to say I couldn't have clicked through on autopilot flicking between irc and the forum. I'll keep an eye open in any case.
Logged
Sansa C240, Sansa E280, Clip

Offline Llorean

  • Member
  • *
  • Posts: 12931
Re: Make your WPS non-english friendly!
« Reply #12 on: November 13, 2009, 08:09:58 AM »
I'm not certain that option works with edits. I think it may work only with actual posts.

Generally speaking, it's better to try to avoid needing to edit by getting as much information as you can before posting.

Also, what does "ETA" mean? It's not in the list of project / related acronyms so generally we'd ask that you don't use it and try to use whole words.
Logged

Offline seani

  • Member
  • *
  • Posts: 122
    • they call me MR sean
Re: Make your WPS non-english friendly!
« Reply #13 on: November 13, 2009, 08:24:56 AM »
ETA = Edited To Add - it's a convention on another forum I frequent to make the change explicit, but point taken.


As far as the actual edits are concerned, the first was a response to the number of question marks in the example WPS setting that, although "correct", I thought may have made it difficult to parse (by humans)

The second was to add pertinent information from IRC that I didn't have when the post was made.

Generally I was a caught out by the unexpected speed of the responses, I'll bear all these points in mind for next time, ta.
Logged
Sansa C240, Sansa E280, Clip

  • Print
Pages: [1]
« previous next »
+  Rockbox Technical Forums
|-+  Support and General Use
| |-+  Theming and Appearance Customization
| | |-+  Make your skins non-english friendly!
 

  • SMF 2.0.17 | SMF © 2019, Simple Machines
  • Rockbox Privacy Policy
  • XHTML
  • RSS
  • WAP2

Page created in 0.101 seconds with 14 queries.