Support and General Use > User Interface and Voice

viewing Arabic text

<< < (3/3)

amr:
This issue is general that is related to the firmware code (mainly lcd-xxx.c, arabjoin.c, bidi.c) , so it has nothing to do with the text viewer plugin.

To the admin: I suggest moving this topic to the WPS and Appearance forum

markun:
I would have moved this to "User Interface and Voice" where we usually put codepage and language issues, but ok.

I'm the guy who wrote arabjoin. Are there combined glyphs for these characters with diacritics in the fonts or do we have to combine the images ourselves? My guess is the latter. If someone would implement glyph combining then we could also finally fix Thai rendering.

And I don't know about using pango in rockbox. It sounds like overkill.

amr:
For Arabic, we have to combine glyphs of the diacritics - that are called non-spacing combining marks - with the characters glyphs ourselves. Those marks take zero-space where they are placed above or under the letters they follow in the sequence, and their position in the characters sequence shouldn't affect the letters shaping and joining... So, I guess that arabjoin.c and bidi.c would be kept intact, and all the changes would be made in lcd-xxx.c

When I contacted HarfBuzz's developer - the rendering engine of pango - he agreed that it'd be difficult to use the code directly in rockbox.

it makes sense for the post to be under "user interface" indeed, I was confused about classifying it as I didn't find a topic that's directly related to "firmware"

tomers:
Just to let you all know that Phinitnun Chanasabaeng (crackerizer) and me are working on a resolution for this issue:

FS#10720 - diacritic positioning patch
http://www.rockbox.org/tracker/task/10720

I've also added support for RTL languages (Hebrew and Arabic). The latest patch there already solves this issue (you can use it now), but the code is still a work-in-progress, and being revised before committing.

Tomer

tomers:
FS#10720 (diacritic positioning patch) was committed in revision 23742. This issue should now be solved.
Please provide feedback, as to whether things work for you now.

Thanks,
Tomer

Navigation

[0] Message Index

[*] Previous page