X5 Clix Black & White 3.3

[madcow]

Hi!

I remade 'my' clix black & white theme for rockbox 3.3 and However it is pretty neat (imo) and usable now I still got 2 things that I can't figure out.

Image of the old version:

File of the new version:
http://www.rockbox.org/twiki/bin/viewfile/Main/WpsIaudioX5Graveyard?rev=1;filename=Clix_Black_%28normal__negative_3.3.rar

-The battery-icon should flicker/change while charging & when it's almost empty.
During the building process it worked for a while but now not any more.
When I put the charger in or when the battery runs dry it will function as desired but only once (one flicker/change and then that's it.

-At the down right corner the playlist-info part preferably needs to scroll but when "%s" is added the info won't change while hold is enabled.


My guess is that it has something to do with the viewports..

Could you guys look a bit into the code?

Code: [Select]

# Clix theme by MrMEC for iAudio X5
# Based on jClix by PIJulius for iPod 5G
%X|bground.bmp|
%xl|A|batt1.bmp|134|0|
%xl|B|batt2.bmp|134|0|
%xl|C|batt3.bmp|134|0|
%xl|D|batt4.bmp|134|0|
%xl|E|batt5.bmp|134|0|
%xl|F|battc.bmp|134|0|
%xl|G|shuffle.bmp|89|0|
%xl|H|hold.bmp|121|0|
%xl|I|hdd.bmp|106|0|
%xl|J|play.bmp|3|0|
%xl|K|pause.bmp|3|0|
%xl|L|forward.bmp|3|0|
%xl|M|rewind.bmp|0|0|
%xl|f|vol00.bmp|73|2|
%xl|g|vol01.bmp|73|2|
%xl|h|vol02.bmp|73|2|
%xl|i|vol03.bmp|73|2|
%xl|j|vol04.bmp|73|2|
%xl|k|vol05.bmp|73|2|
%xl|l|vol06.bmp|73|2|
%xl|m|vol07.bmp|73|2|
%xl|n|vol08.bmp|73|2|
%xl|o|vol09.bmp|73|2|
%xl|p|vol10.bmp|73|2|
%wd
%pb|pbar.bmp|48|83|67|-|
%?C<%C%Vdb%Vdc|%Vda%Vdd>
%t1 %?bp<%xdF|%?bl<|%xdA|%xdB|%xdC|%xdD|%xdE>>;%t1 %?bp<%xdA|%?bl<||%xdB|%xdC|%xdD|%xdE>>
%?pv<%xdf|%xdg|%xdh|%xdi|%xdj|%xdk|%xdl|%xdm|%xdn|%xdo|%xdp>
%?lh<%xdI|>
%?mh<%xdH|>
%?ps<%xdG|>
%V|1|3|71|-|0|CECFCE|-|
%t10%s%al%?mh<Battery:%bl%% = %bt|%cH:%cM>;%t10%s%al%?mh<Battery:%bl%% = %bt|%cm/%ce>
%V|68|10|18|-|0|B5BAB5|-|
%?mv<%ar%pv|>

%Vl|a|11|24|140|-|1|-|-|
%al%s%?ia<%ia|%fn>
%al%s%?it<%it|%?ia<%fn|>>
%Vl|b|68|24|90|-|1|-|-|
%al%s%?ia<%ia|%fn>
%al%s%?it<%it|%?ia<%fn|>>
%Vl|c|68|60|90|-|0|E7E3E7|-|
%al%s%?id<%id|%d1>
%Vl|d|11|60|140|-|0|E7E3E7|-|
%al%s%?id<%id|%d1>
%V|6|82|36|-|0|B5BAB5|-|
%ar%pc
%V|120|82|37|-|0|B5BAB5|-|
%al%pt
%V|11|100|145|-|0|CECFCE|-|
%t5%al%s%?mh<Playcount: %rp Rating: %rr Autoscore: %ra|%?Fn<Next: %?Ia<%Ia|%Fn>>>;%t5%al%s%?mh<%?rg<Playcount: %rp Rating: %rr Autoscore: %ra|Replaygain: Track @ %rg|Replaygain: Album @ %rg|Replaygain: Track @ %rg|Replaygain: Album @ %rg|Playcount: %rp Rating: %rr Autoscore: %ra>|%?Fn<Next: %?It<%It|%Fn>>>

%V|1|118|71|-|0|CECFCE|-|
%t5%al%?mh<%fc @ %fbKb/s %?fv<(var)|(cst)> = %fsKb|%?iy<%iy|%ig>>;%t5%al%s%?mh<%fc @ %fbKb/s %?fv<(var)|(cst)> = %fsKb|%?ig<%ig|%iy>>
%V|87|118|70|-|0|CECFCE|-|
%ar%?mh<%?pn<%pn|%?d1<%d1|%pp of %pe>>|%pp of %pe>
%V|74|118|13|-|0|-|-|
%t1 %?mp<%xdK|%xdJ|%xdK|%xdL|%xdM>;%t0.5 %?mp<%xdK|%xdJ|||>

%Cl|11|24|53|53|

Ps. I can't make quick modifications because I'm away for a short trip but I would nonetheless appreciate your help and change things when I'm back.

[BdN3504]

Edit: I decided to keep the thread tidy, so i attached the wps files instead of posting the code.
Rename extensions to bmp and put them into the respective folders.
I don't know if the charger conditional works, because nobody on IRC told me how to check that on the sim, so you might want to check it out yourself on target and the report back if it works. if not we'll work something out!

[audio-i]

As it is now, it seems it might blink when plugged and not only when it's charging. I've achieved the blinking effect when charging using the %bc tag http://www.rockbox.org/twiki/bin/view/Main/CustomWPS#Power_Related_Information but it only works for "targets that have software charge control or monitoring" and I don't know if that's the case for you. If it is, and you want to check it out, you can take a look at the AW200 theme for ipod video (or arboxWidgets, SpartanBlack...)

[BdN3504]

it now definitely blinks, when the battery is lower than 18% (or somewhere around that percentage) in my version. doesn't charging require being plugged? so this means it'll also blink when it's charging. but in the end replacing %?bp with %?bp<%?bc<|>|> isn't such a difficult task...

[audio-i]

...doesn't charging require being plugged? so this means it'll also blink when it's charging

a device can be plugged but NOT charging, so making it blink all the time it is plugged won't achieve what madcow seems to want:

-The battery-icon should flicker/change while charging

that's what the %?bc tag is for

[soap]

Why are new files being attached to the Graveyard wiki page?
The page which states ""If you are the original author of one of the themes found below you are free to clearly license your theme, ensure it meets the ThemeGuidelines, and then move it to the appropriate WpsGallery page. "

Since the new theme site is up, please either license your theme permissively and put it there, or cease to use Rockbox servers as a distribution method.

[madcow]

Sorry, my apologies.
I wanted to upload it before my vacation and didn't had the time to properly get it online nor to read the terms.
I''ll delete it if it's still there.

on topic:
Thanks BdN3504 for your time.
Your solution works and I actually used this way in my earlier themes (rockbox 2.0)
However it doesn't seems to be neccesary to do it this way since it did work for a while with the exact same 'battery-line-code' I aplied above.
Thanks!

Edit: Tried to delete it myself but I'm not able to do such things.

[pixelma]

I think the main problem is that you draw into the main viewport (the full screen so to speak) even though you use other viewports. This could explain the update problems you have since these are basically overlapping viewports which isn't allowed and will cause trouble for updating things. BdN3504's version doesn't seem to fix this so I'm wondering if that one is a hundred percent bug free...

To fix this, I would try putting everything below the %wd tag to the first %V tag into an own viewport (and make sure that there are no overlapping ones!). This might mean changing some coordinates because the placement is relative to the upper left corner of the viewport they are in - for images the %xd tag counts - as the CustomWPS wiki page says. It could also be that you need more than one viewport to not have overlapping areas, haven't checked that closely. Maybe this will also fix the scrolling line problem, although there is a general problem with dynamic content on scrolling lines, so volume or playback time doesn't work on scrolling lines but I would expect playlist info to be ok since it only changes once per track (haven't tried though).

And finally a suggestion: for the battery level, playback state and volume images I would use a bitmap strip each, you'll get fewer files in the WPS folder hence shorter loading time, easier to read code (e.g. you only need to change one coordinate definition).

Edit: corrected the tag mentioned ("below %wd", not "below %pb") as the progressbar should of course be included in it so that nothing is drawn outside specified viewports.

[madcow]

Kay thanks for the suggestions but I guess we'll see how long it works this way and when it gets really broken again due to Rockbox changes then I'll fix it properly.

For now some simpel changes
Just some improvements and added clix blackred to it as well.
-battery flickers when empty
-better numeric volume positioning
-cleaner hold info

Maybe I'll add some more of the clixes but if you guys want to do it yourself feel free to do and modify all you want.


-Currently the only problem is that the remaining battery time is displayed wrong but I think that's Rockbox fault

I'm putting it on some hosting site and 'll try to keep it alive but when it's taken down let me know and I'll re-upload again.
http://www18.zippyshare.com/v/65157801/file.html

[madcow]

It's a modification of a ported theme so I don't believe I've got the rights.
Too much of a hassle to figure that all out.
Also I don't think it's perfect yet..

[Llorean]

If you don't have the rights, you shouldn't be posting a link to it here either.

There's no such thing as "too much of a hassle to figure it all out." We don't want copyright infringement here, just like we don't want it on the theme site.

[AlexP]

So what is the situation with the licence?  As Llorean says, if you don't have the right to distribute it then the link to it from here has to go too.