Question about plugin modification

[esc861]

Hello,

I've been using rockbox for a while but am new to the development community.  I was playing spacerocks and kept getting overwhelmed by rocks after I re-spawned, so I decided I would modify it to have a short period of invulnerability after a re-spawn.  I checked out rockbox from SVN, made my changes and built everything and my modifications to the plugin worked great.

Now my question is, is this something that I should get committed back into the repository and if so how?  It's not really a bug-fix, but just something I thought was helpful.  Is it kosher to modify something like this?

[froggyman]

you could probaly create a .patch / .diff of it and upload it to the FlySpray.

[cool_walking_]

Yeah, just post it on the tracker.  If it's good it'll get committed.  If the code has some problems, people will point them out or fix them themselves.  If the feature is unwanted, the patch will be rejected - no harm done.  If the feature is controversial there'll be arguments in IRC probably lasting for months.  If it doesn't get accepted/rejected/commented on after a while, go into IRC and poke the lazy devs.

[esc861]

Ok, great.  I posted the patch on flyspray.  Thanks for your help guys.

[saratoga]

Thanks for the excellent patch.  Feel free to improve anything else you dislike

[cool_walking_]

Shouldn't his name be added to the header in the source file?  (I guess the CREDITS file is only for regular committers?)

[saratoga]

The header is whoever created the file.  I should have put him in the CREDITS file though.