Rockbox.org home
Downloads
Release release
Dev builds dev builds
Extras extras
themes themes
Documentation
Manual manual
Wiki wiki
Device Status device status
Support
Forums forums
Mailing lists mailing lists
IRC IRC
Development
Bugs bugs
Patches patches
Dev Guide dev guide
Search



Donate

Rockbox Technical Forums


Login with username, password and session length
Home Help Search Staff List Login Register
News:

Welcome to the Rockbox Technical Forums!

+  Rockbox Technical Forums
|-+  Rockbox Development
| |-+  Feature Ideas
| | |-+  "Automatically adjust clock for daylight saving changes" option
« previous next »
  • Print
Pages: [1] 2

Author Topic: "Automatically adjust clock for daylight saving changes" option  (Read 9197 times)

Offline zaphee

  • Member
  • *
  • Posts: 44
  • mrjl@xmppnet.de
"Automatically adjust clock for daylight saving changes" option
« on: March 29, 2009, 09:19:10 AM »
Hi.
This morning I saw that my nano didn't adjust clock for summer time.
I know that this option is useful only twice a year, but it would be nice that Rockbox could automatically adjust clock for summer time.
« Last Edit: March 29, 2009, 01:51:09 PM by zaphee »
Logged
iPod nano (1-st gen. ; 4GB)
Sandisk sansa Clip+ (2GB)
Android 4.0 tablet

Offline roolku

  • Developer
  • Member
  • *
  • Posts: 350
Re: "Automatically adjust clock for daylight saving changes" option
« Reply #1 on: March 29, 2009, 04:12:48 PM »
I concur. It is especially bad if you have several targets.

amiconn proposed a way to implement it the last time it happened, but I fear the idea has fallen by the wayside.
Logged

Offline JdGordon

  • Member
  • *
  • Posts: 1817
  • Constantly breaking stuff
Re: "Automatically adjust clock for daylight saving changes" option
« Reply #2 on: March 29, 2009, 11:57:09 PM »
this come up twice a year and then dies very quickly :)

its easy to do, but its also easier to just change the clock than to code the patch and commit it :)
Logged


Using PMs to annoy devs about bugs/patches is not a good way to have the issue looked at.

Offline safetydan

  • Developer
  • Member
  • *
  • Posts: 248
Re: "Automatically adjust clock for daylight saving changes" option
« Reply #3 on: March 30, 2009, 12:08:46 AM »
The only way this could work is if you included a time zone database and a setting to set the user's current location. Then you'd have to ensure the time zone database is kept up to date with all the crazy changes that happen to time zone rules.
Logged

Offline JdGordon

  • Member
  • *
  • Posts: 1817
  • Constantly breaking stuff
Re: "Automatically adjust clock for daylight saving changes" option
« Reply #4 on: March 30, 2009, 12:14:34 AM »
my feeling is that all it needs is a setting "winter time", "DST+1h", "DST+2h" which should cover everything and not need anything be kept up dated... but its hardly worth the effort
Logged


Using PMs to annoy devs about bugs/patches is not a good way to have the issue looked at.

Offline Llorean

  • Member
  • *
  • Posts: 12931
Re: "Automatically adjust clock for daylight saving changes" option
« Reply #5 on: March 30, 2009, 04:22:49 AM »
Instead of including a time zone database, it seems like you could simply have two options, one of "DST begin date" and "DST end date." I don't know if internationally DST is always one hour, assuming it is, that's enough. If it's not, a third option "DST time offset" would handle the rest (or, to make the overall option more flexible, you could rename them so that a person could have their clock 'auto adjust' for a trip they're taking to a different time zone if they planned ahead).
Logged

Offline Febs

  • Member
  • *
  • Posts: 2701
Re: "Automatically adjust clock for daylight saving changes" option
« Reply #6 on: March 30, 2009, 09:03:54 AM »
Bear in mind that there are some places (Arizona, for example) that do not observe Daylight Savings Time, so there would need to be a setting to turn off DST adjustment entirely.
Logged
Rockbox Forum Guidelines
The Rockbox Manual
How to Ask Questions the Smart Way
Please do not send me support questions via PM.

Offline Genre9mp3

  • Artist
  • Member
  • *
  • Posts: 146
Re: "Automatically adjust clock for daylight saving changes" option
« Reply #7 on: March 30, 2009, 04:20:10 PM »
Quote from: Llorean on March 30, 2009, 04:22:49 AM
Instead of including a time zone database, it seems like you could simply have two options, one of "DST begin date" and "DST end date."

That would be a bit pointless though because DST rules don't set specific dates but have rules like "Start: Last Sunday in March - End: Last Sunday in October". This would require the user to calculate the dates every year which would be far more complex than just adjusting the time manually.

Quote from: Llorean on March 30, 2009, 04:22:49 AM
I don't know if internationally DST is always one hour

It's indeed one hour for every country that uses the DST system.

I agree with what safetydan said. The only proper way to implement this would be to maintain an up-to-date database of DST rules worldwide and let the user choose his/her location.
Logged

Offline JdGordon

  • Member
  • *
  • Posts: 1817
  • Constantly breaking stuff
Re: "Automatically adjust clock for daylight saving changes" option
« Reply #8 on: March 30, 2009, 04:39:18 PM »
Quote from: Genre9mp3 on March 30, 2009, 04:20:10 PM
It's indeed one hour for every country that uses the DST system.

not always... australia did 2 hours DST in 2000 for the olympics.... there is no 1 rule
Logged


Using PMs to annoy devs about bugs/patches is not a good way to have the issue looked at.

Offline Llorean

  • Member
  • *
  • Posts: 12931
Re: "Automatically adjust clock for daylight saving changes" option
« Reply #9 on: March 30, 2009, 05:09:47 PM »
Keeping a database means we need to actually keep track of DST rule changes everywhere, as they happen. We'd also be the ones yelled at if an error in the database caused someone to miss work, no matter how many places we state there's no warranty.

The advantage of "dates" rather than manually setting is that you can prepare your player in advance, rather than forgetting and having to adjust it later (which can be important for features like an alarm you depend on to go to work/class).
Logged

Offline safetydan

  • Developer
  • Member
  • *
  • Posts: 248
Re: "Automatically adjust clock for daylight saving changes" option
« Reply #10 on: March 30, 2009, 05:47:28 PM »
There are free databases of time zone data available. The one that most people use is the tzdata collection available from various places and used by almost all opensource systems (and a lot of closed source). So we don't have to maintain our own database, just provide an interface to select the appropriate region and then follow the rules in the database.
Logged

Offline Hillshum

  • Member
  • *
  • Posts: 108
Re: "Automatically adjust clock for daylight saving changes" option
« Reply #11 on: March 30, 2009, 07:56:53 PM »
Have rbutil manage the database?
Logged

Offline JdGordon

  • Member
  • *
  • Posts: 1817
  • Constantly breaking stuff
Re: "Automatically adjust clock for daylight saving changes" option
« Reply #12 on: March 30, 2009, 08:02:09 PM »
Quote from: JdGordon on March 30, 2009, 12:14:34 AM
my feeling is that all it needs is a setting "winter time", "DST+1h", "DST+2h" which should cover everything and not need anything be kept up dated... but its hardly worth the effort

imo ^^ is the only workable solution that doesnt need massive updating...
Logged


Using PMs to annoy devs about bugs/patches is not a good way to have the issue looked at.

Offline soap

  • Member
  • *
  • Posts: 1678
  • Creature of habit.
Re: "Automatically adjust clock for daylight saving changes" option
« Reply #13 on: March 31, 2009, 12:26:27 AM »
Quote from: JdGordon on March 30, 2009, 08:02:09 PM
Quote from: JdGordon on March 30, 2009, 12:14:34 AM
my feeling is that all it needs is a setting "winter time", "DST+1h", "DST+2h" which should cover everything and not need anything be kept up dated... but its hardly worth the effort

imo ^^ is the only workable solution that doesnt need massive updating...
+1 to a "standard" database file.  (said w/o knowing squat about the impact of this method).
As for the database file itself...
I smell a RBUtil job!  ;)
Logged
Rockbox Forum Guidelines
The Rockbox Manual
How to Ask Questions the Smart Way

Offline zaphee

  • Member
  • *
  • Posts: 44
  • mrjl@xmppnet.de
Re: "Automatically adjust clock for daylight saving changes" option
« Reply #14 on: April 03, 2009, 11:01:32 AM »
Quote from: soap on March 31, 2009, 12:26:27 AM
Quote from: JdGordon on March 30, 2009, 08:02:09 PM
Quote from: JdGordon on March 30, 2009, 12:14:34 AM
my feeling is that all it needs is a setting "winter time", "DST+1h", "DST+2h" which should cover everything and not need anything be kept up dated... but its hardly worth the effort

imo ^^ is the only workable solution that doesnt need massive updating...
+1 to a "standard" database file.  (said w/o knowing squat about the impact of this method).
As for the database file itself...
I smell a RBUtil job!  ;)

+1
Isn't it simple to just implement a summer time sheduler, so that it just adds 1 hour when switching to the summer time, and substracts 1 hour for the winter time.
Logged
iPod nano (1-st gen. ; 4GB)
Sandisk sansa Clip+ (2GB)
Android 4.0 tablet

  • Print
Pages: [1] 2
« previous next »
+  Rockbox Technical Forums
|-+  Rockbox Development
| |-+  Feature Ideas
| | |-+  "Automatically adjust clock for daylight saving changes" option
 

  • SMF 2.0.17 | SMF © 2019, Simple Machines
  • Rockbox Privacy Policy
  • XHTML
  • RSS
  • WAP2

Page created in 0.125 seconds with 15 queries.