Rockbox Development > Starting Development and Compiling

Skip to next song when time left is less than "Skip Length" setting

(1/3) > >>

lee321987:
I'm looking to change the source so that I get this effect ----- (assuming "Skip Length" is set to 1 minute) When there is less than 1 minute left in the current song, and I click the 'skip forward' button, playback skips to the next song in the playlist (instead of doing nothing).  Would this take a lot of work?

kugel.:

--- Quote from: lee321987 on February 24, 2009, 06:20:42 AM ---I'm looking to change the source so that I get this effect ----- (assuming "Skip Length" is set to 1 minute) When there is less than 1 minute left in the current song, and I click the 'skip forward' button, playback skips to the next song in the playlist (instead of doing nothing).  Would this take a lot of work?

--- End quote ---

It's in gwps-common.c, in the function play_hop(). Adding audio_next(); before the first return; will enable this.

However, it appears the current behavior is intended.
It is sad, I'd find this feature overly useful, if I wouldn't need to disable it in normal audio playback. As of now, this feature is more or less useless for me, even if I'd really love to use it. This behavior though, disqualifies it for me.

Reading through: http://www.rockbox.org/tracker/task/6188 , apparently quite a few people expressed their wish to be able to skip to the next song. To prevent accidental skips, sdoyon decided against implementing this.

Llorean:
We don't prevent accidental skips in normal playback mode either. It's not like it's impossible to skip backward if you leave the song. I'd agree that it should be changed so that if you're less than a single 'skip length' from the end of the song, skipping takes you to the next song. If you need to come back you can always just skip back and re-find your position. If you never want to leave the single file, you should have a single file playlist.

kugel.:
I had some email conversation with Stephane Doyon. He said the way it works now is indeed intention, and he basically doesn't want to see it changed. I can understand his reasoning, so I think we should come up with another compromise.

Llorean:
What, exactly, is his reasoning? Is he incapable of skipping back to the song he wanted to be on, if he accidentally skips too far?

If he just wants to stay within one song, he can set "Repeat 1" just like everyone else has to do. This feature shouldn't change other behaviours beside the skip length, especially when there's another setting for changing the other behaviour.

Navigation

[0] Message Index

[#] Next page