Rockbox.org home
Downloads
Release release
Dev builds dev builds
Extras extras
themes themes
Documentation
Manual manual
Wiki wiki
Device Status device status
Support
Forums forums
Mailing lists mailing lists
IRC IRC
Development
Bugs bugs
Patches patches
Dev Guide dev guide
Search



Donate

Rockbox Technical Forums


Login with username, password and session length
Home Help Search Staff List Login Register
News:

Welcome to the Rockbox Technical Forums!

+  Rockbox Technical Forums
|-+  Rockbox Development
| |-+  Feature Ideas
| | |-+  FM layout
« previous next »
  • Print
Pages: 1 [2]

Author Topic: FM layout  (Read 4654 times)

Offline AlexP

  • Global Moderator
  • Member
  • *
  • Posts: 3688
  • ex-BigBambi
Re: FM layout
« Reply #15 on: February 14, 2009, 08:56:00 AM »
Quote from: Llorean on February 14, 2009, 04:29:50 AM
That shares the image files, but you'd still end up having to keep track of them somehow. I can't imagine that the current method wastes space by remembering the filename once the WPS is tokenized and buffered, let alone if a different WPS is loaded, then they change back, etc. Separating them into two files means you need a fair bit of complexity to keep images from existing in memory twice.

How does it work currently with .wps and .rwps?
Logged
H140, F60, S120, e260, c240, Clip, Fuze v2, Connect, MP170, Meizu M3, Nano 1G, Android

Offline Llorean

  • Member
  • *
  • Posts: 12931
Re: FM layout
« Reply #16 on: February 14, 2009, 03:26:20 PM »
The WPS and RWPS are displayed on different size and usually bit-depth screens. In all honesty my guess right now is that there's no logic at all. In the few rare cases where an image is duplicated it's just in RAM twice.

In the case of the remote screen, there's likely to be several repeated images. Backdrop, volume display, battery display, etc are (in many cases) likely to not only be repeated, but be using the majority of the image buffer. You'll want some way to "share" them between screens if they are the same.
Logged

Offline AlexP

  • Global Moderator
  • Member
  • *
  • Posts: 3688
  • ex-BigBambi
Re: FM layout
« Reply #17 on: February 14, 2009, 04:47:48 PM »
Yeah, that's sort of what I was getting out.  Either way, I'm sure people will cope fine with whichever system turns out to the easiest/best to implement.
Logged
H140, F60, S120, e260, c240, Clip, Fuze v2, Connect, MP170, Meizu M3, Nano 1G, Android

Offline Llorean

  • Member
  • *
  • Posts: 12931
Re: FM layout
« Reply #18 on: February 14, 2009, 11:41:10 PM »
Well, but the image buffer for the rwps is TINY. They're mono, they don't have a backdrop buffer, and the resolution is small. Another full screen that's fully themable would either need to have another significant amount of memory put aside for it, or ideally it should have some method of reusing images.
Logged

Offline JdGordon

  • Member
  • *
  • Posts: 1817
  • Constantly breaking stuff
Re: FM layout
« Reply #19 on: February 14, 2009, 11:55:18 PM »
nope... the image buffer for the RPWS atm is freeking HUGE! its the same size as the main screen buffer and 1/4 the bit depth... this is partly the reason for FS#9886 (which could do with testers :) )
Logged


Using PMs to annoy devs about bugs/patches is not a good way to have the issue looked at.

Offline Llorean

  • Member
  • *
  • Posts: 12931
Re: FM layout
« Reply #20 on: February 14, 2009, 11:59:06 PM »
Well "the amount of memory needed for the RWPS" is tiny then, even if the amount currently used is huge.

It should be 1/16 the bit depth, right? 1bpp instead of 16bpp?
Logged

Offline JdGordon

  • Member
  • *
  • Posts: 1817
  • Constantly breaking stuff
Re: FM layout
« Reply #21 on: February 15, 2009, 12:02:23 AM »
ah yeah, either way, a massive amount of RAM is being wasted currently for it. (well not really massive when you tihnk about it being used for compressed audio instead, but it does make the main binary look bloated.)
Logged


Using PMs to annoy devs about bugs/patches is not a good way to have the issue looked at.

  • Print
Pages: 1 [2]
« previous next »
+  Rockbox Technical Forums
|-+  Rockbox Development
| |-+  Feature Ideas
| | |-+  FM layout
 

  • SMF 2.0.17 | SMF © 2019, Simple Machines
  • Rockbox Privacy Policy
  • XHTML
  • RSS
  • WAP2

Page created in 0.281 seconds with 14 queries.