Rockbox.org home
Downloads
Release release
Dev builds dev builds
Extras extras
themes themes
Documentation
Manual manual
Wiki wiki
Device Status device status
Support
Forums forums
Mailing lists mailing lists
IRC IRC
Development
Bugs bugs
Patches patches
Dev Guide dev guide
Search



Donate

Rockbox Technical Forums


Login with username, password and session length
Home Help Search Staff List Login Register
News:

Rockbox Ports are now being developed for various digital audio players!

+  Rockbox Technical Forums
|-+  Rockbox Development
| |-+  Feature Ideas
| | |-+  FM layout
« previous next »
  • Print
Pages: [1] 2

Author Topic: FM layout  (Read 4655 times)

Offline josephcs

  • Member
  • *
  • Posts: 20
    • JOSEPHCS
FM layout
« on: February 07, 2009, 11:14:16 PM »
Can FM layout be changed in future versions?

Music Player >> rocks! Uses theme images and the layout depends on the respective theme.
FM >> A black screen with text at the top left corner.. This can be changed to something like the normal music player..

FM Station naming is really a wonderful concept..! That thing should be appreciated..  8)
Logged
Sansa e250

Website | Twitter

Offline AlexP

  • Global Moderator
  • Member
  • *
  • Posts: 3688
  • ex-BigBambi
Re: FM layout
« Reply #1 on: February 09, 2009, 03:21:38 AM »
Quote from: josephcs on February 07, 2009, 11:14:16 PM
Can FM layout be changed in future versions?

Of course, somebody just needs to do the work....
Logged
H140, F60, S120, e260, c240, Clip, Fuze v2, Connect, MP170, Meizu M3, Nano 1G, Android

Offline josephcs

  • Member
  • *
  • Posts: 20
    • JOSEPHCS
Re: FM layout
« Reply #2 on: February 10, 2009, 07:40:56 AM »
Quote from: BigBambi on February 09, 2009, 03:21:38 AM
Quote from: josephcs on February 07, 2009, 11:14:16 PM
Can FM layout be changed in future versions?

Of course, somebody just needs to do the work....

The text can be aligned Center with a little bit extra line spacing between the lines, so that the screen is somehow covered.. :)
Logged
Sansa e250

Website | Twitter

Offline AlexP

  • Global Moderator
  • Member
  • *
  • Posts: 3688
  • ex-BigBambi
Re: FM layout
« Reply #3 on: February 10, 2009, 07:42:41 AM »
There is no point doing a half-arsed job IMO - if somebody is going to take the time to do it I'd like to see a WFMS (While FM Screen) - especially for newer targets such as the gigabeat S that can do RDS.
Logged
H140, F60, S120, e260, c240, Clip, Fuze v2, Connect, MP170, Meizu M3, Nano 1G, Android

Offline Mr Whippy

  • Member
  • *
  • Posts: 154
Re: FM layout
« Reply #4 on: February 10, 2009, 06:21:27 PM »
How about retro style display?

http://www.tonyhartmusic.co.uk/store/general/hifi/images/sontun.jpg
Logged

Offline Chronon

  • Rockbox Expert
  • Member
  • *
  • Posts: 4379
Re: FM layout
« Reply #5 on: February 10, 2009, 06:39:56 PM »
I believe that a big part of BigBambi's suggestion is that if someone does this right this screen should be customizable in similar fashion to the WPS.
Logged
Sansa e280, Gigabeat F40, Gigabeat S60, Sansa Clip+, iPod Mini 2g

Offline AlexP

  • Global Moderator
  • Member
  • *
  • Posts: 3688
  • ex-BigBambi
Re: FM layout
« Reply #6 on: February 11, 2009, 03:21:34 AM »
Exactly :)
Logged
H140, F60, S120, e260, c240, Clip, Fuze v2, Connect, MP170, Meizu M3, Nano 1G, Android

Offline JdGordon

  • Member
  • *
  • Posts: 1817
  • Constantly breaking stuff
Re: FM layout
« Reply #7 on: February 12, 2009, 07:47:41 PM »
im slowly working on getting to a WPS-like fm screen (and have been for many many months :D )

one (minor-ish) problem is what sort of tag system do we want to use? do we reuse the same tags from the wps and try to map things sensibly? (i.e track title -> station preset name or something), or do we ignore that and just add new tags for fm? the first seems nicer because it means you could use 1 .wps file for both screens, but it might not be easy to do the mappings.

I'd like to think ill eventually get wps fm done, but like i said, ive been working on it for months (i think first attempt was dec 06 :p ) maybe for release 3.4 :D
Logged


Using PMs to annoy devs about bugs/patches is not a good way to have the issue looked at.

Offline AlexP

  • Global Moderator
  • Member
  • *
  • Posts: 3688
  • ex-BigBambi
Re: FM layout
« Reply #8 on: February 13, 2009, 07:04:22 AM »
I think trying to remap could get confusing - I'd prefer new tags and I don't think we will actually need too many new tags.  Many are going to be the same (battery, clock etc), leaving things like station preset name, frequency, mono/stereo, mode - I'm struggling to think of many more.
Logged
H140, F60, S120, e260, c240, Clip, Fuze v2, Connect, MP170, Meizu M3, Nano 1G, Android

Offline cool_walking_

  • Rockbox Expert
  • Member
  • *
  • Posts: 695
Re: FM layout
« Reply #9 on: February 13, 2009, 07:50:35 AM »
I don't really use the radio, but I agree with BigBambi.  Having a token mean two different things feels messy.
Logged

Offline Chronon

  • Rockbox Expert
  • Member
  • *
  • Posts: 4379
Re: FM layout
« Reply #10 on: February 13, 2009, 01:38:39 PM »
Plus, to reuse an existing .wps file you have to make decisions about how to treat the various tags that won't be supported in the FMPS/RPS.  Tags that print text need to be treated as a LF while those that display images should be ignored entirely.  This seems to get a bit tricky since conditional tags need to be treated differently depending on the content of the different conditions.  From a novice programmer's standpoint, it seems simpler and cleaner to just define new tags to provide functionality that differs from the WPS.
Logged
Sansa e280, Gigabeat F40, Gigabeat S60, Sansa Clip+, iPod Mini 2g

Offline Llorean

  • Member
  • *
  • Posts: 12931
Re: FM layout
« Reply #11 on: February 14, 2009, 12:20:23 AM »
The problem with different tags (and ostensibly a separate .wps file) is that you'll most likely then either need a complicated method for sharing images between them, or be storing many images twice.

FM really only has four applicable fields if I'm thinking clearly -
Frequency
Station name
RDS
Preset Number

Then you could do something like this: frequency could be "track title", "station" could be artist, "RDS" could be album, and "Preset number" could be playlist position, fairly easily. This is a bit 'dumb' but it means probably 98% of existing WPSes would effectively display for FM as is.

Otherwise you end up needing either a "radio" conditional for the WPS, so that one WPS can contain separate radio code (perhaps replacement viewports) or you need to come up with a way to 'share' as much as possible between two .wps (well a .wps and a .wrs) files so that memory use is kept down.
Logged

Offline AlexP

  • Global Moderator
  • Member
  • *
  • Posts: 3688
  • ex-BigBambi
Re: FM layout
« Reply #12 on: February 14, 2009, 03:53:12 AM »
I don't see why it has to be that complicated to share images - you have at the moment mytheme.wps and a directory mytheme with all the images in.  Why not just have in addition mytheme.wrs, and both the wps and the wrs can use the images in the mytheme directory?  The only downside is that you would be duplicating some code between the two for e.g. volume and battery.

I would add mono/stereo to your list of tags, and also expand RDS - there are various fields within RDS that one may or may not wish to show.
Logged
H140, F60, S120, e260, c240, Clip, Fuze v2, Connect, MP170, Meizu M3, Nano 1G, Android

Offline Llorean

  • Member
  • *
  • Posts: 12931
Re: FM layout
« Reply #13 on: February 14, 2009, 04:29:50 AM »
That shares the image files, but you'd still end up having to keep track of them somehow. I can't imagine that the current method wastes space by remembering the filename once the WPS is tokenized and buffered, let alone if a different WPS is loaded, then they change back, etc. Separating them into two files means you need a fair bit of complexity to keep images from existing in memory twice.
Logged

Offline JdGordon

  • Member
  • *
  • Posts: 1817
  • Constantly breaking stuff
Re: FM layout
« Reply #14 on: February 14, 2009, 05:32:04 AM »
My preferred method is to have a radio conditional, but I dont fiddle with .wps' so thats probably not the preffered way for people that do.

I'm currently working on a patch which completely changes the way RAM is managed in the WPS which could potentially use no extra RAM if an image is shared between both wps type screens, but anyway, I dont think thats an issue... if the radio gets wps'ed then one way or another we will make images work.
Logged


Using PMs to annoy devs about bugs/patches is not a good way to have the issue looked at.

  • Print
Pages: [1] 2
« previous next »
+  Rockbox Technical Forums
|-+  Rockbox Development
| |-+  Feature Ideas
| | |-+  FM layout
 

  • SMF 2.0.17 | SMF © 2019, Simple Machines
  • Rockbox Privacy Policy
  • XHTML
  • RSS
  • WAP2

Page created in 0.114 seconds with 15 queries.