Rockbox.org home
Downloads
Release release
Dev builds dev builds
Extras extras
themes themes
Documentation
Manual manual
Wiki wiki
Device Status device status
Support
Forums forums
Mailing lists mailing lists
IRC IRC
Development
Bugs bugs
Patches patches
Dev Guide dev guide
Search



Donate

Rockbox Technical Forums


Login with username, password and session length
Home Help Search Staff List Login Register
News:

Welcome to the Rockbox Technical Forums!

+  Rockbox Technical Forums
|-+  Rockbox Development
| |-+  Feature Ideas
| | |-+  Proper Theme Deletion
« previous next »
  • Print
Pages: [1]

Author Topic: Proper Theme Deletion  (Read 6597 times)

Offline BdN3504

  • Artist
  • Member
  • *
  • Posts: 323
Proper Theme Deletion
« on: February 07, 2009, 06:06:56 PM »
I would like to see a viewers kind of feature, that can only be performed on cfg files in the themes directory. a long select will bring up the context menu in that folder which lists "remove theme". this feature will read out the theme file delete all files whose location is pointed in the cfg file, excpet for the font.
I think this must be possible... the option to access files of a certain kind is given, the option to delete files is given, the option to read out a cfg file is given, the option to delete folders is given, so there shouldn't be much of a hassle.

Screenshots explain what i mean.
hm how can i do this myself?
i can't find out which parts of the code i have to modify...
where can i find the context menu?
i think i can use these lines to get to the directories i am looking for in settings.h
Code: [Select]
#define WPS_DIR     ROCKBOX_DIR "/wps"
#define THEME_DIR   ROCKBOX_DIR "/themes"

please direct me to the right place, if i'm posting / looking for help in the wrong spot.

* DelTheme01.png (1.04 kB, 176x220 - viewed 450 times.)

* DelTheme02.png (0.95 kB, 176x220 - viewed 459 times.)

* DelTheme03.png (1.02 kB, 176x220 - viewed 468 times.)
« Last Edit: February 07, 2009, 10:23:19 PM by BdN3504 »
Logged

Offline motionman95

  • Member
  • *
  • Posts: 108
  • aka coderkid
    • coderkid
Re: Proper Theme Deletion
« Reply #1 on: April 05, 2009, 02:26:33 PM »
Hmm...good idea, LOL. I think I'll work on it.
Logged
My MP3 Player: Sansa C250 (2GB)
OS: Win XP SP3

Offline motionman95

  • Member
  • *
  • Posts: 108
  • aka coderkid
    • coderkid
Re: Proper Theme Deletion
« Reply #2 on: April 14, 2009, 01:08:07 PM »
Hey, I've have an awesome prototype that's pretty much ready. When the prototype's complete, I'll see if I can put it in the tracker.
Logged
My MP3 Player: Sansa C250 (2GB)
OS: Win XP SP3

Offline BdN3504

  • Artist
  • Member
  • *
  • Posts: 323
Re: Proper Theme Deletion
« Reply #3 on: April 14, 2009, 07:11:55 PM »
good to hear. so you've implemented it as a plug in?
Logged

Offline motionman95

  • Member
  • *
  • Posts: 108
  • aka coderkid
    • coderkid
Re: Proper Theme Deletion
« Reply #4 on: April 14, 2009, 07:43:49 PM »
Not intentionally. I plan to convert to a viewer after I learn how a viewer plugin works.
Logged
My MP3 Player: Sansa C250 (2GB)
OS: Win XP SP3

Offline psycho_maniac

  • Member
  • *
  • Posts: 814
    • MyWebPage
Re: Proper Theme Deletion
« Reply #5 on: April 24, 2009, 01:45:24 PM »
yes we have a proper way of installing them finally but we never had a proper way to uninstalling them. this is a good idea.
Logged
Please SEARCH the wiki | Please read the Forum Guidelines | Please Read the Manual
I Own A Gigabeat F80

Offline BdN3504

  • Artist
  • Member
  • *
  • Posts: 323
Re: Proper Theme Deletion
« Reply #6 on: May 14, 2009, 12:21:32 PM »
Just to have it all in one place: Thanks to motionman95 there is a patch on the tracker which implements this feature.
Logged

Offline psycho_maniac

  • Member
  • *
  • Posts: 814
    • MyWebPage
Re: Proper Theme Deletion
« Reply #7 on: June 12, 2009, 03:22:30 AM »
could post the tracking number perhaps?
Logged
Please SEARCH the wiki | Please read the Forum Guidelines | Please Read the Manual
I Own A Gigabeat F80

Offline Chronon

  • Rockbox Expert
  • Member
  • *
  • Posts: 4379
Re: Proper Theme Deletion
« Reply #8 on: June 12, 2009, 04:00:46 AM »
The post previous to yours links directly to it.
Logged
Sansa e280, Gigabeat F40, Gigabeat S60, Sansa Clip+, iPod Mini 2g

Offline BdN3504

  • Artist
  • Member
  • *
  • Posts: 323
Re: Proper Theme Deletion
« Reply #9 on: July 23, 2009, 06:13:42 PM »
i would just like to anounce that  Teruaki Kawashima  has implemented exactly what i wanted when i started this thread and  he also added a fully costumizable theme deletion menu, which let's you choose which part of a theme you wish to keep/delete. i want to thank him with this post and point the core developers' attention to that task for svn consideration. Are there any changes needed to be done to get it comitted?
Logged

Offline saratoga

  • Developer
  • Member
  • *
  • Posts: 8974
Re: Proper Theme Deletion
« Reply #10 on: July 23, 2009, 06:30:41 PM »
Quote from: BdN3504 on July 23, 2009, 06:13:42 PM
i want to thank him with this post and point the core developers' attention to that task for svn consideration. Are there any changes needed to be done to get it comitted?

You should probably ask teru (who I don't think reads the forums).  I'm sure he'll commit it when he feels its done.
Logged

Offline BdN3504

  • Artist
  • Member
  • *
  • Posts: 323
Re: Proper Theme Deletion
« Reply #11 on: July 31, 2009, 10:36:03 PM »
thanks!
« Last Edit: August 01, 2009, 07:47:24 AM by BdN3504 »
Logged

Offline mcuelenaere

  • Developer
  • Member
  • *
  • Posts: 392
Re: Proper Theme Deletion
« Reply #12 on: August 01, 2009, 07:17:32 AM »
Posted
Logged

Offline BdN3504

  • Artist
  • Member
  • *
  • Posts: 323
Re: Proper Theme Deletion
« Reply #13 on: December 13, 2009, 11:06:21 AM »
Thanks to everybody involved in developing this feature and especially Teruaki Kawashima for this.
Logged

  • Print
Pages: [1]
« previous next »
+  Rockbox Technical Forums
|-+  Rockbox Development
| |-+  Feature Ideas
| | |-+  Proper Theme Deletion
 

  • SMF 2.0.17 | SMF © 2019, Simple Machines
  • Rockbox Privacy Policy
  • XHTML
  • RSS
  • WAP2

Page created in 0.106 seconds with 15 queries.