Some themes wouldn't display Album art

[halluc1nati0n]

Have a rockboxed Sansa e200 Series player...
Albumart works just fine on cabbie v2 & few other select themes..

But on some themes, like Kratojet, SimpleAA etc.. at the place where the album art should reside it's blank and just 2 lines appear which act as a frequency monitor for the sound being played..
This is weird.. A set of themes (around 6-8) seem to have the same bug.
I'm guessing all these themes are based on the same plugin, which, somehow, I think am missing.
Please guide!

[AlexP]

Plugins aren't used for WPSs.

What is actually happening is that the themes that don't work are outdated and therefore the syntax is wrong.  As a result, the player is falling back on the inbuilt default.

You can open the .wps file in a text editor and with reference to www.rockbox.org/wiki/CustomWPS fix them.

[halluc1nati0n]

OK.. So they'd have worked with older versions of Rockbox ?
hmm.. This means I'll have to search for themes specific to my version of Rockbox!
Ok - So any good RB3.1 themes out there for the Sansa e200 ?

Thanks for clearing things up!

EDIT:

Trying to clear the WPS for JetoKrat to work with RB 3.1

Here's a snip of the WPS I think is relevant :

%P|pb.bmp|


%?mp<%xdD|%xdA|%xdE|%xdC|%xdB>
%?pv<%xda|%xdb|%xdc|%xdd|%xde|%xdf|%xdg|%xdh|%xdj|%xdk|%xdl|%xdm|%xdn|%xdo|%xdp|%xdq|%xdr|%xds|%xdt|%xdu|%xdv>
%?bl<%xdF|%xdG|%xdH|%xdI|%xdJ>
%?mp<%xdD|%xdA|%xdE|%xdC|%xdB>
%?mm<|%xdO|%xdP|%xdQ|>
%?mh<%xdM|>
%?ps<%xdL|>
%?lh<%xdN|>

%V|0|26|176|38|1|FFFFFF|000000|
%ac%s%?ia<%ia|Artist Unkown>
%ac%s%?it<%it|Title Unkown>
%ac%s%?id<%id|Album Unkown>

%V|38|64|100|100|1|FFFFFF|000000|
%?C<%C|>
%Cl|0|0|c100|c100|

%V|24|175|144|8|1|FFFFFF|000000|
%pb|24|0|168|0|

%V|1|199|40|14|1|FFFFFF|000000|
%al%pc
%V|136|199|39|14|1|FFFFFF|000000|
%ar-%pr

Questions:

From the Wiki page :

Album Art

It is possible to make your WPS display cover art. See AlbumArt for full details. Both of the following tags are required:

%Cl|xpos|ypos|maxwidth|maxheight|  -  Define the picture settings.
%C    -  Display the album art bitmap.

%Cl is present in the WPS .. but %C is not .. Is that the problem?

One more thing :
I couldn't find anything defined for '%P' in the Wiki page .. http://www.rockbox.org/twiki/bin/view/Main/CustomWPS
Is that an old command?

[karashata]

The %P used to be the load tag for the progress bar image when one was used. It's since been combined with the %pb tag (which got redone to better resemble everything else, its format is now %pb|[image]|[x-pos]|[y-pos]|[width]|[height]|, substituting everything in square brackets (including the brackets) with the appropriate info.) Fixing that should probably fix the whole theme, unless there are bugs in the syntax not shown in the snippit you provided.  You'll need to change the values in the theme's current %pb tag since they won't place the progress bar where it needs to be. The old format (the one used in the theme) was %pb|[height]|[left-pos]|[right-pos]|[top-pos]|, so you can get the x-pos from the left-pos, the y-pos from the top-pos, the width from right-pos minus left-pos, and the height from the height. (Your tag will be %pb|pb.bmp|0|0|168|24|)

The %C tag is present (above the %Cl tag, in a %?C conditional that only displays the art if it's present), so don't worry about that.

[halluc1nati0n]

Thanks a lot man! 
Much appreciated....

Here's the other part of the WPS :

%X|WPS.bmp|0|0|
%pb|pb.bmp|
%xl|A|play.bmp|7|173|
%xl|B|rew.bmp|4|172|
%xl|C|ffwd.bmp|4|172|
%xl|D|stop.bmp|4|172|
%xl|E|pause.bmp|4|172|
%xl|F|1bat_vlow.bmp|148|4|   
%xl|G|2bat_low.bmp|148|4|
%xl|H|3bat_mid.bmp|148|4|
%xl|I|4bat_high.bmp|148|4|
%xl|J|5bat_max.bmp|148|4|
%xl|L|shuffle.bmp|51|0|
%xl|M|lock.bmp|79|0|
%xl|N|HDD.bmp|103|0|
%xl|O|repeat_all.bmp|0|0|
%xl|P|repeat_one.bmp|0|0|
%xl|Q|repeat_shuff.bmp|0|0|
%xl|a|vol1.bmp|40|198|
%xl|b|vol2.bmp|40|198|
%xl|c|vol3.bmp|40|198|
%xl|d|vol4.bmp|40|198|
%xl|e|vol5.bmp|40|198|
%xl|f|vol6.bmp|40|198|
%xl|g|vol7.bmp|40|198|
%xl|h|vol8.bmp|40|198|
%xl|j|vol10.bmp|40|198|
%xl|k|vol11.bmp|40|198|
%xl|l|vol12.bmp|40|198|
%xl|m|vol13.bmp|40|198|
%xl|n|vol13.bmp|40|198|
%xl|n|vol14.bmp|40|198|
%xl|o|vol15.bmp|40|198|
%xl|p|vol16.bmp|40|198|
%xl|q|vol17.bmp|40|198|
%xl|r|vol18.bmp|40|198|
%xl|s|vol19.bmp|40|198|
%xl|t|vol20.bmp|40|198|
%xl|u|vol21.bmp|40|198|
%xl|v|vol22.bmp|40|198|

I've changed %P to %pb, still it doesn't seem to work.
Any suggestions?

[karashata]

You need to remove the %P tag altogether and substitute the old %pb tag with the one I gave you...

Since all the rest of the WPS is image load tags I can't see any problems with it (except that the %X tag doesn't need x and y positions, remove the 0|0| from the end of that and it will be fine), so all you need to do is take the line %pb|pb.bmp| out, and substitute the line %pb|pb.bmp|0|0|168|24| for the line %pb|24|0|168|0| in the WPS file.

Your WPS should look like this when it's done:

Code: [Select]

%X|WPS.bmp|
%xl|A|play.bmp|7|173|
%xl|B|rew.bmp|4|172|
%xl|C|ffwd.bmp|4|172|
%xl|D|stop.bmp|4|172|
%xl|E|pause.bmp|4|172|
%xl|F|1bat_vlow.bmp|148|4|   
%xl|G|2bat_low.bmp|148|4|
%xl|H|3bat_mid.bmp|148|4|
%xl|I|4bat_high.bmp|148|4|
%xl|J|5bat_max.bmp|148|4|
%xl|L|shuffle.bmp|51|0|
%xl|M|lock.bmp|79|0|
%xl|N|HDD.bmp|103|0|
%xl|O|repeat_all.bmp|0|0|
%xl|P|repeat_one.bmp|0|0|
%xl|Q|repeat_shuff.bmp|0|0|
%xl|a|vol1.bmp|40|198|
%xl|b|vol2.bmp|40|198|
%xl|c|vol3.bmp|40|198|
%xl|d|vol4.bmp|40|198|
%xl|e|vol5.bmp|40|198|
%xl|f|vol6.bmp|40|198|
%xl|g|vol7.bmp|40|198|
%xl|h|vol8.bmp|40|198|
%xl|j|vol10.bmp|40|198|
%xl|k|vol11.bmp|40|198|
%xl|l|vol12.bmp|40|198|
%xl|m|vol13.bmp|40|198|
%xl|n|vol13.bmp|40|198|
%xl|n|vol14.bmp|40|198|
%xl|o|vol15.bmp|40|198|
%xl|p|vol16.bmp|40|198|
%xl|q|vol17.bmp|40|198|
%xl|r|vol18.bmp|40|198|
%xl|s|vol19.bmp|40|198|
%xl|t|vol20.bmp|40|198|
%xl|u|vol21.bmp|40|198|
%xl|v|vol22.bmp|40|198|


%?mp<%xdD|%xdA|%xdE|%xdC|%xdB>
%?pv<%xda|%xdb|%xdc|%xdd|%xde|%xdf|%xdg|%xdh|%xdj|%xdk|%xdl|%xdm|%xdn|%xdo|%xdp|%xdq|%xdr|%xds|%xdt|%xdu|%xdv>
%?bl<%xdF|%xdG|%xdH|%xdI|%xdJ>
%?mp<%xdD|%xdA|%xdE|%xdC|%xdB>
%?mm<|%xdO|%xdP|%xdQ|>
%?mh<%xdM|>
%?ps<%xdL|>
%?lh<%xdN|>

%V|0|26|176|38|1|FFFFFF|000000|
%ac%s%?ia<%ia|Artist Unkown>
%ac%s%?it<%it|Title Unkown>
%ac%s%?id<%id|Album Unkown>

%V|38|64|100|100|1|FFFFFF|000000|
%?C<%C|>
%Cl|0|0|c100|c100|

%V|24|175|144|8|1|FFFFFF|000000|
%pb|pb.bmp|0|0|168|24|

%V|1|199|40|14|1|FFFFFF|000000|
%al%pc
%V|136|199|39|14|1|FFFFFF|000000|
%ar-%pr

For what it's worth now, you might as well replace the whole WPS file with the above code, since that's what you need...

[halluc1nati0n]

@karashata

That worked like a charm!   
Thanks for all the help.. Now I can modify the themes to my own liking 

[karashata]

I do what I can, having experience with making themes tends to help, and I've gone through most of the WPS syntax changes myself and had to update accordingly.

Keep in mind that, due to the nature of a wiki, the older CustomWPS pages are still archived (right along the bottom of the page you can see the page's revision history), if you need to find an unlisted command that may bave been removed or changed, or the old syntax to a command that's since been changed, you can browse to an older page and try to find it there.

[ilovehayden101]

hi, i have the same player im wondering if this works for all themes? becasue mines wont show it

[karashata]

If you open the .wps file for the theme and make sure there are no unsupported tags (check the CustomWPS wiki page), and the existing tags are in the proper syntax, you should be able to fix any theme.  Keep in mind though that if a theme is using unsupported tags it likely requires a custom build with a particular patch, and fixing it will likely result in the theme not quite looking like it was originally made to.