AlbumArt naming

[yapper]

One of the options for Album Art naming listed on the wiki at http://www.rockbox.org/twiki/bin/view/Main/AlbumArt#Where_To_Put_The_Images is

/.rockbox/albumart/ artist-albumtitle .bmp

This implies the hyphen is used to delimit the artist from the albumtitle, but how does this work if the artist name includes a hyphen (e.g. B-52's)? Obviously the same thing could occur in the album title too.

[Llorean]

If it's not making assumptions it should only be a problem in a situation such as artist being "B" and the album being "52s-Long" while the other is "B-52s" and "Long." But it may still need fixing if it currently makes assumptions and parses filenames in advance rather than doing it the simple way. You could test the actual behaviour for yourself and let us know if there's and actual problem or not...

[yapper]

Thinking about it a bit more, the code is presumably simply concatenating the artist data (from the tag) with the albumtitle (again from the tag), and then looking in the albumart subdirectory for a match, so the presence of hyphens shouldn't be a problem unless a conflict arises such as the example you suggested.

So far I haven't found any problems with 'non-conflict' cases, even when hypens appear within the artitst or albumtitle tags.

[rasher]

If it's not making assumptions it should only be a problem in a situation such as artist being "B" and the album being "52s-Long" while the other is "B-52s" and "Long." But it may still need fixing if it currently makes assumptions and parses filenames in advance rather than doing it the simple way.

As the author of this code, I can say with some confidence, that it does not. The only problem, as you say, is if two artist/album combinations end up the same. I find that highly unlikely to occur through real use. If it does happen, I'm prepared to tell the user to simply put albumart inside the album folder for these two albums.