Rockbox Development > Feature Ideas

not freeze upon ogg playback

<< < (2/3) > >>

Arioch:
example of files was given, so you may check the difference beween yours and that one

Also i guess you do not have Ogg's encoded with eary versions of ibvorbis, so-called fllor-0 files. They are not played as well.

BTW, what is so bad about chained ogg, that there is no way for RockBox to play them ?

As a sidenote - those filesin PC players:
 AIMP (Win32 player, based upon un4seen BASS lib) plays 1st rack, then skips to next fie
 VideoLAN plays through, but fails in placelist and tags render and artialy fail in navigation within file

bluebrother:

--- Quote from: Arioch on October 22, 2008, 04:28:11 PM ---example of files was given, so you may check the difference beween yours and that one

--- End quote ---
I think you missed my point.

You claimed ogg files breaking playback. This simply is wrong as it only tells half of the truth: there are two specific, rather rare types of ogg files around that don't play: floor0-files and chained files. I find it rather tentive having to look up a flyspray task to figure what's the exact issue. To address a problem the most important first step is to name the problem as exact as possible. Just requesting to "not freeze upon ogg playback" is not really helpful: it does confuse users, developers and mods in the forums as it's way too unspecific.

The real issue has been named later by others. If you'd done that in the first place yourself your original task most likely wouldn't have been closed (Rockbox shouldn't crash on files it doesn't support, so this qualifies it as bug). Asking for support of chained files is a different issue and could've been done here, but this would have needed to include the correct issue -- as said, supporting chained files.

And that "example was given" ..., well, you're aware that this is distributing copyrighted material? Give an example you actually can distribute.

saratoga:

--- Quote from: Arioch on October 22, 2008, 04:28:11 PM ---BTW, what is so bad about chained ogg, that there is no way for RockBox to play them ?

--- End quote ---

Its a dumb idea since theres no way to know how many tracks are in a file without playing back the file.  Since we don't necessarily have the entire file loaded from disk at playtime, we can't know how many tracks there are until the decoder suddenly stumbles onto the next track. 

Also, I think we do support floor 0 files.  Theres a decoder built in for them.  I was also going to suggest removing the code for it to reduce memory usage since floor0 files are so rare.

soap:
There appear to be two issues here, chained and floor-0
Over a year ago Arioch was the impetus for the other, related, task:
http://www.rockbox.org/tracker/task/5796
which suggests that we don't have support for floor-0?

saratoga:

--- Quote from: soap on October 22, 2008, 06:56:04 PM ---which suggests that we don't have support for floor-0?


--- End quote ---

I can't check the .map file since I don't have a linux machine handy, but Tremor's SOURCES file contains this:


--- Quote ---bitwise.c
block.c
codebook.c
floor0.c
floor1.c
framing.c

--- End quote ---

And floor0.c allocates some IRAM variables, suggesting that it at least worked well enough at one point for some to optimize it. 

Navigation

[0] Message Index

[#] Next page

[*] Previous page