Support and General Use > Theming and Appearance Customization

new tag on the tracker... FS#9477

<< < (3/7) > >>

audio-i:
@bzavala, you may see it as an improved "hold conditional" view mode, because when you use the hold to display a different view, you are in one of the following situations: 1- you get the new info, but you obviously  won't be able to change volume, etc,  or 2- you block all the buttons using hold as intended, but you are "forced" to leave the main view. With this tag you get your new views without falling in these situations.
But this tag is much more than that; to give an "extreme" example, you could even make something like a "one click theme change" (of course if you stay within the current limits - viewports #, images loaded, etc -), because when you change the view mode, you could display a whole new set of images, still being able to use all the buttons normally, keeping all the functionality... and if this tag makes a "one click theme change" possible, many "in between" options would also be possible, wouldn't it?  ;)

pixelma:

--- Quote from: akahhannah on October 14, 2008, 12:33:39 AM ---...still being able to use all the buttons normally, keeping all the functionality...
--- End quote ---

No you are not. When using this tag you will not be able to enter the file browser with a short button press from the WPS anymore (at least on many targets even if you can find a spare button to do this on some). And the most cumbersome thing about it in my opinion is - that this button behaviour will change depending on whether your selected theme uses this tag in the WPS or not.

GodEater:
Agreed, button behaviour which is changed depending on what theme you have loaded is a very bad idea.

linuxstb:
My initial reaction to this patch was the same as many others - that changing button mapping depending on theme is a bad idea.

But the more I think about it, the less against it I am.  Users choose to install a theme, and it should be pretty obvious that the WPS is responsible when pressing SELECT (or whatever the ACTION_WPS_BROWSE action is mapped to) causes the WPS to change instead of the normal behaviour.

The manual could be modified to say something like "this button either changes the current WPS view (for themes that support multiple views), or provides a shortcut to enter the browser."

The other problem of course is that not all targets (although I think it's just one - the Ondio) simply don't have enough buttons to enable this feature to work.  So reluctantly, I think we would have to say that the Ondio can't have this feature due to hardware limitations (lack of buttons).   EDIT: pixelma has corrected me, so ignore this paragraph.

So assuming that people think this feature is useful, I think we should be prepared to compromise.

To the theme designers that want this patch committed - it's up to you to convince the Rockbox developers that this is a good idea!

bzavala:
Thanks to all who responded to my last post. I also like this idea and would like to give it a try.. perhaps I can modify some of my themes to test this.

Does someone has an already compiled version with this patch that I can try?

Thanks a lot !!


Ben

Navigation

[0] Message Index

[#] Next page

[*] Previous page