Rockbox.org home
Downloads
Release release
Dev builds dev builds
Extras extras
themes themes
Documentation
Manual manual
Wiki wiki
Device Status device status
Support
Forums forums
Mailing lists mailing lists
IRC IRC
Development
Bugs bugs
Patches patches
Dev Guide dev guide
translations translations
Search



Donate

+  Rockbox Technical Forums
|-+  Rockbox Development
| |-+  Feature Ideas
| | |-+  re FS#4988, backlight on when plugins are running
« previous next »
Pages: [1]

Author Topic: re FS#4988, backlight on when plugins are running  (Read 3448 times)

Offline Zardoz

  • Member
  • *
  • Posts: 226
re FS#4988, backlight on when plugins are running
« on: September 15, 2008, 06:43:25 PM »
The patch to allow, optionally, keeping the backlight on when using a plugin was originally committed and then reverted due to "bin size cost". I just wondered what was the cost and how it impacted on Rockbox generally, as it seems like a useful idea?
Logged
"And I have looked into the face of the force which put the idea in your head. You are bred and led yourself"

Offline saratoga

  • Developer
  • Member
  • *
  • Posts: 9348
Re: re FS#4988, backlight on when plugins are running
« Reply #1 on: September 15, 2008, 06:47:21 PM »
Since its ancient, I doubt anyone remembers off hand.  Why not check the IRC logs or else apply it yourself and see how much the bin size increases?
Logged

Offline Zardoz

  • Member
  • *
  • Posts: 226
Re: re FS#4988, backlight on when plugins are running
« Reply #2 on: September 15, 2008, 06:52:17 PM »
Ok good idea I guess.  ;)  Just asked as it had popped up in recent feature requests/...discussion

EDIT: 'ancient' being a relative term
« Last Edit: September 15, 2008, 06:56:57 PM by Zardoz »
Logged
"And I have looked into the face of the force which put the idea in your head. You are bred and led yourself"

Offline Llorean

  • Member
  • *
  • Posts: 12931
Re: re FS#4988, backlight on when plugins are running
« Reply #3 on: September 17, 2008, 08:30:35 AM »
Mpegplayer can currently override backlight settings. This can be added to other plugins without additional bincost I'm sure.
Logged

Offline Zardoz

  • Member
  • *
  • Posts: 226
Re: re FS#4988, backlight on when plugins are running
« Reply #4 on: September 20, 2008, 04:44:14 PM »
Is the code common to all plugins? I mean is it the same code? (sorry if this question is stupd but i don't understand any code let alone C)
Logged
"And I have looked into the face of the force which put the idea in your head. You are bred and led yourself"

Offline GodEater

  • Member
  • *
  • Posts: 2829
Re: re FS#4988, backlight on when plugins are running
« Reply #5 on: September 22, 2008, 08:20:13 AM »
No, it's only in mpegplayer.
Logged

Offline Zardoz

  • Member
  • *
  • Posts: 226
Re: re FS#4988, backlight on when plugins are running
« Reply #6 on: September 22, 2008, 07:19:49 PM »
Quote
I mean is it the same code?

That should have read 'Would it be the same code?' i.e for other plugins
Logged
"And I have looked into the face of the force which put the idea in your head. You are bred and led yourself"

Offline saratoga

  • Developer
  • Member
  • *
  • Posts: 9348
Re: re FS#4988, backlight on when plugins are running
« Reply #7 on: September 22, 2008, 07:20:53 PM »
I don't know how mpegplayer does it, but if it works in one plugin it should work in all.
Logged

Offline JdGordon

  • Member
  • *
  • Posts: 1817
  • Constantly breaking stuff
Re: re FS#4988, backlight on when plugins are running
« Reply #8 on: September 22, 2008, 11:15:54 PM »
Quote from: Zardoz on September 22, 2008, 07:19:49 PM
That should have read 'Would it be the same code?' i.e for other plugins

I think its in the plugin library, so its as simple as adding 2 lines of code to each plugin.
Logged


Using PMs to annoy devs about bugs/patches is not a good way to have the issue looked at.

Offline Zardoz

  • Member
  • *
  • Posts: 226
Re: re FS#4988, backlight on when plugins are running
« Reply #9 on: September 25, 2008, 08:29:21 PM »
ok cool. thanks for the replies

big up Rockbox developer people, for 3.0!

x
Logged
"And I have looked into the face of the force which put the idea in your head. You are bred and led yourself"
Pages: [1]
« previous next »
+  Rockbox Technical Forums
|-+  Rockbox Development
| |-+  Feature Ideas
| | |-+  re FS#4988, backlight on when plugins are running