Commit FS #9318 - MP3 synthesis filter on COP - Wow!

[gerwen]

I just thought I'd give some feedback on this commit.  I hope this is the appropriate place.

Wow, what a huge difference this makes.  My only real gripe with rockbox on my E280 was that control was often laggy.  Volume changes were the most annoying.  I just assumed it was a limitation of my hardware and lived with it.  (Rockbox's many benefits far outweighed this petty annoyance)

Now however, it is fixed.  Control is snappy, and any lag is too small to notice.  Commit may say somewhat less than 90% faster, but it is 100% better.

Thanks for improving an already amazing piece of software.

[ryran]

Seriously. This is amazing for us PP-target users.
Almost makes me wish I hadn't recently started re-encoding everything in ogg vorbis....
In any case, now I'd be very curious to see some benchmarks with mp3. Not gonna be me though--not this week or next.

[Llorean]

While I can't promise something, I expect it's very likely that over time similar offloading of work to the COP will benefit other codecs as well (with caveats based on the actual architecture of any given codec, of course).

[soap]

I'm guessing we'll see 90-120 minutes additional runtime on the iPod Videos.  I'll be benching the before and after this weekend.