Theme repair team wanted.

[BdN3504]

Updated:
ExampleWPS
frostBox Special - the other box themes are not clearly licensed. You guys sort this out.
Gktxt 1.0
Glass N Shadows v1.1
iPodUbuntu
Ultima v1.0

i am also fixing Theme X Album Art Edition, which you forgot to list as nonworking i guess.

i will do these irocker, rockboxed & rocker too, if you're ok with that.

then there's just frostbox normal & the pen and paper derivate left. Anyone willing to do these? if not you'll have to give me some more time.

[audio-i]

i am also fixing Theme X Album Art Edition, which you forgot to list as nonworking i guess.

I listed this theme earlier in the "unsupported - designed for a patched build" list, because it uses the resize patch (actually it mentions it as optional), but you're right, if resizing is left out, it can be updated as working for SVN builds.

then there's just frostbox normal & the pen and paper derivate left. Anyone willing to do these? if not you'll have to give me some more time.

I'll do those buy tomorrow night I hope, you've already fixed quite a bunch 

[BdN3504]

Why is the normal theme x not in the normal gallery? i have a fixed version of it on my machine, can i upload it somewhere?

[soap]

Why is the normal theme x not in the normal gallery? i have a fixed version of it on my machine, can i upload it somewhere?

Is it in the graveyard?  (correctly or incorrectly?)

[BdN3504]

Is it in the graveyard?  (correctly or incorrectly?)

that's what i meant by "not in the NORMAL gallery". i don't know if it's correct or not. i mean the AA version is licensed cc-by-sa so can't i just upload it giving credit to its original creator(s) under the premises that it's a spin off of the aa version?

[audio-i]

Why is the normal theme x not in the normal gallery? i have a fixed version of it on my machine, can i upload it somewhere?

Is it in the graveyard?  (correctly or incorrectly?)

It is in the normal gallery, not in the graveyard. What I meant is that in this list: http://forums.rockbox.org/index.php?topic=18633.msg135139#msg135139  I classified it as "designed for a patched build, therefore unsupported" (according to Llorean's comment regarding fixes beyond current build's limits), because it mentions to use three patches: Album Art, scrolling margins and BMP resize. The first two are already in the official builds, and the third is mentioned as "optional", so I guess it's OK to fix it anyway as BdN3504 says.

Edit: I just noticed that Theme X Album Art Edition (by Gary Light), placed in the normal gallery because it has a CC-BY-SA license, is based on Theme X theme (by Anthony Russel), which is placed in the graveyards (correctly) because it doesn't have a license.

[soap]

Edit: I just noticed that Theme X Album Art Edition (by Gary Light), placed in the normal gallery because it has a CC-BY-SA license, is based on Theme X theme (by Anthony Russel), which is placed in the graveyards (correctly) because it doesn't have a license.

I am sure that is not the only example.
It is something I did not attempt to look for.
We have no choice but to take contributers at their word regarding licensing rights unless proven otherwise.
If the preponderance of the evidence points to an invalid license we should probably mark the theme as such and move it to the graveyard.

[Chronon]

I just uploaded fixes for the following Gigabeat themes (in some cases it was just changing the font name in the theme.cfg):

AjantOrange
Christmas
Free-State
frostBox
frostBoxAA
Green5g_GB
palette
Pen&Paper
Ultima
Yellowjacket
Stele
4Car

I think I missed a couple that could use references to new fonts.  I'll get to those later.  I didn't touch the Desert Song theme since it doesn't say we can modify it.  I had a look at Ultima2.0, but couldn't get it to work immediately.  Quite a few of the others need patched builds (e.g. BMP resize or multifont) -- I didn't touch any of those either.

[ZincAlloy]

bmp resize compatibility doesn't break current build compatibility, does it?

[Chronon]

No, I guess only patches that introduce new tags or configuration settings will break themes.  I just didn't look at any of the themes yet that claim to need custom builds.

[BdN3504]

I had a look at Ultima2.0, but couldn't get it to work immediately.

I think i still have a fixed version of that on my machine, so you don't need to bother working on that.

[Chronon]

Sweet.  Good to know.   

[audio-i]

Updating... the frostBox Normal theme for iPod Video update is been uploaded

[BdN3504]

Alright, the only theme that has to be fixed in the 5g gallery now is the pen & paper derivate. sorry i haven't finished earlier, but fixing irocker really was a huge effort. also updated ultima v2 for gigabeat.

[blackthunder]

Would just like to mention that my e200 theme parilis did not need fixing, but someone took the liberty to "fix" it anyways and did a poor job.