Theme repair team wanted.

[Llorean]

Regarding %Cf and %?Ct, I'm not certain, it may be that the theme was made with a patch in mind.

Regarding the image buffer, old behaviour was that when the buffer was full it stopped loading images, but mostly worked as normal you just never saw the images. So if, for example, the last few images loaded were the "Stop" icon and the "On Hold" icon, or something similar, you might never notice they hadn't gotten loaded.

It's entirely possible the theme never worked, but nobody quite noticed.

[BdN3504]

Ahh ok. Thanks for clearing that up. How do we go about fixing themes that have such problems (aside from leaving some images out)?

[Llorean]

I think any theme that can't be fixed within Rockbox's current limits for whatever reason should be marked as "unsupported" and just left alone. It's up to the author how they wish to comply with whatever limitations Rockbox has.

[audio-i]

I think any theme that can't be fixed within Rockbox's current limits for whatever reason should be marked as "unsupported" and just left alone. It's up to the author how they wish to comply with whatever limitations Rockbox has.

Clear enough. I guess most of the themes made for patched builds fall there, because even something like "converting" the use of multiple fonts, might imply more than fixing the theme, e.g cBrownPlastic for ipod video... the result might be more a *branch* than a *fix*.

[karltpb]

In my opinion a wiki page would be better to track theme status. It would be easier to update it to reflect the theme status. Moreover it would provide a cleaner look and it would be easier for the users to look up the theme status too.

True .
I am the one who suggested starting a thread for it, so scold me.
Though, I'd rather spend the time to get this done than to make a wiki page.  Wiki is for permanent info, this (hopefully) is transitory.

Well if you're going to assign a different target to every member of the team, then I guess a topic would do the job too as other team members won't have to edit anything but their posts for updating theme status. If that's the case I take that back.

The other day I was thinking about the themes in the graveyard. Is it okay to list necessary changes alongside each theme (when ever possible) to fix them? I guess we won't have to worry about any licensing issues either.

I see no problem whatsoever in telling people how to fix graveyard themes, even of posting said repair instructions in the wiki.
That being said, the wiki galleries are going bye bye soon when the official theme site goes live.  The graveyards I think can be left behind, but I would rather concentrate efforts on getting the gallery themes up and running.

Does it mean the graveyard themes are going to the trash soon or are you going to keep them around for archival purposes?

[knight4led]

Clear enough. I guess most of the themes made for patched builds fall there, because even something like "converting" the use of multiple fonts, might imply more than fixing the theme, e.g cBrownPlastic for ipod video... the result might be more a *branch* than a *fix*.

With regards to my themes I haven't updated them on the wiki partly for the reason that they require a patched build. There are links to currently working versions of them in tdtooke's thread and nowhere else. So they shouldn't require a fix for the progress bar and scrolling margins if you search that thread.

However I have no problems with them being "converted" to the standard build without multiple fonts. The truth is that I think some of the differentiation in fonts can be redone with colors instead of font face to make the important lines stand out. The license allows anyone to change and redistribute the themes as long as I am credited, so feel free to have your way.

[mmadia]

I uploaded the Sansa e200 themes to the wiki and modified the entries. 
So now, it should contain all working theme files.

Should the rockbox-themes.org files be uploaded anywhere?

[karltpb]

Ah well, I guess people are doing stuff on their own. So I'm going to work on the iPod Video themes later on tonight.

[mmadia]

Ah well, I guess people are doing stuff on their own. So I'm going to work on the iPod Video themes later on tonight.

Just as a quick disclaimer, I don't mean to step on anyone's toes here. 
I saw something broken that I wanted to fix. So, I fixed it. 

[audio-i]

Ah well, I guess people are doing stuff on their own. So I'm going to work on the iPod Video themes later on tonight.

I haven't fixed any theme yet, but I already checked all the themes in the iPod video's gallery, so this can be a starting point. Here's the summary (theme name - status - comment)

Themes that worked:

AmaroK - working - svn
arboxWidgets - working - svn
AW200 - working - svn
Black Glass (Album Art Version) - working - svn
Black Glass (Non-Album Art Version) - working - svn
Cabbie 2.0 - working - svn
Cabbie 3.0 - working - svn
Christmas - working - svn
Detailed text - working - svn
DIY Contraption - working - svn
Escape Pod - working - svn
Escape Pod Plus SVN version - working - svn
EscapeBoD 2 - working - svn
Free-State for iPodVideo - working - svn
FSM(Flying Spaghetti Monster) - working - svn
Fullscreen - working - svn
ipodWidgets - working - svn. hey, I now realize it was posted to the wiki WITHOUT giving credit to the theme it is based on, the former version of arboxWidgets... too bad
kelp - working - svn
kelpbig - working - svn
nerdSketch - working - svn
newClix Series Pack 1: greenRings & fireShine - working - svn
newClix Series Pack 2: greenRings & fireShine - working - svn
Pen&Paper - working - svn
Pen&Paper_plus (Album Art + next song + waving man) - working - svn
rayboradio_OB : rayboradio for Official Build version - working - svn
Rockflow - working - svn
Slick - Bushfire - working - svn
Slick - Let It Blue - working - svn
Sudan - working - svn

Edit: Themes that have been fixed:

Classical Dark - working - svn
Simplex - working - svn
Yo Bunny - working - svn

Themes that need to be fixed:

ExampleWPS - not working - svn
frostBox Normal - not working - svn
frostBox Special - not working - svn, found a fixed version by DavidKaufmann here: http://www.rockbox.org/twiki/bin/viewfile/Main/WpsIpod5g?rev=1;filename=XXXbox.zip, it's uploaded but I can't find the link in the wiki
Gktxt 1.0 - not working - svn
Glass N Shadows v1.1- not working - svn. it was updated recently BUT the syntax is old. it's a .rar file->convert to .zip
iPodUbuntu - not working - svn. it's a .tar.gz file->convert to .zip
iRocker - not working - svn
Pen&Paper with AA and Nextsong - not working - svn
ROCKboxed - not working - svn. a working version is included in the svn Rockbox download (?)
Rocker - not working - svn
Ultima v1.0 - not working - svn

Themes made for patched builds:

I think any theme that can't be fixed within Rockbox's current limits for whatever reason should be marked as "unsupported" and just left alone. It's up to the author how they wish to comply with whatever limitations Rockbox has.

Boxagonal - unsupported - designed for a patched build
Boxagonal V1.1 + Non Album Art Version - unsupported - designed for a patched build
cBrownPlastic - unsupported - designed for a patched build
Escape Pod Plus - unsupported - designed for a patched build
Plain & Simple - unsupported - designed for a patched build
Psychosis Version 1 - unsupported - designed for a patched build
Theme X Album Art Edition - unsupported - designed for a patched build

We could now split the themes that need fixes, to avoid that two persons work on the same theme.

Edit: some of the authors of themes that need fixes are still around...

Edit: I've added notes in the gallery to the themes that need to be fixed, please remove those notes when the themes gets updated. Even better to additionaly leave there a note including the date it was updated.

[pixelma]

Since this operation means touching all the zip archives, this is a chance to bring them into line provided some guidelines or rules we can agree on.

One of my concerns now is the packaging of fonts. Currently there are some that don't include it if the font is in the extra fonts package but many do and I see that as problematic because: if the font changes in SVN (doesn't happen often but it does) then people will get the old copy by installing a theme which might have a bug or less characters. And it is also a matter of teaching people to install the fonts package... I know that there was some discussion about how the new theme site could handle this, things like automatic repackaging of themes when a font changes etc. but we aren't there yet. At least - could we have clear guidelines here?
Oh, in general, I hope all people taking part here use the new font names? (Didn't check, just making sure. )

And another topic just came to my mind, not sure but something to think or discuss about maybe: what do you think about bitmap-stripifying the themes? I'm aware that this is a bit more intrusive and quite a lot of work but it is more convenient for the user - less bitmaps (sometimes only a third or a quarter of what it was before) mean - faster unzipping (how notable that is depends on target though) and quicker boot-up times. I would hope such a community effort could give some more motivation to do this, at least for some?

Those were the 2 suggestions/questions I had; if I find the time I might help with the greyscale themes as it seems there are no monochrome ones with a proper license.

[mmadia]

One of my concerns now is the packaging of fonts. ...
At least - could we have clear guidelines here?
Oh, in general, I hope all people taking part here use the new font names? (Didn't check, just making sure. )

Most of the updated e200 themes didn't have their font names and .cfg file changed.

[BdN3504]

I think it's easier to simply use the old font, if it's included in the zip file and only update the names, if it's not present. Making the themes work has to be higher priority than complying with naming conventions, in my opinion.

PLUS i find it hard to match some old names and fonts to the current ones. is there a list somewhere containing the changes to the fonts (like "the font formerly known as chicago is now called 08-nimbus.fnt")

[Chronon]

I agree with pixelma that we should update all of the themes to use the new font names -- I was planning to do this for any themes that I work on.  (I plan to work on some of the Gigabeat themes this weekend.)  This shouldn't take much time if you use an editor such as Textpad that allows for global search and replace in all open files.

is there a list somewhere containing the changes to the fonts (like "the font formerly known as chicago is now called 08-nimbus.fnt")

Yes, there's a list here: http://svn.rockbox.org/viewvc.cgi/trunk/fonts/README

[soap]

Bitmap strips would be nice IMHO, but font name changing is a must.  (again, IMHO).
Thank for reminding us of that needed action, pixelma.