re FS#4988, backlight on when plugins are running

[Zardoz]

The patch to allow, optionally, keeping the backlight on when using a plugin was originally committed and then reverted due to "bin size cost". I just wondered what was the cost and how it impacted on Rockbox generally, as it seems like a useful idea?

[saratoga]

Since its ancient, I doubt anyone remembers off hand.  Why not check the IRC logs or else apply it yourself and see how much the bin size increases?

[Zardoz]

Ok good idea I guess.    Just asked as it had popped up in recent feature requests/...discussion

EDIT: 'ancient' being a relative term

[Llorean]

Mpegplayer can currently override backlight settings. This can be added to other plugins without additional bincost I'm sure.

[Zardoz]

Is the code common to all plugins? I mean is it the same code? (sorry if this question is stupd but i don't understand any code let alone C)

[GodEater]

No, it's only in mpegplayer.

[Zardoz]

I mean is it the same code?

That should have read 'Would it be the same code?' i.e for other plugins

[saratoga]

I don't know how mpegplayer does it, but if it works in one plugin it should work in all.

[JdGordon]

That should have read 'Would it be the same code?' i.e for other plugins

I think its in the plugin library, so its as simple as adding 2 lines of code to each plugin.

[Zardoz]

ok cool. thanks for the replies

big up Rockbox developer people, for 3.0!

x