Support and General Use > Audio Playback, Database and Playlists

bookmarks? if you use them read this!

<< < (4/4)

Llorean:
Why not keep the recent bookmarks in a file in .rockbox and update that file every time a bmark is saved. Makes saving them costlier but only for those who use the feature.

AlexP:
I'd go for that - if I am bookmarking then I am either shutting down or selecting new music, so the disk is going to spin anyway.

If you just show a list of bookmarks then how would unique work?

Lear:

--- Quote from: JdGordon on September 22, 2008, 10:57:36 AM ---I'm completely stuffed as to what to do about the recent bookmark list. Because the .bmark actually has to be loaded before it can be displayed, if we want to show the track title and the resume position in the recent list we need to waste a fair bit of ram storing track title, .bmark filename, resume point (~500 bytes each!)
Now we can do this, but thats quiet a bit of waste for people who dont use bookmarks (yes it can be allocated at boot but thats a bit annoying also)

One option is to only save the .bmark filename and only have a list of them, then selecting one would load it and display the resume points in it... good enough?

--- End quote ---

Not really, I think. But why not do it like some of the code you threw out? I.e., buffer (parts of) the file in the plugin buffer, either the raw data or parsed data ready for display.

JdGordon:
the old code stored the whole bookmark as a single string so storing a few of them in ram is no problem. A bookmark now is made up of the playlist_control file (which can be BIG) as well as resume points and the filename of the actual .bmark file.
At the very least we store the filename of the .bmark. This means unique will only work if you actually start playback from the bmark, or you keep adding after the first one was created (this may be the way its supposed to work?)
The next option is storing track title and resume points as well. (hmm, and on that point I should change it to show some track info instead of the filename in the bmark viewer...)

JdGordon:
Time for a bump because I might know how to make the bmark browser work almost the same way it works now...
as a start... would it be good enough to show the resumed tracks filename instead of its track number and title from its id3 info?

Navigation

[0] Message Index

[*] Previous page