patching latest build/release

[audiophile007]

I had 2006 Rockbox version on my iaudio X5 which had a greatest future of them all: "one click music directory insert into the active playlist" it was made possible by the custom build somebody compilied using "insert.patch" file.

I have this patch file and I am trying to upgrade to the latest rockbox release and thought that future  would be incorporated as a standard option ..but not  its not there for whatever reason...
anyway I tried to patch based on multiple description on this and other sites..and nothing works..I get Hunk#1 error all the time. its asking what is the file being patched..etc.

can someone post a complete detailed protocol with all steps and an example of all writings that should take place (what program to open/run;  what files should be where and  in what directories etc.etc.etc.) how to patch the current build.

thank you so much, please shoot me an email, Alex

[saratoga]

Patches are usually specific to the version of the code they were made against.  As people change the code, the patch becomes out of sync and can no longer be applied.  The hunk error generally means the code that patch changes no longer exists, or at least has been moved or changed beyond recognition.

You'll need to find an updated version of that patch, or write your own.  Since that patch probably came from our patch tracker, thats the first place I'd look.

[ryran]

saratoga's absoultely right--assuming you are talking about FS#2653, you can just download the latest version at the bottom of the page. It applies just fine.

[audiophile007]

I downloaded the latest insert.patch version at the bottom of the page and applied to current build for iaudio X5  IT DOES NOT WORK !

I am still amazed this future is not introduced in current version 2 years later ?!

can someone more knowledgeable with programing compile a build that would combine current daily build for iaudio x5 + insert.patch

it makes playlist management so much easier , but I wasted 3 days trying to figure out patching.....can someone help with working tested files ??

[Llorean]

Maybe if it worked fully and were tested on all targets and had an author who actively showed an interest in discussing the patch and addressing concerns with it...

Why would you be amazed a patch doesn't get accepted if it's practically abandoned? It has bugs, as can clearly be noted in the comments on it. Why should anyone want to commit a buggy patch? It is a hacky patch and is not in a state where it's committable. You don't get things committed by doing 1/3 of the job and saying "Okay guys, you need to fix it for me and commit it."

[ryran]

Llorean's right of course regarding the patch not yet making its way into the "current build" but I don't see what your problem is with applying it. I compile builds with this included every few days. If you're getting failures of some kind then something is wrong with your local copy of SVN. I'm thinking maybe you didn't do an svn revert -R . from your trunk (rockbox) directory before you applied the new version?

[audiophile007]

RYRAN

Can you please compile a build that would combine current daily build for iaudio x5 + insert.patch FS#2653 and put it somewhere for download.Would really appreaciate it.

As for the bugs...it worked flawlessly on my old rockbox ~2006 and for 2 years never had problems with it... I am not the author nor the programmer, so I can't add anymore information....but from the user point of view it was an excellent option that was overlooked when it did work for rockbox....

anyways I dont't want to go into the long arguments, I wold really appreciate if someone can compile such a build: current daily build for iaudio x5 + insert.patch FS#2653 (latest version at the bottom of the page)

[Llorean]

It didn't even work back then for all players. You need to remember, Rockbox runs on many MP3 players. It also, even in the very first version, had a negative effect on navigating menus.

Just because it affected features in a way you didn't notice, doesn't mean it didn't have bugs. It just means you didn't notice them.

[ryran]

If it were trivial for me to compile you a build for the x5, I would. Once.
I don't have the Coldfire compiler setup on my server though. I only have ARM targets.

You didn't respond to my last post -- if you've already figured out how to patch and compile, I really think your only problem is that your checked out copy of SVN has already been modified by the old insert patch, which failed, and now you're trying to patch on top of that using the new one. It seems likely to me that all you need to do is revert your local copy like I said, before you try to apply the new patch...

[audiophile007]

Ryran,

all I am doing is running patch.exe from cmd.exe and telling it to patch <insert.patch
all files are located in .rockbox folder these files are : newly downloaded daily rockbox build unzipped (never patched before) + latest version of insert.patch file 

the response I get after running the patch.exe is

Hunk#1 failed at 140
Can't rename insert.patch to insert.patch.orig : Permission denied

what does it mean..is it worth wasting another 3 days...or can someone do it in 3 minutes who is familiar with programming...

[saratoga]

Ryran,

all I am doing is running patch.exe from cmd.exe and telling it to patch <insert.patch
all files are located in .rockbox folder these files are : newly downloaded daily rockbox build unzipped (never patched before) + latest version of insert.patch file 

You can't patch a build.  You patch code.  Read the working with patches wiki page:

http://www.rockbox.org/twiki/bin/view/Main/DocsIndex#For_Developers

[audiophile007]

I read those wiki pages many times..and all instructions on patching BUT I am not a programmer they are not comprehensive to me... I need more instructions:

where is the file with the code ? I need a direct link
where do I put it ?
where do I put a .patch file ?
what programs do I run ?
in what sequence ?

et.etc.etc


I need a most detailed comprehensive example...

[MarcGuay]

Unfortunately the step-by-step is already written down in those wiki pages and it doesn't get much easier than that.  It's only a few more button presses to insert it manually - perhaps it would be easier to just get used to that?

[saratoga]

I need a most detailed comprehensive example...

Did you even look?  For instance:

http://www.rockbox.org/twiki/bin/view/Main/DevelopmentGuide

Its literally a step by step guide.  Either read or don't bother asking questions.

[audiophile007]

this is really something with you.. what do you think i ve lost 3 days doing and another day arguing with you !!!! yes I ve looked , yes I ve read !!!! cant you answer a simple question where is the code file ??!!!! and how to patch it ??!!!

and by the way if your "wonderful and comprehensive " instructions were that helpful there would not be hordes of people asking how to patch a file...just look around at the forums, so surely support team lacks connection on this side