Rockbox.org home
Downloads
Release release
Dev builds dev builds
Extras extras
themes themes
Documentation
Manual manual
Wiki wiki
Device Status device status
Support
Forums forums
Mailing lists mailing lists
IRC IRC
Development
Bugs bugs
Patches patches
Dev Guide dev guide
Search



Donate

Rockbox Technical Forums


Login with username, password and session length
Home Help Search Staff List Login Register
News:

Welcome to the Rockbox Technical Forums!

+  Rockbox Technical Forums
|-+  Support and General Use
| |-+  Theming and Appearance Customization
| | |-+  Broken WPS
« previous next »
  • Print
Pages: [1]

Author Topic: Broken WPS  (Read 2380 times)

Offline havic

  • Member
  • *
  • Posts: 8
Broken WPS
« on: July 15, 2008, 07:21:22 PM »
Should not the broken wps themes, because of the parsing change, be removed from or noted so when someone is installing through the utility.  I would not have know this as I use the utility to update to the latest versions.
Also there was no notice upon trying to download from the current build page noting this as well.
I feel as this effects a lot of users not savvy enough to know what is going on.
This could of also been listed on the home page under recent activity.

Not that I am complaining, I love rockbox and have been using it for years and have turned many people on to it. Just thought it would be helpful for some.

Thanks
Logged

Offline karashata

  • Rockbox Expert
  • Member
  • *
  • Posts: 603
  • Just a fluffy dragon with too much time on my paws
    • Alex Vanderpol (karashata) on Twitter
Re: Broken WPS
« Reply #1 on: July 15, 2008, 07:29:22 PM »
RBUtil looks at the repository on rockbox-themes.org, unless I'm mistaken, and all those themes will be broken because they can't be updated.  Either you'll have to fix them yourself, or look at the themes in the WpsGallery on the Rockbox Wiki.  Those themes may (should, really) be updated to work with the current SVN builds.
Logged
Welp, my iriver H10 20GB is out of commission again.

Offline Zardoz

  • Member
  • *
  • Posts: 226
Re: Broken WPS
« Reply #2 on: July 15, 2008, 08:26:38 PM »
I think even some of the themes in the WpsGallery may be broken, or were until recently. It's a case of fixing them yourself or contacting the author and requesting same. In fairness the change over to the new syntax was announced WELL WELL in advance and the actual commit was recorded on subversion under recent activity. But I'm inclined to agree a little, that it's not all that clear (I think a lot here have no time for "users not savvy enough" or at least 'not willing enough to try' which is maybe understandable but a little mean.) Is it possible for the RButil to accept only uptodate themes?
Logged
"And I have looked into the face of the force which put the idea in your head. You are bred and led yourself"

Offline Llorean

  • Member
  • *
  • Posts: 12931
Re: Broken WPS
« Reply #3 on: July 15, 2008, 08:33:29 PM »
RBUtil can't tell *anything* about a theme in advance. Honestly, if they were put in the wrong gallery on the theme site, RBUtil would happily install themes for the wrong player. It trusts the site.

As well, you're using development builds, you should be *expecting* things to break, honestly.
Logged

Offline Zardoz

  • Member
  • *
  • Posts: 226
Re: Broken WPS
« Reply #4 on: July 15, 2008, 08:46:10 PM »
I don't use the utility at all. (my question was directed original poster way) I accept all the 'breaks'.
Logged
"And I have looked into the face of the force which put the idea in your head. You are bred and led yourself"

Offline havic

  • Member
  • *
  • Posts: 8
Re: Broken WPS
« Reply #5 on: July 16, 2008, 12:27:51 PM »
Quote from: Zardoz on July 15, 2008, 08:26:38 PM
In fairness the change over to the new syntax was announced WELL WELL in advance and the actual commit was recorded on subversion under recent activity.

It was obviously not well announced as some one like myself who checks once every 3-4months to see what new improvements/features have been added may not have seen the subversion activity log before more was added as it changes rather quickly, almost daily. I think that under recent activity -Project news that this is more important than devcon is over. As this change effected more people than the end of devcon.

Secondly you offer a utility to easily and without checking the website, upgrade to the latest versions. So how would one know.

I realized these are all "development builds" and have dealt with many builds that have had problems and others that have been great.  I just was trying suggest other ways users could get this information when either using the RButil or one the main homepage that will stay for more than 1 day.   I mean you did announce the speex codec on the main page and it is still there.
Logged

Offline Llorean

  • Member
  • *
  • Posts: 12931
Re: Broken WPS
« Reply #6 on: July 16, 2008, 09:23:33 PM »
Honestly, considering how trivial it is to update a WPS to the new syntax, I personally thought the WPS authors would be conscientious enough to update their own themes. Apparently the authors don't care about keeping them up to date.

This was a relatively minor change in terms of underlying functionality. DevCon and Speex were major, They were "news", this was "business as usual."

The SVN log is available for all updates since 2.5 as a link from the front page. Only the most recent ones are shown. You can easily check what has changed between your version and the current one, no matter how far apart your updates are.
Logged

Offline karashata

  • Rockbox Expert
  • Member
  • *
  • Posts: 603
  • Just a fluffy dragon with too much time on my paws
    • Alex Vanderpol (karashata) on Twitter
Re: Broken WPS
« Reply #7 on: July 17, 2008, 11:55:48 AM »
I certainly can't speak for all theme authors, but I didn't find some of the changes that needed making all that "trivial".  Certainly the progress bar syntax change was trivial, but for some themes, rewriting the code to use conditional viewports rather than the old %m margin tag may take a little more work.

That being said, any theme author who actually bothers to keep their themes up-to-date once they've posted them should definitely have fixed them by now.
Logged
Welp, my iriver H10 20GB is out of commission again.

Offline Denzyl

  • Member
  • *
  • Posts: 12
Re: Broken WPS
« Reply #8 on: July 18, 2008, 03:51:27 PM »
Ah!

Thanks for the clue karashata.

I have so far totally failed to find what m% was and how it related to the new conditional viewports.
m% as a search keyword was not a great success. But 'Margin Tag' was :)

The main reason for wanting to know is that after I had to update to the latest version of Rockbox after doing major surgery on my X5L.

I wanted to get my favourite WPS back into operation again.

Unfortunately I never looked at what was in a WPS file, until now and all I knew was all the m% in that file were now defunct. But no clues on the Rockbox site of what they use to do.

Fixing the progress bar was simple, I think, with the examples given around the site.

But trying to hunting down examples or explanations of how to re-engineer the m% when I didn't know what it did, made it rather difficult to get the rest done  :D

Thanks again for the search words I needed.
Logged

Offline Hweb21

  • Member
  • *
  • Posts: 164
Re: Broken WPS
« Reply #9 on: July 18, 2008, 09:22:10 PM »
It is %m. You said X5L? Have you updated the themes you liked? I have a zenpod old version with %m and a newer one that works with new code if you want for the X5.

%m - http://rockbox.fetzig.org/wps/ZenPod_V5VP.rar
no %m - http://rockbox.fetzig.org/wps/Xen.rar (works with current build)

Both are same theme but Xen is updated/renamed
« Last Edit: July 18, 2008, 09:26:37 PM by Hweb21 »
Logged

  • Print
Pages: [1]
« previous next »
+  Rockbox Technical Forums
|-+  Support and General Use
| |-+  Theming and Appearance Customization
| | |-+  Broken WPS
 

  • SMF 2.0.17 | SMF © 2019, Simple Machines
  • Rockbox Privacy Policy
  • XHTML
  • RSS
  • WAP2

Page created in 0.101 seconds with 14 queries.